From: Jaswinder Singh <jaswinder@infradead•org>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: David Woodhouse <dwmw2@infradead•org>, linux-next@vger•kernel.org
Subject: Re: linux-next: firmware tree build failure
Date: Tue, 22 Jul 2008 13:55:57 +0530 [thread overview]
Message-ID: <1216715157.2595.12.camel@jaswinder.satnam> (raw)
In-Reply-To: <20080722180416.67461eae.sfr@canb.auug.org.au>
Hello Stephen,
On Tue, 2008-07-22 at 18:04 +1000, Stephen Rothwell wrote:
> Hi Dave,
>
> Today's linux-next build (sparc32 defconfig) failed like this:
>
> drivers/scsi/qlogicpti.c: In function `qlogicpti_load_firmware':
> drivers/scsi/qlogicpti.c:476: error: structure has no member named `sbus'
>
> I applied the following patch.
>
> I think we can conclude that this was never build tested. :-(
I am sorry for this.
This patch will solve both issues :-
diff --git a/drivers/scsi/qlogicpti.c b/drivers/scsi/qlogicpti.c
index e829d43..010372f 100644
--- a/drivers/scsi/qlogicpti.c
+++ b/drivers/scsi/qlogicpti.c
@@ -475,7 +475,7 @@ static int __devinit qlogicpti_load_firmware(struct qlogicpti *qpti)
unsigned long flags;
int i, timeout;
- err = request_firmware(&fw, fwname, &qpti->sbus->ofdev.dev);
+ err = request_firmware(&fw, fwname, &qpti->sdev->ofdev.dev);
if (err) {
printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
fwname, err);
@@ -634,7 +634,7 @@ static int __devinit qlogicpti_load_firmware(struct qlogicpti *qpti)
out:
spin_unlock_irqrestore(host->host_lock, flags);
outfirm:
- release_firwmare(fw);
+ release_firmware(fw);
return err;
}
next prev parent reply other threads:[~2008-07-22 8:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 8:04 linux-next: firmware tree build failure Stephen Rothwell
2008-07-22 8:25 ` Jaswinder Singh [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-04-14 4:12 Stephen Rothwell
2009-04-14 12:25 ` David Woodhouse
2009-04-15 1:56 ` David Woodhouse
2009-04-15 2:03 ` Stephen Rothwell
2008-07-22 7:57 Stephen Rothwell
2008-07-22 7:47 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216715157.2595.12.camel@jaswinder.satnam \
--to=jaswinder@infradead$(echo .)org \
--cc=dwmw2@infradead$(echo .)org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox