From: David Woodhouse <dwmw2@infradead•org>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linux-next@vger•kernel.org, "David S. Miller" <davem@davemloft•net>
Subject: Re: linux-next: firmware tree build failure
Date: Tue, 14 Apr 2009 13:25:06 +0100 [thread overview]
Message-ID: <1239711906.3342.229.camel@macbook.infradead.org> (raw)
In-Reply-To: <20090414141254.70ddc8ce.sfr@canb.auug.org.au>
On Tue, 2009-04-14 at 14:12 +1000, Stephen Rothwell wrote:
> Hi Dave,
>
> Today's linux-next build (sparc64 defconfig) failed like this:
>
> drivers/base/firmware_class.c: In function 'firmware_loading_store':
> drivers/base/firmware_class.c:173: error: 'PAGE_KERNEL_RO' undeclared (first use in this function)
>
> Caused by commit 0bb1338d4467c143987560f841130292c124074c ("firmware:
> speed up request_firmware()"). PAGE_KERNEL_RO appears to not be defined
> for several architectures.
>
> I have reverted that commit for today.
Ah, thanks. The fix for lack of PAGE_KERNEL_EXEC in vmalloc.c seems to
be:
#ifndef PAGE_KERNEL_EXEC
# define PAGE_KERNEL_EXEC PAGE_KERNEL
#endif
I think I'll do the equivalent for PAGE_KERNEL_RO, and at least we'll be
mapping the firmware images as read-only on _some_ architectures.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel•com Intel Corporation
next prev parent reply other threads:[~2009-04-14 12:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-14 4:12 linux-next: firmware tree build failure Stephen Rothwell
2009-04-14 12:25 ` David Woodhouse [this message]
2009-04-15 1:56 ` David Woodhouse
2009-04-15 2:03 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2008-07-22 8:04 Stephen Rothwell
2008-07-22 8:25 ` Jaswinder Singh
2008-07-22 7:57 Stephen Rothwell
2008-07-22 7:47 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239711906.3342.229.camel@macbook.infradead.org \
--to=dwmw2@infradead$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox