From: Trond Myklebust <trond.myklebust@fys•uio.no>
To: Benny Halevy <bhalevy@panasas•com>
Cc: Andy Adamson <andros@netapp•com>,
pnfs@linux-nfs•org, Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org
Subject: Re: [PATCH] nfs41: get rid of unused struct nfs41_exchange_id_res members
Date: Tue, 05 May 2009 18:39:25 -0400 [thread overview]
Message-ID: <1241563165.5174.120.camel@heimdal.trondhjem.org> (raw)
In-Reply-To: <4A00BA9D.6080501@panasas.com>
On Wed, 2009-05-06 at 01:15 +0300, Benny Halevy wrote:
> On 2009-05-06 01:12, Trond Myklebust wrote:
> > Not necessary. Look again at the first line of the READ_BUF(nbytes)
> > macro:
> >
> > p = xdr_inline_decode(xdr, nbytes);
> >
> > So the value of 'p' is always correctly set to the beginning of the
> > buffer of length 'nbytes'.
>
> Right, but then we want to skip over the buffer.
The next call to READ_BUF() will take care of updating p to the
beginning of the next buffer irrespective of whether or not you have
read data from the current buffer.
Cheers
Trond
next prev parent reply other threads:[~2009-05-05 22:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-01 3:15 linux-next: nfs tree build warning Stephen Rothwell
2009-05-01 3:22 ` Trond Myklebust
2009-05-01 12:19 ` Benny Halevy
2009-05-01 14:56 ` William A. (Andy) Adamson
2009-05-01 20:14 ` [PATCH] nfs41: get rid of unused struct nfs41_exchange_id_res members Benny Halevy
2009-05-05 19:34 ` Trond Myklebust
2009-05-05 19:39 ` Trond Myklebust
2009-05-05 19:41 ` Trond Myklebust
2009-05-05 20:28 ` Benny Halevy
2009-05-05 20:35 ` Benny Halevy
2009-05-05 22:12 ` Trond Myklebust
2009-05-05 22:15 ` Benny Halevy
2009-05-05 22:39 ` Trond Myklebust [this message]
2009-05-07 15:56 ` Benny Halevy
2009-05-07 16:00 ` [PATCH 1/6] nfs41: Ignoring impid in decode_exchange_id is missing a READ_BUF Benny Halevy
2009-05-07 16:00 ` [PATCH 2/6] nfs41: fix Xcode_exchange_id's xdr Xcoding pointer type Benny Halevy
2009-05-07 16:00 ` [PATCH 3/6] nfs41: get rid of unused struct nfs41_exchange_id_res members Benny Halevy
2009-05-07 16:00 ` [PATCH 4/6] nfs41: fix Xcode_create_session's xdr Xcoding pointer type Benny Halevy
2009-05-07 16:00 ` [PATCH 5/6] nfs41: refactor decoding of channel attributes Benny Halevy
2009-05-07 16:01 ` [PATCH 6/6] nfs41: fix encode_destroy_session's xdr Xcoding pointer type Benny Halevy
2009-05-05 22:43 ` [pnfs] [PATCH] nfs41: get rid of unused struct nfs41_exchange_id_res members J. Bruce Fields
2009-06-09 9:13 ` linux-next: nfs tree build warning Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241563165.5174.120.camel@heimdal.trondhjem.org \
--to=trond.myklebust@fys$(echo .)uio.no \
--cc=andros@netapp$(echo .)com \
--cc=bhalevy@panasas$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=pnfs@linux-nfs$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox