From: "William A. (Andy) Adamson" <androsadamson@gmail•com>
To: Benny Halevy <bhalevy@panasas•com>
Cc: Trond Myklebust <trond.myklebust@fys•uio.no>,
Andy Adamson <andros@umich•edu>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org
Subject: Re: linux-next: nfs tree build warning
Date: Fri, 1 May 2009 10:56:20 -0400 [thread overview]
Message-ID: <89c397150905010756h503498d4n9fd2f8bb3ce403c3@mail.gmail.com> (raw)
In-Reply-To: <49FAE8B4.6020500@panasas.com>
On Fri, May 1, 2009 at 8:19 AM, Benny Halevy <bhalevy@panasas•com> wrote:
> On May. 01, 2009, 6:22 +0300, Trond Myklebust <trond.myklebust@fys•uio.no> wrote:
>> On Fri, 2009-05-01 at 13:15 +1000, Stephen Rothwell wrote:
>>> Hi Trond,
>>>
>>> Today's linux-next build (x86_64 allmodconfig) produced this warning:
>>>
>>> fs/nfs/nfs4proc.c: In function 'nfs4_proc_exchange_id':
>>> fs/nfs/nfs4proc.c:4279: warning: the frame size of 2288 bytes is larger than 2048 bytes
>>>
>>> Introduced by commit 63a93b4af49220c74757beb17b5617b72d912b6b ("nfs41:
>>> exchange_id operation"). This commit has been around for a while.
>>
>> Benny, Andy,
>>
>> Why are we preallocating 1k buffers on the stack for these things?
>> That's an insane amount of free space...
>>
>> If this is truly a realistic value (which I sincerely doubt), then the
>> right thing to do is to preallocate a page in which to store them.
>> Putting 1k arrays on the stack is just _wrong_.
>>
>> Trond
>>
>
> Ouch, struct nfs41_exchange_id_res contains
> struct server_owner server_owner;
> struct server_scope server_scope;
> each embedding a char [NFS4_OPAQUE_LIMIT] array
> which is 1K in length.
> Not only we should have preallocated these arrays dynamically,
> we actually throw them away.
> Therefore I suggest that until they are put to use
> we should just skip their xdr decoding, like we do
> for the implementation ID.
Yes, I agree. That is just wrong....
-->Andy
>
> Benny
>
next prev parent reply other threads:[~2009-05-01 14:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-01 3:15 linux-next: nfs tree build warning Stephen Rothwell
2009-05-01 3:22 ` Trond Myklebust
2009-05-01 12:19 ` Benny Halevy
2009-05-01 14:56 ` William A. (Andy) Adamson [this message]
2009-05-01 20:14 ` [PATCH] nfs41: get rid of unused struct nfs41_exchange_id_res members Benny Halevy
2009-05-05 19:34 ` Trond Myklebust
2009-05-05 19:39 ` Trond Myklebust
2009-05-05 19:41 ` Trond Myklebust
2009-05-05 20:28 ` Benny Halevy
2009-05-05 20:35 ` Benny Halevy
2009-05-05 22:12 ` Trond Myklebust
2009-05-05 22:15 ` Benny Halevy
2009-05-05 22:39 ` Trond Myklebust
2009-05-07 15:56 ` Benny Halevy
2009-05-07 16:00 ` [PATCH 1/6] nfs41: Ignoring impid in decode_exchange_id is missing a READ_BUF Benny Halevy
2009-05-07 16:00 ` [PATCH 2/6] nfs41: fix Xcode_exchange_id's xdr Xcoding pointer type Benny Halevy
2009-05-07 16:00 ` [PATCH 3/6] nfs41: get rid of unused struct nfs41_exchange_id_res members Benny Halevy
2009-05-07 16:00 ` [PATCH 4/6] nfs41: fix Xcode_create_session's xdr Xcoding pointer type Benny Halevy
2009-05-07 16:00 ` [PATCH 5/6] nfs41: refactor decoding of channel attributes Benny Halevy
2009-05-07 16:01 ` [PATCH 6/6] nfs41: fix encode_destroy_session's xdr Xcoding pointer type Benny Halevy
2009-05-05 22:43 ` [pnfs] [PATCH] nfs41: get rid of unused struct nfs41_exchange_id_res members J. Bruce Fields
2009-06-09 9:13 ` linux-next: nfs tree build warning Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2009-06-19 0:50 Stephen Rothwell
2009-06-19 1:09 ` Trond Myklebust
2009-06-19 2:00 ` Stephen Rothwell
2009-08-10 0:58 Stephen Rothwell
2009-08-10 12:51 ` Trond Myklebust
2009-12-31 0:01 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89c397150905010756h503498d4n9fd2f8bb3ce403c3@mail.gmail.com \
--to=androsadamson@gmail$(echo .)com \
--cc=andros@umich$(echo .)edu \
--cc=bhalevy@panasas$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=trond.myklebust@fys$(echo .)uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox