From: David Woodhouse <dwmw2@infradead•org>
To: Sachin Sant <sachinp@in•ibm.com>
Cc: LKML <linux-kernel@vger•kernel.org>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org
Subject: Re: Next May 13:[drivers/base/firmware*] Bug while booting on x86
Date: Thu, 14 May 2009 16:54:27 +0100 [thread overview]
Message-ID: <1242316467.3393.14.camel@macbook.infradead.org> (raw)
In-Reply-To: <4A0AC5E6.2010402@in.ibm.com>
On Wed, 2009-05-13 at 18:36 +0530, Sachin Sant wrote:
> BUG: unable to handle kernel NULL pointer dereference at 0000050c
> IP: [<c0119c5d>] kunmap+0x33/0x59
Oops. Does this fix it?
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -328,7 +328,7 @@ firmware_data_write(struct kobject *kobj, struct
bin_attribute *bin_attr,
memcpy(page_data + page_ofs, buffer, page_cnt);
- kunmap(page_data);
+ kunmap(fw_priv->pages[page_nr]);
buffer += page_cnt;
offset += page_cnt;
count -= page_cnt;
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel•com Intel Corporation
next prev parent reply other threads:[~2009-05-14 15:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 6:48 linux-next: Tree for May 13 Stephen Rothwell
2009-05-13 13:06 ` Next May 13:[drivers/base/firmware*] Bug while booting on x86 Sachin Sant
2009-05-14 5:31 ` Sachin Sant
2009-05-14 15:42 ` Sachin Sant
2009-05-14 15:54 ` David Woodhouse [this message]
2009-05-15 11:28 ` Sachin Sant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242316467.3393.14.camel@macbook.infradead.org \
--to=dwmw2@infradead$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sachinp@in$(echo .)ibm.com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox