From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public•gmane.org>
To: Randy Dunlap <randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public•gmane.org>
Cc: "John W. Linville"
<linville-2XuSBdqkA4R54TAoqtyWWQ@public•gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public•gmane.org>,
linux-next-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Subject: Re: [PATCH] wireless: make WEXT_SPY and WEXT_PRIV select WEXT_CORE
Date: Thu, 08 Oct 2009 11:48:02 +0200 [thread overview]
Message-ID: <1254995282.3713.18.camel@johannes.local> (raw)
In-Reply-To: <20091007171235.d40f0cc2.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1323 bytes --]
On Wed, 2009-10-07 at 17:12 -0700, Randy Dunlap wrote:
> > > # CONFIG_WIRELESS is not set
> > > CONFIG_WIRELESS_EXT=y
> > > CONFIG_WEXT_SPY=y
> > > CONFIG_WEXT_PRIV=y
> > >
> > > WEXT_CORE is not enabled. I haven't found the culprit, but I suspect "select".
> >
> > Interesting.
> >
> > > but what in WIRELESS_EXT would also cause WEXT_CORE to be enabled?
> >
> > Well, the way WEXT_CORE is defined as def_bool y ought to, no?
>
> Ah, I see what you mean.
>
> Here's what's happening:
>
> net/wireless/Kconfig says:
>
> config WEXT_CORE
> def_bool y
> depends on CFG80211_WEXT || WIRELESS_EXT
>
>
> and net/Kconfig says:
>
> if WIRELESS
>
> source "net/wireless/Kconfig"
> source "net/mac80211/Kconfig"
>
> endif # WIRELESS
>
>
> so WEXT_CORE actually depends on NET && WIRELESS && (CFG80211_WEXT || WIRELESS_EXT)
> (that's what xconfig shows me).
> But WIRELESS is not enabled. Pooh.
>
> I was already toying with making CONFIG_WIRELESS a real/usable kconfig symbol.
> That may have to be done unless someone else comes up with another solution.
Ah!
It's kinda strange though that you can select wireless drivers without
selecting WIRELESS. Maybe the solution is as simple as making WLAN
(drivers/net/wireless/Kconfig) depend on WIRELESS?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-10-08 9:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 6:35 linux-next: Tree for October 7 Stephen Rothwell
2009-10-07 10:54 ` next-20091007 - comedi driver build breaks on S390x Kamalesh Babulal
2009-10-07 13:07 ` Greg KH
2009-10-07 15:34 ` Martin Schwidefsky
2009-10-07 17:27 ` Greg KH
2009-10-08 8:55 ` Martin Schwidefsky
2009-10-07 17:21 ` [PATCH -next] drbd: needs __ratelimit() Randy Dunlap
[not found] ` <20091007102153.1a19119b.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2009-10-07 17:26 ` Jens Axboe
2009-10-07 17:22 ` [PATCH -next] vbus: proxy uses, select IOQ Randy Dunlap
2009-10-07 18:19 ` Gregory Haskins
2009-10-07 17:52 ` linux-next: Tree for October 7 (libertas build failure) Randy Dunlap
2009-10-07 18:12 ` Dan Williams
[not found] ` <1254939120.16001.45.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-10-07 22:34 ` Johannes Berg
[not found] ` <20091007173517.abfcfa2a.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2009-10-07 17:57 ` linux-next: Tree for October 7 (wireless/wext) Randy Dunlap
2009-10-07 21:07 ` [PATCH] wireless: make WEXT_SPY and WEXT_PRIV select WEXT_CORE John W. Linville
2009-10-07 21:55 ` Randy Dunlap
[not found] ` <4ACD0E5A.7060106-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2009-10-07 22:34 ` Johannes Berg
[not found] ` <1254954842.3713.7.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-10-07 22:54 ` Randy Dunlap
2009-10-07 23:14 ` Johannes Berg
[not found] ` <1254957256.3713.10.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-10-08 0:12 ` Randy Dunlap
[not found] ` <20091007171235.d40f0cc2.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2009-10-08 9:48 ` Johannes Berg [this message]
2009-10-08 15:06 ` Randy Dunlap
2009-10-08 18:29 ` Johannes Berg
2009-10-09 16:06 ` Randy Dunlap
2009-10-09 16:14 ` Johannes Berg
[not found] ` <1255104846.4095.2.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-10-09 16:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254995282.3713.18.camel@johannes.local \
--to=johannes-cdvu00un1vgdhxzaddlk8q@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public$(echo .)gmane.org \
--cc=randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox