From: Martin Schwidefsky <schwidefsky@de•ibm.com>
To: Greg KH <gregkh@suse•de>
Cc: Kamalesh Babulal <kamalesh@linux•vnet.ibm.com>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Stephen Rothwell <sfr@canb•auug.org.au>,
devel@driverdev•osuosl.org, heiko.carstens@de•ibm.com,
linux-s390@vger•kernel.org
Subject: Re: next-20091007 - comedi driver build breaks on S390x
Date: Thu, 8 Oct 2009 10:55:28 +0200 [thread overview]
Message-ID: <20091008105528.55616624@mschwide.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20091007172715.GA28562@suse.de>
On Wed, 7 Oct 2009 10:27:15 -0700
Greg KH <gregkh@suse•de> wrote:
> On Wed, Oct 07, 2009 at 05:34:15PM +0200, Martin Schwidefsky wrote:
> > On Wed, 7 Oct 2009 06:07:44 -0700
> > Greg KH <gregkh@suse•de> wrote:
> >
> > > On Wed, Oct 07, 2009 at 04:24:58PM +0530, Kamalesh Babulal wrote:
> > > > Hi Greg,
> > > >
> > > > next-20091007 randconfig build breaks on s390x with build error
> > > >
> > > > drivers/staging/comedi/comedi_fops.c: In function 'comedi_mmap':
> > > > drivers/staging/comedi/comedi_fops.c:1453: error: 'PAGE_SHARED' undeclared (first use in this function)
> > > > drivers/staging/comedi/comedi_fops.c:1453: error: (Each undeclared identifier is reported only once
> > > > drivers/staging/comedi/comedi_fops.c:1453: error: for each function it appears in.)
> > > > make[3]: *** [drivers/staging/comedi/comedi_fops.o] Error 1
> > >
> > > Odd. What changed in the header files to cause this?
> >
> > The problem has always been present, only now did randconfig find it.
> > The compile breaks because PAGE_SHARED is not defined for s390. The
> > equivalent define for s390 is PAGE_RW. The problem has not shown up so
> > far because all drivers who use the remap_pfn_range call with
> > PAGE_SHARED has dependencies not available on s390, e.g. CONFIG_PCI.
> >
> > To fix this I see are two options: 1) add a PAGE_SHARED define to
> > arch/s390/include/asm/pgtable.h, 2) make comedi depend on !S390.
>
> I'll drop s390 support for comedi, it doesn't make sense at all for that
> platform.
>
> Actually, I'll just go off of PCI/ISA/USB/PCMCIA, that should drop s390
> automatically, right?
Correct.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2009-10-08 8:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 6:35 linux-next: Tree for October 7 Stephen Rothwell
2009-10-07 10:54 ` next-20091007 - comedi driver build breaks on S390x Kamalesh Babulal
2009-10-07 13:07 ` Greg KH
2009-10-07 15:34 ` Martin Schwidefsky
2009-10-07 17:27 ` Greg KH
2009-10-08 8:55 ` Martin Schwidefsky [this message]
2009-10-07 17:21 ` [PATCH -next] drbd: needs __ratelimit() Randy Dunlap
[not found] ` <20091007102153.1a19119b.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2009-10-07 17:26 ` Jens Axboe
2009-10-07 17:22 ` [PATCH -next] vbus: proxy uses, select IOQ Randy Dunlap
2009-10-07 18:19 ` Gregory Haskins
2009-10-07 17:52 ` linux-next: Tree for October 7 (libertas build failure) Randy Dunlap
2009-10-07 18:12 ` Dan Williams
[not found] ` <1254939120.16001.45.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-10-07 22:34 ` Johannes Berg
[not found] ` <20091007173517.abfcfa2a.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2009-10-07 17:57 ` linux-next: Tree for October 7 (wireless/wext) Randy Dunlap
2009-10-07 21:07 ` [PATCH] wireless: make WEXT_SPY and WEXT_PRIV select WEXT_CORE John W. Linville
2009-10-07 21:55 ` Randy Dunlap
[not found] ` <4ACD0E5A.7060106-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2009-10-07 22:34 ` Johannes Berg
[not found] ` <1254954842.3713.7.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-10-07 22:54 ` Randy Dunlap
2009-10-07 23:14 ` Johannes Berg
[not found] ` <1254957256.3713.10.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-10-08 0:12 ` Randy Dunlap
[not found] ` <20091007171235.d40f0cc2.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2009-10-08 9:48 ` Johannes Berg
2009-10-08 15:06 ` Randy Dunlap
2009-10-08 18:29 ` Johannes Berg
2009-10-09 16:06 ` Randy Dunlap
2009-10-09 16:14 ` Johannes Berg
[not found] ` <1255104846.4095.2.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-10-09 16:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091008105528.55616624@mschwide.boeblingen.de.ibm.com \
--to=schwidefsky@de$(echo .)ibm.com \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=gregkh@suse$(echo .)de \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=kamalesh@linux$(echo .)vnet.ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox