From: Steven Rostedt <rostedt@goodmis•org>
To: Jeremy Fitzhardinge <jeremy@goop•org>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle•com>,
Ingo Molnar <mingo@elte•hu>,
Stephen Rothwell <sfr@canb•auug.org.au>,
xen-devel@lists•xensource.com,
LKML <linux-kernel@vger•kernel.org>,
virtualization@lists•linux-foundation.org,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix•com>,
linux-next@vger•kernel.org, "H. Peter Anvin" <hpa@zytor•com>,
Andrew Morton <akpm@linux-foundation•org>,
Linus Torvalds <torvalds@linux-foundation•org>,
Thomas Gleixner <tglx@linutronix•de>
Subject: Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)
Date: Mon, 08 Aug 2011 09:01:07 -0400 [thread overview]
Message-ID: <1312808467.18583.223.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <4E3D8657.7000704@goop.org>
On Sat, 2011-08-06 at 11:22 -0700, Jeremy Fitzhardinge wrote:
> On 08/05/2011 06:58 PM, Konrad Rzeszutek Wilk wrote:
> > On Fri, Aug 05, 2011 at 11:14:23PM +0200, Ingo Molnar wrote:
> >> * Ingo Molnar <mingo@elte•hu> wrote:
> >>
> >>> * Randy Dunlap <rdunlap@xenotime•net> wrote:
> >>>
> >>>> On 08/04/11 15:40, Konrad Rzeszutek Wilk wrote:
> >>>>> On Thu, Aug 04, 2011 at 06:32:59PM -0400, Konrad Rzeszutek Wilk wrote:
> >>>>>>>>> These build failures are still triggering upstream:
> >>>>>>>>>
> >>>>>>>>> arch/x86/xen/trace.c:44:2: error: array index in initializer not of integer type
> >>>>>>>>> arch/x86/xen/trace.c:44:2: error: (near initialization for ‘xen_hypercall_names’)
> >>>>>>>>> arch/x86/xen/trace.c:45:1: error: ‘__HYPERVISOR_arch_4’ undeclared here (not in a function)
> >>>>>>>>> arch/x86/xen/trace.c:45:2: error: array index in initializer not of integer type
> >>>>>>>>> arch/x86/xen/trace.c:45:2: error: (near initialization for ‘xen_hypercall_names’)
> >>>>>>>> Oh, that I haven't seen. Can you send me the .config for that please.
> >>>>>>> You can't be trying very hard then. I see lots of these (but no,
> >>>>>> Ah, I am getting it now. Thanks for reporting it.
> >>>>> This should do the trick:
> >>>> Acked-by: Randy Dunlap <rdunlap@xenotime•net>
> >>> That patch did the trick here too:
> >>>
> >>> Acked-by: Ingo Molnar <mingo@elte•hu>
> >> Except that i'm still seeing the occasional build failure - see the
> >> error log below. Config attached.
> > Much appreciate for the report. I believe this fix (which I think hit
> > linux-next yesterday?) should do that:
> >
> > commit 1e9ea2656b656edd3c8de98675bbc0340211b5bd
> > Author: Jeremy Fitzhardinge <jeremy@goop•org>
> > Date: Wed Aug 3 09:43:44 2011 -0700
> >
> > xen/tracing: it looks like we wanted CONFIG_FTRACE
> >
> > Apparently we wanted CONFIG_FTRACE rather the CONFIG_FUNCTION_TRACER.
> >
> > Reported-by: Sander Eikelenboom <linux@eikelenboom•it>
> > Tested-by: Sander Eikelenboom <linux@eikelenboom•it>
> > Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix•com>
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle•com>
> >
> > diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile
> > index 45e94ac..3326204 100644
> > --- a/arch/x86/xen/Makefile
> > +++ b/arch/x86/xen/Makefile
> > @@ -15,7 +15,7 @@ obj-y := enlighten.o setup.o multicalls.o mmu.o irq.o \
> > grant-table.o suspend.o platform-pci-unplug.o \
> > p2m.o
> >
> > -obj-$(CONFIG_FUNCTION_TRACER) += trace.o
> > +obj-$(CONFIG_FTRACE) += trace.o
> >
>
> I'm not sure this is correct either. Maybe it should be
> CONFIG_TRACEPOINTS? Steven?
Actually, I believe the correct answer is:
CONFIG_EVENT_TRACING
-- Steve
next prev parent reply other threads:[~2011-08-08 13:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 6:25 linux-next: Tree for July 25 Stephen Rothwell
2011-07-25 16:19 ` [PATCH -next] watchdog: fix it8712f_wdt build errors Randy Dunlap
2011-07-25 19:02 ` Wim Van Sebroeck
2011-07-25 18:01 ` [PATCH -next] kvm: fix TASK_DELAY_ACCT kconfig warning Randy Dunlap
2011-07-27 11:19 ` Avi Kivity
2011-07-25 21:46 ` linux-next: Tree for July 25 (xen) Randy Dunlap
2011-08-04 19:35 ` Ingo Molnar
2011-08-04 19:55 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-08-04 20:15 ` Randy Dunlap
2011-08-04 22:30 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-08-04 23:22 ` Randy Dunlap
2011-08-04 22:32 ` Konrad Rzeszutek Wilk
2011-08-04 22:40 ` Konrad Rzeszutek Wilk
2011-08-04 23:24 ` Randy Dunlap
2011-08-04 23:53 ` Randy Dunlap
2011-08-05 8:05 ` Ingo Molnar
2011-08-05 21:14 ` Ingo Molnar
2011-08-06 1:58 ` Konrad Rzeszutek Wilk
2011-08-06 7:04 ` Stephen Rothwell
2011-08-06 18:22 ` Jeremy Fitzhardinge
2011-08-08 13:01 ` Steven Rostedt [this message]
2011-08-10 16:49 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312808467.18583.223.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=hpa@zytor$(echo .)com \
--cc=jeremy.fitzhardinge@citrix$(echo .)com \
--cc=jeremy@goop$(echo .)org \
--cc=konrad.wilk@oracle$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mingo@elte$(echo .)hu \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tglx@linutronix$(echo .)de \
--cc=torvalds@linux-foundation$(echo .)org \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=xen-devel@lists$(echo .)xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox