public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed

From: Wim Van Sebroeck <wim@iguana•be>
To: Randy Dunlap <rdunlap@xenotime•net>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
	jorge@dti2•net, Wim Van Sebroeck <wim@iguana•be>,
	linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
	linux-watchdog@vger•kernel.org, akpm <akpm@linux-foundation•org>
Subject: Re: [PATCH -next] watchdog: fix it8712f_wdt build errors
Date: Mon, 25 Jul 2011 21:02:41 +0200	[thread overview]
Message-ID: <20110725190241.GZ3834@infomag.iguana.be> (raw)
In-Reply-To: <20110725091927.e154fd28.rdunlap@xenotime.net>

Hi Randy,

> From: Randy Dunlap <rdunlap@xenotime•net>
> 
> Fix build errors by adding missing header file:
> 
> drivers/watchdog/it8712f_wdt.c:127: error: implicit declaration of function 'request_muxed_region'
> drivers/watchdog/it8712f_wdt.c:141: error: implicit declaration of function 'release_region'
> drivers/watchdog/it8712f_wdt.c:412: error: implicit declaration of function 'request_region'
> 
> Signed-off-by: Randy Dunlap <rdunlap@xenotime•net>
> ---
>  drivers/watchdog/it8712f_wdt.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20110725.orig/drivers/watchdog/it8712f_wdt.c
> +++ linux-next-20110725/drivers/watchdog/it8712f_wdt.c
> @@ -31,6 +31,7 @@
>  #include <linux/spinlock.h>
>  #include <linux/uaccess.h>
>  #include <linux/io.h>
> +#include <linux/ioport.h>
>  
>  #define NAME "it8712f_wdt"

I see what happened: The pci.h removal patch compiled ok and the patch that introduced the muxed_region code also compiled ok (with pci.h still included). However both patches together reveal the issue indeed (pci.h includes ioport.h).

Sorry about that. I have added your patch for it.

Thanks,
wim.

next prev parent reply	other threads:[~2011-07-25 19:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-25  6:25 linux-next: Tree for July 25 Stephen Rothwell
2011-07-25 16:19 ` [PATCH -next] watchdog: fix it8712f_wdt build errors Randy Dunlap
2011-07-25 19:02   ` Wim Van Sebroeck [this message]
2011-07-25 18:01 ` [PATCH -next] kvm: fix TASK_DELAY_ACCT kconfig warning Randy Dunlap
2011-07-27 11:19   ` Avi Kivity
2011-07-25 21:46 ` linux-next: Tree for July 25 (xen) Randy Dunlap
2011-08-04 19:35   ` Ingo Molnar
2011-08-04 19:55     ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-08-04 20:15       ` Randy Dunlap
2011-08-04 22:30         ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-08-04 23:22           ` Randy Dunlap
2011-08-04 22:32         ` Konrad Rzeszutek Wilk
2011-08-04 22:40           ` Konrad Rzeszutek Wilk
2011-08-04 23:24             ` Randy Dunlap
2011-08-04 23:53             ` Randy Dunlap
2011-08-05  8:05               ` Ingo Molnar
2011-08-05 21:14                 ` Ingo Molnar
2011-08-06  1:58                   ` Konrad Rzeszutek Wilk
2011-08-06  7:04                     ` Stephen Rothwell
2011-08-06 18:22                     ` Jeremy Fitzhardinge
2011-08-08 13:01                       ` Steven Rostedt
2011-08-10 16:49                         ` Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110725190241.GZ3834@infomag.iguana.be \
    --to=wim@iguana$(echo .)be \
    --cc=akpm@linux-foundation$(echo .)org \
    --cc=jorge@dti2$(echo .)net \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=linux-watchdog@vger$(echo .)kernel.org \
    --cc=rdunlap@xenotime$(echo .)net \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox