* [PATCH] staging: add module.h to various iio drivers
@ 2011-09-30 22:06 Paul Gortmaker
[not found] ` <1317420418-28335-1-git-send-email-paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Paul Gortmaker @ 2011-09-30 22:06 UTC (permalink / raw)
To: gregkh-l3A5Bk7waGM
Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA,
linux-next-u79uwXL29TY76Z2rM5mHXA, Paul Gortmaker
Since they are assuming it is there implicitly and will fail otherwise
with things like:
drivers/staging/iio/impedance-analyzer/ad5933.c:816: warning: type
defaults to ‘int’ in declaration of ‘MODULE_AUTHOR’
drivers/staging/iio/adc/ad7280a.c:990: warning: type defaults to ‘int’
in declaration of ‘MODULE_AUTHOR’
Signed-off-by: Paul Gortmaker <paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public•gmane.org>
diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
index ab6cf9c..6ca4532 100644
--- a/drivers/staging/iio/adc/ad7280a.c
+++ b/drivers/staging/iio/adc/ad7280a.c
@@ -14,6 +14,7 @@
#include <linux/err.h>
#include <linux/delay.h>
#include <linux/interrupt.h>
+#include <linux/module.h>
#include "../iio.h"
#include "../sysfs.h"
diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
index acc0e69..5783742 100644
--- a/drivers/staging/iio/impedance-analyzer/ad5933.c
+++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
@@ -16,6 +16,7 @@
#include <linux/types.h>
#include <linux/err.h>
#include <linux/delay.h>
+#include <linux/module.h>
#include <asm/div64.h>
#include "../iio.h"
--
1.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread[parent not found: <1317420418-28335-1-git-send-email-paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>]
* RE: [PATCH] staging: add module.h to various iio drivers [not found] ` <1317420418-28335-1-git-send-email-paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> @ 2011-10-05 6:39 ` Hennerich, Michael 0 siblings, 0 replies; 2+ messages in thread From: Hennerich, Michael @ 2011-10-05 6:39 UTC (permalink / raw) To: Paul Gortmaker, gregkh-l3A5Bk7waGM@public•gmane.org Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA@public•gmane.org, linux-next-u79uwXL29TY76Z2rM5mHXA@public•gmane.org, Device-drivers-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public•gmane.org Paul Gortmaker wrote on 2011-10-01: > Since they are assuming it is there implicitly and will fail otherwise > with things like: > > drivers/staging/iio/impedance-analyzer/ad5933.c:816: warning: type > defaults to ‘int’ in declaration of ‘MODULE_AUTHOR’ > drivers/staging/iio/adc/ad7280a.c:990: warning: type defaults to ‘int’ > in declaration of ‘MODULE_AUTHOR’ > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com> Acked-by: Michael Hennerich <michael.hennerich@analog•com> > > diff --git a/drivers/staging/iio/adc/ad7280a.c > b/drivers/staging/iio/adc/ad7280a.c index ab6cf9c..6ca4532 100644 --- > a/drivers/staging/iio/adc/ad7280a.c +++ > b/drivers/staging/iio/adc/ad7280a.c @@ -14,6 +14,7 @@ > #include <linux/err.h> > #include <linux/delay.h> > #include <linux/interrupt.h> > +#include <linux/module.h> > > #include "../iio.h" > #include "../sysfs.h" > diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c > b/drivers/staging/iio/impedance-analyzer/ad5933.c index acc0e69..5783742 > 100644 --- a/drivers/staging/iio/impedance-analyzer/ad5933.c +++ > b/drivers/staging/iio/impedance-analyzer/ad5933.c @@ -16,6 +16,7 @@ > #include <linux/types.h> #include <linux/err.h> #include > <linux/delay.h> +#include <linux/module.h> #include <asm/div64.h> > > #include "../iio.h" Greetings, Michael -- Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-05 6:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-30 22:06 [PATCH] staging: add module.h to various iio drivers Paul Gortmaker
[not found] ` <1317420418-28335-1-git-send-email-paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2011-10-05 6:39 ` Hennerich, Michael
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox