public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: "Vincent Stehlé" <vincent.stehle@freescale•com>
To: linux-arm-kernel@lists•infradead.org,
	linux-kernel@vger•kernel.org, linux-next@vger•kernel.org
Cc: "Vincent Stehlé" <vincent.stehle@freescale•com>,
	"Matt Porter" <mporter@ti•com>, "Sekhar Nori" <nsekhar@ti•com>,
	"Vinod Koul" <vinod.koul@intel•com>, "Dan Williams" <djbw@fb•com>,
	"Russell King" <linux@arm•linux.org.uk>
Subject: [PATCH linux-next] edma: select arch common code to fix link
Date: Tue, 9 Jul 2013 18:49:20 +0200	[thread overview]
Message-ID: <1373388560-5129-1-git-send-email-vincent.stehle@freescale.com> (raw)

EDMA code has been moved to a common folder with a new CONFIG_TI_PRIV_EDMA
switch. Select it when the edma driver is enabled.

This fixes the following link error:

  drivers/built-in.o: In function `edma_remove':
  of_iommu.c:(.text+0x4ef20): undefined reference to `edma_free_slot'
  drivers/built-in.o: In function `edma_control':
  of_iommu.c:(.text+0x4ef70): undefined reference to `edma_stop'
  drivers/built-in.o: In function `edma_execute':
  of_iommu.c:(.text+0x4f11c): undefined reference to `edma_write_slot'
  of_iommu.c:(.text+0x4f150): undefined reference to `edma_link'
  of_iommu.c:(.text+0x4f168): undefined reference to `edma_start'
  drivers/built-in.o: In function `edma_free_chan_resources':
  of_iommu.c:(.text+0x4f220): undefined reference to `edma_stop'
  of_iommu.c:(.text+0x4f304): undefined reference to `edma_free_slot'
  of_iommu.c:(.text+0x4f328): undefined reference to `edma_free_channel'
  drivers/built-in.o: In function `edma_alloc_chan_resources':
  of_iommu.c:(.text+0x4f37c): undefined reference to `edma_alloc_channel'
  of_iommu.c:(.text+0x4f3d8): undefined reference to `edma_free_channel'
  drivers/built-in.o: In function `edma_prep_slave_sg':
  of_iommu.c:(.text+0x4f67c): undefined reference to `edma_alloc_slot'
  drivers/built-in.o: In function `edma_probe':
  of_iommu.c:(.text+0x4f794): undefined reference to `edma_alloc_slot'
  of_iommu.c:(.text+0x4f8b8): undefined reference to `edma_free_slot'
  drivers/built-in.o: In function `edma_callback':
  of_iommu.c:(.text+0x4fae4): undefined reference to `edma_stop'
  make: *** [vmlinux] Error 1

Signed-off-by: Vincent Stehlé <vincent.stehle@freescale•com>
Cc: Matt Porter <mporter@ti•com>
Cc: Sekhar Nori <nsekhar@ti•com>
Cc: Vinod Koul <vinod.koul@intel•com>
Cc: Dan Williams <djbw@fb•com>
Cc: Russell King <linux@arm•linux.org.uk>
---


Hi,

Build of linux next-20130709 is broken for ARM multi_v7_defconfig. This patch
fixes it.

(Note: the error messages mentioning of_iommu.c are misleading.)

Best regards,

V.


 drivers/dma/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 6825957..8b3fca9 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -198,6 +198,7 @@ config TI_EDMA
 	depends on ARCH_DAVINCI || ARCH_OMAP
 	select DMA_ENGINE
 	select DMA_VIRTUAL_CHANNELS
+	select TI_PRIV_EDMA
 	default n
 	help
 	  Enable support for the TI EDMA controller. This DMA
-- 
1.7.10.4

                 reply	other threads:[~2013-07-09 17:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373388560-5129-1-git-send-email-vincent.stehle@freescale.com \
    --to=vincent.stehle@freescale$(echo .)com \
    --cc=djbw@fb$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=linux@arm$(echo .)linux.org.uk \
    --cc=mporter@ti$(echo .)com \
    --cc=nsekhar@ti$(echo .)com \
    --cc=vinod.koul@intel$(echo .)com \
    --cc=vstehle@debian \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox