* [PATCH] PowerCap: Error with option -Werror=format-security
@ 2013-11-04 16:53 Srinivas Pandruvada
2013-11-04 19:51 ` Kees Cook
0 siblings, 1 reply; 3+ messages in thread
From: Srinivas Pandruvada @ 2013-11-04 16:53 UTC (permalink / raw)
To: linux-next
Cc: keescook, fengguang.wu, rafael.j.wysocki, linux-pm,
Srinivas Pandruvada
Fix compile error with gcc option: -Werror=format-security for
dev_set_name(&control_type->dev, name)
Changed to
dev_set_name(&control_type->dev, "%s", name);
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux•intel.com>
---
drivers/powercap/powercap_sys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/powercap/powercap_sys.c b/drivers/powercap/powercap_sys.c
index 21814f9..8d0fe43 100644
--- a/drivers/powercap/powercap_sys.c
+++ b/drivers/powercap/powercap_sys.c
@@ -625,7 +625,7 @@ struct powercap_control_type *powercap_register_control_type(
control_type->ops = ops;
INIT_LIST_HEAD(&control_type->node);
control_type->dev.class = &powercap_class;
- dev_set_name(&control_type->dev, name);
+ dev_set_name(&control_type->dev, "%s", name);
result = device_register(&control_type->dev);
if (result) {
if (control_type->allocated)
--
1.7.11.7
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] PowerCap: Error with option -Werror=format-security
2013-11-04 16:53 [PATCH] PowerCap: Error with option -Werror=format-security Srinivas Pandruvada
@ 2013-11-04 19:51 ` Kees Cook
2013-11-05 14:25 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Kees Cook @ 2013-11-04 19:51 UTC (permalink / raw)
To: Srinivas Pandruvada; +Cc: Linux-Next, Fengguang Wu, Rafael J. Wysocki, linux-pm
On Mon, Nov 4, 2013 at 8:53 AM, Srinivas Pandruvada
<srinivas.pandruvada@linux•intel.com> wrote:
> Fix compile error with gcc option: -Werror=format-security for
> dev_set_name(&control_type->dev, name)
> Changed to
> dev_set_name(&control_type->dev, "%s", name);
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux•intel.com>
> ---
> drivers/powercap/powercap_sys.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/powercap/powercap_sys.c b/drivers/powercap/powercap_sys.c
> index 21814f9..8d0fe43 100644
> --- a/drivers/powercap/powercap_sys.c
> +++ b/drivers/powercap/powercap_sys.c
> @@ -625,7 +625,7 @@ struct powercap_control_type *powercap_register_control_type(
> control_type->ops = ops;
> INIT_LIST_HEAD(&control_type->node);
> control_type->dev.class = &powercap_class;
> - dev_set_name(&control_type->dev, name);
> + dev_set_name(&control_type->dev, "%s", name);
> result = device_register(&control_type->dev);
> if (result) {
> if (control_type->allocated)
> --
> 1.7.11.7
Thanks for getting this fixed!
Acked-by: Kees Cook <keescook@chromium•org>
-Kees
--
Kees Cook
Chrome OS Security
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] PowerCap: Error with option -Werror=format-security
2013-11-04 19:51 ` Kees Cook
@ 2013-11-05 14:25 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2013-11-05 14:25 UTC (permalink / raw)
To: Kees Cook
Cc: Srinivas Pandruvada, Linux-Next, Fengguang Wu, Rafael J. Wysocki,
linux-pm
On Monday, November 04, 2013 11:51:25 AM Kees Cook wrote:
> On Mon, Nov 4, 2013 at 8:53 AM, Srinivas Pandruvada
> <srinivas.pandruvada@linux•intel.com> wrote:
> > Fix compile error with gcc option: -Werror=format-security for
> > dev_set_name(&control_type->dev, name)
> > Changed to
> > dev_set_name(&control_type->dev, "%s", name);
> >
> > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux•intel.com>
> > ---
> > drivers/powercap/powercap_sys.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/powercap/powercap_sys.c b/drivers/powercap/powercap_sys.c
> > index 21814f9..8d0fe43 100644
> > --- a/drivers/powercap/powercap_sys.c
> > +++ b/drivers/powercap/powercap_sys.c
> > @@ -625,7 +625,7 @@ struct powercap_control_type *powercap_register_control_type(
> > control_type->ops = ops;
> > INIT_LIST_HEAD(&control_type->node);
> > control_type->dev.class = &powercap_class;
> > - dev_set_name(&control_type->dev, name);
> > + dev_set_name(&control_type->dev, "%s", name);
> > result = device_register(&control_type->dev);
> > if (result) {
> > if (control_type->allocated)
> > --
> > 1.7.11.7
>
> Thanks for getting this fixed!
>
> Acked-by: Kees Cook <keescook@chromium•org>
Queued up for 3.13, thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-05 14:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-04 16:53 [PATCH] PowerCap: Error with option -Werror=format-security Srinivas Pandruvada
2013-11-04 19:51 ` Kees Cook
2013-11-05 14:25 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox