From: Paul Gortmaker <paul.gortmaker@windriver•com>
To: sparclinux@vger•kernel.org
Cc: "David S. Miller" <davem@davemloft•net>,
linux-kernel@vger•kernel.org, linux-next@vger•kernel.org,
Paul Gortmaker <paul.gortmaker@windriver•com>,
Stephen Rothwell <sfr@canb•auug.org.au>,
Tejun Heo <tj@kernel•org>
Subject: [PATCH] sparc: fix implicit include of slab.h in leon_pci_grpci2.c
Date: Thu, 13 Feb 2014 10:59:18 -0500 [thread overview]
Message-ID: <1392307158-6932-1-git-send-email-paul.gortmaker@windriver.com> (raw)
To fix:
arch/sparc/kernel/leon_pci_grpci2.c: In function 'grpci2_of_probe':
arch/sparc/kernel/leon_pci_grpci2.c:720:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
arch/sparc/kernel/leon_pci_grpci2.c:720:20: error: assignment makes pointer from integer without a cast [-Werror]
arch/sparc/kernel/leon_pci_grpci2.c:882:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
cc1: all warnings being treated as errors
make[2]: *** [arch/sparc/kernel/leon_pci_grpci2.o] Error 1
According to Stephen, these types of failures are caused by
commit 2bd59d48ebfb ("cgroup: convert to kernfs") which was
being included implicitly via cgroup.h's inclusion of xattr.h
(which has now been removed).
Cc: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Tejun Heo <tj@kernel•org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com>
---
arch/sparc/kernel/leon_pci_grpci2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/sparc/kernel/leon_pci_grpci2.c b/arch/sparc/kernel/leon_pci_grpci2.c
index 5f0402aab7fb..24d6a4446349 100644
--- a/arch/sparc/kernel/leon_pci_grpci2.c
+++ b/arch/sparc/kernel/leon_pci_grpci2.c
@@ -8,6 +8,7 @@
#include <linux/of_device.h>
#include <linux/kernel.h>
#include <linux/pci.h>
+#include <linux/slab.h>
#include <linux/delay.h>
#include <linux/export.h>
#include <asm/io.h>
--
1.8.5.2
next reply other threads:[~2014-02-13 16:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 15:59 Paul Gortmaker [this message]
2014-02-13 20:42 ` [PATCH] sparc: fix implicit include of slab.h in leon_pci_grpci2.c Tejun Heo
2014-02-13 21:01 ` David Miller
2014-02-13 21:18 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392307158-6932-1-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=tj@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox