From: Tejun Heo <tj@kernel•org>
To: Paul Gortmaker <paul.gortmaker@windriver•com>
Cc: sparclinux@vger•kernel.org,
"David S. Miller" <davem@davemloft•net>,
linux-kernel@vger•kernel.org, linux-next@vger•kernel.org,
Stephen Rothwell <sfr@canb•auug.org.au>
Subject: Re: [PATCH] sparc: fix implicit include of slab.h in leon_pci_grpci2.c
Date: Thu, 13 Feb 2014 15:42:17 -0500 [thread overview]
Message-ID: <20140213204217.GD17608@htj.dyndns.org> (raw)
In-Reply-To: <1392307158-6932-1-git-send-email-paul.gortmaker@windriver.com>
On Thu, Feb 13, 2014 at 10:59:18AM -0500, Paul Gortmaker wrote:
> To fix:
>
> arch/sparc/kernel/leon_pci_grpci2.c: In function 'grpci2_of_probe':
> arch/sparc/kernel/leon_pci_grpci2.c:720:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
> arch/sparc/kernel/leon_pci_grpci2.c:720:20: error: assignment makes pointer from integer without a cast [-Werror]
> arch/sparc/kernel/leon_pci_grpci2.c:882:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
> cc1: all warnings being treated as errors
> make[2]: *** [arch/sparc/kernel/leon_pci_grpci2.o] Error 1
>
> According to Stephen, these types of failures are caused by
> commit 2bd59d48ebfb ("cgroup: convert to kernfs") which was
> being included implicitly via cgroup.h's inclusion of xattr.h
> (which has now been removed).
>
> Cc: Stephen Rothwell <sfr@canb•auug.org.au>
> Cc: Tejun Heo <tj@kernel•org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com>
Darn, another one. David, can you please ack this one? I'll push it
through cgroup/for-3.15 so that -next doesn't break.
Thanks.
--
tejun
next prev parent reply other threads:[~2014-02-13 20:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 15:59 [PATCH] sparc: fix implicit include of slab.h in leon_pci_grpci2.c Paul Gortmaker
2014-02-13 20:42 ` Tejun Heo [this message]
2014-02-13 21:01 ` David Miller
2014-02-13 21:18 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140213204217.GD17608@htj.dyndns.org \
--to=tj@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=paul.gortmaker@windriver$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=sparclinux@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox