public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: "Nicholas A. Bellinger" <nab@linux-iscsi•org>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
	target-devel <target-devel@vger•kernel.org>
Subject: Re: linux-next: build failure after merge of the target-updates tree
Date: Fri, 23 May 2014 10:38:37 -0700	[thread overview]
Message-ID: <1400866717.30565.3.camel@haakon3.risingtidesystems.com> (raw)
In-Reply-To: <20140523191159.6a064678@canb.auug.org.au>

Hi Stephen,

(Adding CC's for Paolo + MKP)

On Fri, 2014-05-23 at 19:11 +1000, Stephen Rothwell wrote:
> Hi Nicholas,
> 
> After merging the target-updates tree, today's linux-next build
> (powerpc ppc64_defconfig) failed like this:
> 
> 
> drivers/scsi/virtio_scsi.c: In function 'virtio_scsi_init_hdr_pi':
> drivers/scsi/virtio_scsi.c:491:48: error: dereferencing pointer to incomplete type
>    cmd_pi->pi_bytesout = blk_rq_sectors(rq) * bi->tuple_size;
>                                                 ^
> drivers/scsi/virtio_scsi.c:493:47: error: dereferencing pointer to incomplete type
>    cmd_pi->pi_bytesin = blk_rq_sectors(rq) * bi->tuple_size;
>                                                ^
> 
> Caused by commit 4baaa7d589e2 ("virtio-scsi: Enable DIF/DIX modes in
> SCSI host LLD").  A missing include of linux/blkdev.h.  See Rule 1 in
> Documentation/SubmitChecklist.
> 
> I have used the target-updates tree from next-20140522 for today.

Whoops, adding the missing #include <linux/blkdev.h> now..

Thanks!

--nab

  reply	other threads:[~2014-05-23 17:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-23  9:11 linux-next: build failure after merge of the target-updates tree Stephen Rothwell
2014-05-23 17:38 ` Nicholas A. Bellinger [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-10-07  3:49 Stephen Rothwell
2015-10-07 12:27 ` Alexander Shishkin
2015-10-07 20:22   ` Stephen Rothwell
2015-06-03  8:16 Stephen Rothwell
2015-06-03 20:00 ` James Bottomley
2015-06-03 22:12   ` Nicholas A. Bellinger
2015-06-03 22:33     ` James Bottomley
2015-06-03 22:46       ` Nicholas A. Bellinger
2015-05-12  4:54 Stephen Rothwell
2014-10-03  5:46 Stephen Rothwell
2014-10-03  8:10 ` Nicholas A. Bellinger
2014-01-20  5:25 Stephen Rothwell
2012-09-17  3:41 Stephen Rothwell
2012-09-18  0:57 ` Nicholas A. Bellinger
2012-02-10  0:50 Stephen Rothwell
2012-02-10  1:33 ` Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400866717.30565.3.camel@haakon3.risingtidesystems.com \
    --to=nab@linux-iscsi$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=sfr@canb$(echo .)auug.org.au \
    --cc=target-devel@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox