public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux•intel.com>
To: Randy Dunlap <rdunlap@infradead•org>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
	 Linux Next Mailing List <linux-next@vger•kernel.org>,
	 Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
	 platform-driver-x86@vger•kernel.org,
	 "Derek J. Clark" <derekjohn.clark@gmail•com>
Subject: Re: linux-next: Tree for Jul 11 (drivers/platform/x86/lenovo/wmi-gamezone.o)
Date: Sun, 13 Jul 2025 19:06:48 +0300 (EEST)	[thread overview]
Message-ID: <183b1932-b65d-c3e2-deb2-850e0887e8d6@linux.intel.com> (raw)
In-Reply-To: <a1745a9b-d0a6-4c72-9096-6f9d15274b9a@infradead.org>

On Fri, 11 Jul 2025, Randy Dunlap wrote:
> On 7/11/25 2:10 AM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20250710:
> > 
> 
> on i386, when
> CONFIG_LENOVO_WMI_EVENTS=y
> CONFIG_LENOVO_WMI_HELPERS=y
> CONFIG_LENOVO_WMI_GAMEZONE=y
> # CONFIG_LENOVO_WMI_TUNING is not set
> 
> ld: drivers/platform/x86/lenovo/wmi-gamezone.o: in function `lwmi_gz_probe':
> wmi-gamezone.c:(.text+0x63c): undefined reference to `devm_lwmi_om_register_notifier'
> 
> Adding
> +	select LENOVO_WMI_TUNING
> for config LENOVO_WMI_GAMEZONE fixes the build error.
> Is that the right fix?
> If so, please go ahead with it.

AFAIK, this is already fixed by the commit 6e38b9fcbfa3 ("platform/x86: 
lenovo: gamezone needs "other mode"") which does what you described above.

-- 
 i.


  reply	other threads:[~2025-07-13 16:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-11  9:10 linux-next: Tree for Jul 11 Stephen Rothwell
2025-07-11 21:25 ` linux-next: Tree for Jul 11 [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] Randy Dunlap
2025-07-12  8:11   ` Rafael J. Wysocki
2025-07-12 19:02     ` Mario Limonciello
2025-07-13 11:34       ` Rafael J. Wysocki
2025-07-11 22:12 ` linux-next: Tree for Jul 11 (drivers/platform/x86/lenovo/wmi-gamezone.o) Randy Dunlap
2025-07-13 16:06   ` Ilpo Järvinen [this message]
2025-07-13  6:49 ` linux-next: Tree for Jul 11 (drivers/gpu/drm/msm/msm_gem.c) Randy Dunlap
2025-07-13 13:16   ` Rob Clark
2025-07-13 17:47     ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=183b1932-b65d-c3e2-deb2-850e0887e8d6@linux.intel.com \
    --to=ilpo.jarvinen@linux$(echo .)intel.com \
    --cc=derekjohn.clark@gmail$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=platform-driver-x86@vger$(echo .)kernel.org \
    --cc=rdunlap@infradead$(echo .)org \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox