From: Mario Limonciello <superm1@kernel•org>
To: "Rafael J. Wysocki" <rafael@kernel•org>,
Randy Dunlap <rdunlap@infradead•org>,
Mario Limonciello <mario.limonciello@amd•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux DRI Development <dri-devel@lists•freedesktop.org>,
Samuel Zhang <guoqing.zhang@amd•com>,
amd-gfx@lists•freedesktop.org
Subject: Re: linux-next: Tree for Jul 11 [drivers/gpu/drm/amd/amdgpu/amdgpu.ko]
Date: Sat, 12 Jul 2025 14:02:38 -0500 [thread overview]
Message-ID: <35f0dd7e-f4c1-4042-bc85-19d277f4b1f9@kernel.org> (raw)
In-Reply-To: <CAJZ5v0h1CX+aTu7dFy6vB-9LM6t5J4rt7Su3qVnq1xx-BFAm=Q@mail.gmail.com>
On 7/12/25 3:11 AM, Rafael J. Wysocki wrote:
> On Fri, Jul 11, 2025 at 11:25 PM Randy Dunlap <rdunlap@infradead•org> wrote:
>>
>>
>>
>> On 7/11/25 2:10 AM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20250710:
>>>
>>
>> on x86_64, when
>> # CONFIG_SUSPEND is not set
>> # CONFIG_HIBERNATION is not set
>> # CONFIG_PM is not set
>>
>> ERROR: modpost: "pm_hibernate_is_recovering" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
>>
>> caused by commit
>> 530694f54dd5e ("drm/amdgpu: do not resume device in thaw for normal hibernation")
>>
>> Rafael, is a stub appropriate for this case?
>
> pm_hibernate_is_recovering() is not supposed to be called by code that
> does not depend on CONFIG_HIBERNATE_CALLBACKS, but a stub returning
> false would work for this.
Thanks, I just sent out a fix for this.
>
> Mario, it would be good to fix this up in your tree. Also, it would
> be good to expose stuff to 0-day build testing before letting it go
> into linux-next. I use the bleeding-edge branch for this purpose.
>
Honestly; I'm surprised that 0-day didn't raise this on either dri-devel
or amd-gfx. I had expected at least one of those lists to raise this
over the last week of patches.
Anyone know the history why neither has 0-day?
next prev parent reply other threads:[~2025-07-12 19:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 9:10 linux-next: Tree for Jul 11 Stephen Rothwell
2025-07-11 21:25 ` linux-next: Tree for Jul 11 [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] Randy Dunlap
2025-07-12 8:11 ` Rafael J. Wysocki
2025-07-12 19:02 ` Mario Limonciello [this message]
2025-07-13 11:34 ` Rafael J. Wysocki
2025-07-11 22:12 ` linux-next: Tree for Jul 11 (drivers/platform/x86/lenovo/wmi-gamezone.o) Randy Dunlap
2025-07-13 16:06 ` Ilpo Järvinen
2025-07-13 6:49 ` linux-next: Tree for Jul 11 (drivers/gpu/drm/msm/msm_gem.c) Randy Dunlap
2025-07-13 13:16 ` Rob Clark
2025-07-13 17:47 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35f0dd7e-f4c1-4042-bc85-19d277f4b1f9@kernel.org \
--to=superm1@kernel$(echo .)org \
--cc=amd-gfx@lists$(echo .)freedesktop.org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=guoqing.zhang@amd$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mario.limonciello@amd$(echo .)com \
--cc=rafael@kernel$(echo .)org \
--cc=rdunlap@infradead$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox