public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Russell King <rmk@arm•linux.org.uk>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Sam Ravnborg <sam@ravnborg•org>,
	Haavard Skinnemoen <hskinnemoen@atmel•com>,
	Paul Mundt <lethal@linux-sh•org>,
	linux-next@vger•kernel.org
Subject: Re: linux-next build poblems
Date: Mon, 23 Jun 2008 18:10:23 +0100	[thread overview]
Message-ID: <20080623171023.GA16238@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20080624022232.5c81519c.sfr@canb.auug.org.au>

On Tue, Jun 24, 2008 at 02:22:32AM +1000, Stephen Rothwell wrote:
> Hi Sam,
> 
> I haven't had a good look, but something has gone badly wrong with the
> arm, avr32 and sh builds of linux-next today.  Have a look at
> http://kisskb.ellerman.id.au/linux-next.

Looks like samr's to blame.

Before:
/path/to/build/directory/include:
lrwxrwxrwx   1 rmk rmk    7 Nov 27  2007 asm -> asm-arm
drwxrwxr-x   2 rmk rmk 4096 Jun  2 19:40 asm-arm
drwxr-xr-x 194 rmk rmk 8192 Jun  2 19:43 config
drwxrwxr-x   2 rmk rmk 4096 Jun  2 19:43 linux

After:
/path/to/build/directory/include:
drwxrwxr-x   2 rmk rmk 4096 Jun 23 17:59 asm-arm
drwxrwxr-x 107 rmk rmk 4096 Jun 23 18:00 config
drwxrwxr-x   2 rmk rmk 4096 Jun 23 18:00 linux

and inside /path/to/build/directory/include/asm-arm:
lrwxrwxrwx 1 rmk rmk     59 Jun 23 17:59 arch -> /home/rmk/git/linux-2.6-test/include/asm-arm/arch-versatile
-rw-rw-r-- 1 rmk rmk 603835 Jun 23 17:59 mach-types.h

Note the symlink inside include/asm-arm, and the lack of asm -> asm-arm
symlink.  This means that <asm/arch/foo.h> won't be found.

Running make with V=1 results in (reformatted for readability):

set -e; asmlink=`readlink include/asm | cut -d '-' -f 2`; 
if [ -L include/asm ]; then
   if [ "$asmlink" != "arm" ]; then
      echo "ERROR: the symlink include/asm points to asm-$asmlink but asm-arm was expected";
      echo "       set ARCH or save .config and run 'make mrproper' to fix it";
      exit 1;
   fi;
fi
if [ -L include/asm ]; then
   rm include/asm;
fi

Notice that it removes the include/asm symlink and never restores it.

Looks to me like the cause is 2c4cd2923a69b89526adc4869626d139f24ea3a7.

Sam?

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

  parent reply	other threads:[~2008-06-23 17:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-23 16:22 linux-next build poblems Stephen Rothwell
2008-06-23 17:08 ` Sam Ravnborg
2008-06-23 23:29   ` Stephen Rothwell
2008-06-23 17:10 ` Russell King [this message]
2008-06-23 20:07   ` Sam Ravnborg
2008-06-23 20:21     ` Sam Ravnborg
2008-06-23 20:32       ` Russell King
2008-06-23 20:51         ` Sam Ravnborg
2008-06-23 21:01           ` Sam Ravnborg
2008-06-24 13:29       ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080623171023.GA16238@flint.arm.linux.org.uk \
    --to=rmk@arm$(echo .)linux.org.uk \
    --cc=hskinnemoen@atmel$(echo .)com \
    --cc=lethal@linux-sh$(echo .)org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=sam@ravnborg$(echo .)org \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox