* linux-next build poblems
@ 2008-06-23 16:22 Stephen Rothwell
2008-06-23 17:08 ` Sam Ravnborg
2008-06-23 17:10 ` Russell King
0 siblings, 2 replies; 10+ messages in thread
From: Stephen Rothwell @ 2008-06-23 16:22 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Haavard Skinnemoen, Russell King, Paul Mundt, linux-next
[-- Attachment #1: Type: text/plain, Size: 297 bytes --]
Hi Sam,
I haven't had a good look, but something has gone badly wrong with the
arm, avr32 and sh builds of linux-next today. Have a look at
http://kisskb.ellerman.id.au/linux-next.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next build poblems
2008-06-23 16:22 linux-next build poblems Stephen Rothwell
@ 2008-06-23 17:08 ` Sam Ravnborg
2008-06-23 23:29 ` Stephen Rothwell
2008-06-23 17:10 ` Russell King
1 sibling, 1 reply; 10+ messages in thread
From: Sam Ravnborg @ 2008-06-23 17:08 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Haavard Skinnemoen, Russell King, Paul Mundt, linux-next
On Tue, Jun 24, 2008 at 02:22:32AM +1000, Stephen Rothwell wrote:
> Hi Sam,
>
> I haven't had a good look, but something has gone badly wrong with the
> arm, avr32 and sh builds of linux-next today. Have a look at
> http://kisskb.ellerman.id.au/linux-next.
Looked at sh and this is obviously a kbuild-next.git problem.
I will try to look at it tonight - as in a few hours from now.
If you are in a hurry drop kbuild-next.git.
I have changed a few things around the symlink handling
and this was only tested with sparc and x86 (32 bit) as this
is the cross toolchains I have available on this box.
It is just perfect that -next find this before the merge window!
Sam
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next build poblems
2008-06-23 17:08 ` Sam Ravnborg
@ 2008-06-23 23:29 ` Stephen Rothwell
0 siblings, 0 replies; 10+ messages in thread
From: Stephen Rothwell @ 2008-06-23 23:29 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Haavard Skinnemoen, Russell King, Paul Mundt, linux-next
[-- Attachment #1: Type: text/plain, Size: 674 bytes --]
Hi Sam,
On Mon, 23 Jun 2008 19:08:01 +0200 Sam Ravnborg <sam@ravnborg•org> wrote:
>
> I will try to look at it tonight - as in a few hours from now.
> If you are in a hurry drop kbuild-next.git.
OK, thanks - obviously no hurry at the point you wrote this :-)
> I have changed a few things around the symlink handling
> and this was only tested with sparc and x86 (32 bit) as this
> is the cross toolchains I have available on this box.
>
> It is just perfect that -next find this before the merge window!
That is one of the reasons I am here :-)
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next build poblems
2008-06-23 16:22 linux-next build poblems Stephen Rothwell
2008-06-23 17:08 ` Sam Ravnborg
@ 2008-06-23 17:10 ` Russell King
2008-06-23 20:07 ` Sam Ravnborg
1 sibling, 1 reply; 10+ messages in thread
From: Russell King @ 2008-06-23 17:10 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Sam Ravnborg, Haavard Skinnemoen, Paul Mundt, linux-next
On Tue, Jun 24, 2008 at 02:22:32AM +1000, Stephen Rothwell wrote:
> Hi Sam,
>
> I haven't had a good look, but something has gone badly wrong with the
> arm, avr32 and sh builds of linux-next today. Have a look at
> http://kisskb.ellerman.id.au/linux-next.
Looks like samr's to blame.
Before:
/path/to/build/directory/include:
lrwxrwxrwx 1 rmk rmk 7 Nov 27 2007 asm -> asm-arm
drwxrwxr-x 2 rmk rmk 4096 Jun 2 19:40 asm-arm
drwxr-xr-x 194 rmk rmk 8192 Jun 2 19:43 config
drwxrwxr-x 2 rmk rmk 4096 Jun 2 19:43 linux
After:
/path/to/build/directory/include:
drwxrwxr-x 2 rmk rmk 4096 Jun 23 17:59 asm-arm
drwxrwxr-x 107 rmk rmk 4096 Jun 23 18:00 config
drwxrwxr-x 2 rmk rmk 4096 Jun 23 18:00 linux
and inside /path/to/build/directory/include/asm-arm:
lrwxrwxrwx 1 rmk rmk 59 Jun 23 17:59 arch -> /home/rmk/git/linux-2.6-test/include/asm-arm/arch-versatile
-rw-rw-r-- 1 rmk rmk 603835 Jun 23 17:59 mach-types.h
Note the symlink inside include/asm-arm, and the lack of asm -> asm-arm
symlink. This means that <asm/arch/foo.h> won't be found.
Running make with V=1 results in (reformatted for readability):
set -e; asmlink=`readlink include/asm | cut -d '-' -f 2`;
if [ -L include/asm ]; then
if [ "$asmlink" != "arm" ]; then
echo "ERROR: the symlink include/asm points to asm-$asmlink but asm-arm was expected";
echo " set ARCH or save .config and run 'make mrproper' to fix it";
exit 1;
fi;
fi
if [ -L include/asm ]; then
rm include/asm;
fi
Notice that it removes the include/asm symlink and never restores it.
Looks to me like the cause is 2c4cd2923a69b89526adc4869626d139f24ea3a7.
Sam?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: linux-next build poblems
2008-06-23 17:10 ` Russell King
@ 2008-06-23 20:07 ` Sam Ravnborg
2008-06-23 20:21 ` Sam Ravnborg
0 siblings, 1 reply; 10+ messages in thread
From: Sam Ravnborg @ 2008-06-23 20:07 UTC (permalink / raw)
To: Russell King; +Cc: Stephen Rothwell, Haavard Skinnemoen, Paul Mundt, linux-next
On Mon, Jun 23, 2008 at 06:10:23PM +0100, Russell King wrote:
> On Tue, Jun 24, 2008 at 02:22:32AM +1000, Stephen Rothwell wrote:
> > Hi Sam,
> >
> > I haven't had a good look, but something has gone badly wrong with the
> > arm, avr32 and sh builds of linux-next today. Have a look at
> > http://kisskb.ellerman.id.au/linux-next.
>
> Looks like samr's to blame.
Yes.
>
> Before:
> /path/to/build/directory/include:
> lrwxrwxrwx 1 rmk rmk 7 Nov 27 2007 asm -> asm-arm
> drwxrwxr-x 2 rmk rmk 4096 Jun 2 19:40 asm-arm
> drwxr-xr-x 194 rmk rmk 8192 Jun 2 19:43 config
> drwxrwxr-x 2 rmk rmk 4096 Jun 2 19:43 linux
>
> After:
> /path/to/build/directory/include:
> drwxrwxr-x 2 rmk rmk 4096 Jun 23 17:59 asm-arm
> drwxrwxr-x 107 rmk rmk 4096 Jun 23 18:00 config
> drwxrwxr-x 2 rmk rmk 4096 Jun 23 18:00 linux
>
> and inside /path/to/build/directory/include/asm-arm:
> lrwxrwxrwx 1 rmk rmk 59 Jun 23 17:59 arch -> /home/rmk/git/linux-2.6-test/include/asm-arm/arch-versatile
> -rw-rw-r-- 1 rmk rmk 603835 Jun 23 17:59 mach-types.h
>
> Note the symlink inside include/asm-arm, and the lack of asm -> asm-arm
> symlink. This means that <asm/arch/foo.h> won't be found.
arm/Makefile create the directory asm-arm and use it for the symlink.
But now asm is no longer a symlink to asm-arm so we fail.
I need to work out something.
But my first attemps failed miserably and I will stop for now
as I have some day-time job stuff to be done.
Travelling for a few days from now one so I cannot do anything
until the weekend.
Either we should pull the offending commit from -next or drop
kbuild-next.git.
As a sidenote I expect arm to benefit of the offending patch as we
could kill the symlinks when the header files were rearranged.
But that does not help us here.
As for sh and avr they both play symlinks games too - so same story there.
Sam
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next build poblems
2008-06-23 20:07 ` Sam Ravnborg
@ 2008-06-23 20:21 ` Sam Ravnborg
2008-06-23 20:32 ` Russell King
2008-06-24 13:29 ` Stephen Rothwell
0 siblings, 2 replies; 10+ messages in thread
From: Sam Ravnborg @ 2008-06-23 20:21 UTC (permalink / raw)
To: Russell King; +Cc: Stephen Rothwell, Haavard Skinnemoen, Paul Mundt, linux-next
>
> I need to work out something.
> But my first attemps failed miserably and I will stop for now
> as I have some day-time job stuff to be done.
> Travelling for a few days from now one so I cannot do anything
> until the weekend.
I came up with the following fix.
And I fixed an arm tool chain for my box so I could check it.
We can now build an arm kernel (or at least the first steps).
I have pushed it out to kbuild-next.git.
And I will redo the patch series later so we do not bisect break arm etc.
Sam
diff --git a/Makefile b/Makefile
index 2628295..4761b3b 100644
--- a/Makefile
+++ b/Makefile
@@ -328,7 +328,8 @@ AFLAGS_KERNEL =
# Use LINUXINCLUDE when you must reference the include/ directory.
# Needed to be compatible with the O= option
LINUXINCLUDE := -Iinclude \
- $(if $(KBUILD_SRC),-Iinclude2 -I$(srctree)/include) \
+ $(if $(KBUILD_SRC), \
+ -Iinclude2 -Iinclude3 -I$(srctree)/include) \
-I$(srctree)/arch/$(hdr-arch)/include \
-include include/linux/autoconf.h
@@ -913,6 +914,7 @@ PHONY += prepare archprepare prepare0 prepare1 prepare2 prepare3
# and if so do:
# 1) Check that make has not been executed in the kernel src $(srctree)
# 2) Create the include2 directory, used for the second asm symlink
+# 3) Create the include3 directory, used for the third asm symlink
prepare3: include/config/kernel.release
ifneq ($(KBUILD_SRC),)
@echo ' Using $(srctree) as source for kernel'
@@ -925,6 +927,10 @@ ifneq ($(KBUILD_SRC),)
$(Q)if [ -e $(srctree)/include/asm-$(SRCARCH)/system.h ]; then \
ln -fsn $(srctree)/include/asm-$(SRCARCH) include2/asm; \
fi
+ $(Q)if [ ! -d include3 ]; then mkdir -p include3; fi;
+ $(Q)if [ -e $(srctree)/include/asm-$(SRCARCH)/system.h ]; then \
+ ln -fsn ../include/asm-$(SRCARCH) include3/asm; \
+ fi
endif
# prepare2 creates a makefile if using a separate output directory
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: linux-next build poblems
2008-06-23 20:21 ` Sam Ravnborg
@ 2008-06-23 20:32 ` Russell King
2008-06-23 20:51 ` Sam Ravnborg
2008-06-24 13:29 ` Stephen Rothwell
1 sibling, 1 reply; 10+ messages in thread
From: Russell King @ 2008-06-23 20:32 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Stephen Rothwell, Haavard Skinnemoen, Paul Mundt, linux-next
On Mon, Jun 23, 2008 at 10:21:56PM +0200, Sam Ravnborg wrote:
> >
> > I need to work out something.
> > But my first attemps failed miserably and I will stop for now
> > as I have some day-time job stuff to be done.
> > Travelling for a few days from now one so I cannot do anything
> > until the weekend.
> I came up with the following fix.
> And I fixed an arm tool chain for my box so I could check it.
>
> We can now build an arm kernel (or at least the first steps).
>
> I have pushed it out to kbuild-next.git.
> And I will redo the patch series later so we do not bisect break arm etc.
Silly question, but what's wrong with restoring the symlink in the
build include/ directory?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next build poblems
2008-06-23 20:32 ` Russell King
@ 2008-06-23 20:51 ` Sam Ravnborg
2008-06-23 21:01 ` Sam Ravnborg
0 siblings, 1 reply; 10+ messages in thread
From: Sam Ravnborg @ 2008-06-23 20:51 UTC (permalink / raw)
To: Russell King; +Cc: Stephen Rothwell, Haavard Skinnemoen, Paul Mundt, linux-next
On Mon, Jun 23, 2008 at 09:32:49PM +0100, Russell King wrote:
> On Mon, Jun 23, 2008 at 10:21:56PM +0200, Sam Ravnborg wrote:
> > >
> > > I need to work out something.
> > > But my first attemps failed miserably and I will stop for now
> > > as I have some day-time job stuff to be done.
> > > Travelling for a few days from now one so I cannot do anything
> > > until the weekend.
> > I came up with the following fix.
> > And I fixed an arm tool chain for my box so I could check it.
> >
> > We can now build an arm kernel (or at least the first steps).
> >
> > I have pushed it out to kbuild-next.git.
> > And I will redo the patch series later so we do not bisect break arm etc.
>
> Silly question, but what's wrong with restoring the symlink in the
> build include/ directory?
The asm-offsets.h file should always be generated in the same directory.
And that is include/asm-$ARCH today.
But if we move include/asm-$ARCH to arch/$ARCH/include then that directory
no longer exists.
And I wanted to avoid adding generated files to arch/$ARCH/include
so the obvious choice was to generate the asm-offsets.h file in
include/asm which works in make O=... and 'normal' builds.
And because I were facing problams when asm was a symlink I
went for the solution with asm being a directory.
But then arm creates asm-arm as a directory too.
So I can try to see of I can make asm a symlink again
to asm-$ARCH. Adding a include3 directory is not my preferred
solution.
Sam
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next build poblems
2008-06-23 20:51 ` Sam Ravnborg
@ 2008-06-23 21:01 ` Sam Ravnborg
0 siblings, 0 replies; 10+ messages in thread
From: Sam Ravnborg @ 2008-06-23 21:01 UTC (permalink / raw)
To: Russell King; +Cc: Stephen Rothwell, Haavard Skinnemoen, Paul Mundt, linux-next
On Mon, Jun 23, 2008 at 10:51:33PM +0200, Sam Ravnborg wrote:
> On Mon, Jun 23, 2008 at 09:32:49PM +0100, Russell King wrote:
> > On Mon, Jun 23, 2008 at 10:21:56PM +0200, Sam Ravnborg wrote:
> > > >
> > > > I need to work out something.
> > > > But my first attemps failed miserably and I will stop for now
> > > > as I have some day-time job stuff to be done.
> > > > Travelling for a few days from now one so I cannot do anything
> > > > until the weekend.
> > > I came up with the following fix.
> > > And I fixed an arm tool chain for my box so I could check it.
> > >
> > > We can now build an arm kernel (or at least the first steps).
> > >
> > > I have pushed it out to kbuild-next.git.
> > > And I will redo the patch series later so we do not bisect break arm etc.
> >
> > Silly question, but what's wrong with restoring the symlink in the
> > build include/ directory?
> The asm-offsets.h file should always be generated in the same directory.
> And that is include/asm-$ARCH today.
>
> But if we move include/asm-$ARCH to arch/$ARCH/include then that directory
> no longer exists.
> And I wanted to avoid adding generated files to arch/$ARCH/include
> so the obvious choice was to generate the asm-offsets.h file in
> include/asm which works in make O=... and 'normal' builds.
>
> And because I were facing problams when asm was a symlink I
> went for the solution with asm being a directory.
> But then arm creates asm-arm as a directory too.
>
> So I can try to see of I can make asm a symlink again
> to asm-$ARCH. Adding a include3 directory is not my preferred
> solution.
OK - I tried to do what you hinted and it seems to work.
Too late to push out something and I need to test more.
But seems to simplify things - which is good.
Now I wonder why I did not do so before - maybe to avoid the
symlink.
Sam
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next build poblems
2008-06-23 20:21 ` Sam Ravnborg
2008-06-23 20:32 ` Russell King
@ 2008-06-24 13:29 ` Stephen Rothwell
1 sibling, 0 replies; 10+ messages in thread
From: Stephen Rothwell @ 2008-06-24 13:29 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Russell King, Haavard Skinnemoen, Paul Mundt, linux-next
[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]
Hi Sam,
On Mon, 23 Jun 2008 22:21:56 +0200 Sam Ravnborg <sam@ravnborg•org> wrote:
>
> >
> > I need to work out something.
> > But my first attemps failed miserably and I will stop for now
> > as I have some day-time job stuff to be done.
> > Travelling for a few days from now one so I cannot do anything
> > until the weekend.
> I came up with the following fix.
> And I fixed an arm tool chain for my box so I could check it.
>
> We can now build an arm kernel (or at least the first steps).
>
> I have pushed it out to kbuild-next.git.
> And I will redo the patch series later so we do not bisect break arm etc.
Nearly, but not quite: versatile_defconfig build for arm with today's
linux-next fails with:
make[3]: *** No rule to make target `include/asm/arch/uncompress.h', needed by `arch/arm/boot/compressed/misc.o'. Stop.
It does get much further, though.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2008-06-24 13:30 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-23 16:22 linux-next build poblems Stephen Rothwell
2008-06-23 17:08 ` Sam Ravnborg
2008-06-23 23:29 ` Stephen Rothwell
2008-06-23 17:10 ` Russell King
2008-06-23 20:07 ` Sam Ravnborg
2008-06-23 20:21 ` Sam Ravnborg
2008-06-23 20:32 ` Russell King
2008-06-23 20:51 ` Sam Ravnborg
2008-06-23 21:01 ` Sam Ravnborg
2008-06-24 13:29 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox