From: "Rafael J. Wysocki" <rjw@sisk•pl>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Jesse Barnes <jbarnes@virtuousgeek•org>,
linux-next@vger•kernel.org, Jeremy Fitzhardinge <jeremy@goop•org>,
Thomas Gleixner <tglx@linutronix•de>, Ingo Molnar <mingo@elte•hu>,
"H. Peter Anvin" <hpa@zytor•com>
Subject: Re: linux-next: pci tree build failure
Date: Fri, 18 Jul 2008 00:57:06 +0200 [thread overview]
Message-ID: <200807180057.07192.rjw@sisk.pl> (raw)
In-Reply-To: <20080717130924.edd5a501.sfr@canb.auug.org.au>
On Thursday, 17 of July 2008, Stephen Rothwell wrote:
> Hi Jesse,
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> drivers/xen/manage.c: In function 'xen_suspend':
> drivers/xen/manage.c:66: error: too few arguments to function 'device_power_up'
> drivers/xen/manage.c: In function 'do_suspend':
> drivers/xen/manage.c:117: error: too few arguments to function 'device_resume'
>
> Caused by commit 1eede070a59e1cc73da51e1aaa00d9ab86572cfc ("Introduce new
> top level suspend and hibernation callbacks") interacting with new
> usages ...
>
> I applied the patch below (which could be incorrect).
The patch is correct.
Thanks,
Rafael
> The above commit is now in Linus' tree, so this needs to be fixed in the
> merge of the x86(?) tree.
>
> --
> Cheers,
> Stephen Rothwell sfr@canb•auug.org.au
> http://www.canb.auug.org.au/~sfr/
>
> From aa015dc0cceb8478a89421c4015e81f78a9cf106 Mon Sep 17 00:00:00 2001
> From: Stephen Rothwell <sfr@canb•auug.org.au>
> Date: Thu, 17 Jul 2008 13:01:15 +1000
> Subject: [PATCH] pci: fix xen fallout from PM API change
>
> Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
> ---
> drivers/xen/manage.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
> index 2bb268e..a5bc91a 100644
> --- a/drivers/xen/manage.c
> +++ b/drivers/xen/manage.c
> @@ -63,7 +63,7 @@ static int xen_suspend(void *data)
> gnttab_resume();
> xen_mm_unpin_all();
>
> - device_power_up();
> + device_power_up(PMSG_RESUME);
>
> if (!*cancelled) {
> xen_irq_resume();
> @@ -114,7 +114,7 @@ static void do_suspend(void)
> } else
> xenbus_suspend_cancel();
>
> - device_resume();
> + device_resume(PMSG_RESUME);
>
> /* Make sure timer events get retriggered on all CPUs */
> clock_was_set();
next parent reply other threads:[~2008-07-17 22:55 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080717130924.edd5a501.sfr@canb.auug.org.au>
2008-07-17 22:57 ` Rafael J. Wysocki [this message]
2008-07-18 6:09 ` linux-next: pci tree build failure Stephen Rothwell
2008-07-18 7:53 ` Ingo Molnar
2010-01-27 6:49 Stephen Rothwell
2010-01-27 17:31 ` Jesse Barnes
2010-01-28 6:14 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2010-01-18 8:40 Stephen Rothwell
2010-01-18 21:24 ` Rafael J. Wysocki
2010-01-19 2:35 ` Jesse Barnes
2010-01-19 3:19 ` Stephen Rothwell
2010-01-20 4:39 ` Jesse Barnes
2010-01-20 5:19 ` Stephen Rothwell
2010-01-04 22:55 Stephen Rothwell
2010-01-04 23:10 ` Matthew Wilcox
2010-01-04 23:48 ` Jesse Barnes
2010-01-05 3:41 ` Stephen Rothwell
2009-10-07 1:38 Stephen Rothwell
2009-10-07 1:45 ` Tejun Heo
2009-10-07 15:39 ` Jesse Barnes
2009-07-15 1:45 Stephen Rothwell
2009-07-15 16:09 ` Jesse Barnes
2009-07-15 23:46 ` Stephen Rothwell
2009-06-30 2:07 Stephen Rothwell
2009-06-30 2:13 ` Jesse Barnes
2009-06-30 2:24 ` Matthew Wilcox
2009-06-30 20:31 ` Jesse Barnes
2009-03-23 1:49 Stephen Rothwell
2009-03-25 1:21 ` Stephen Rothwell
2009-03-25 1:38 ` Jesse Barnes
2009-03-25 3:41 ` Stephen Rothwell
2009-03-25 4:30 ` Matthew Wilcox
2009-03-25 15:55 ` Jesse Barnes
2009-03-26 3:05 ` Stephen Rothwell
2009-03-26 3:37 ` Jesse Barnes
2009-03-26 4:54 ` Stephen Rothwell
2008-10-22 2:39 Stephen Rothwell
2008-10-22 3:47 ` Jesse Barnes
2008-10-16 3:41 Stephen Rothwell
2008-10-16 3:44 ` Benjamin Herrenschmidt
2008-10-16 4:23 ` Jesse Barnes
2008-10-16 4:28 ` Benjamin Herrenschmidt
2008-10-18 22:41 ` Jesse Barnes
2008-10-19 4:15 ` Stephen Rothwell
2008-10-19 4:30 ` Jesse Barnes
2008-07-08 1:40 Stephen Rothwell
2008-07-08 14:54 ` Rafael J. Wysocki
[not found] <20080630142314.34654d3c.sfr@canb.auug.org.au>
2008-06-30 14:11 ` Alan Stern
2008-07-02 2:11 ` Jesse Barnes
2008-06-30 5:11 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807180057.07192.rjw@sisk.pl \
--to=rjw@sisk$(echo .)pl \
--cc=hpa@zytor$(echo .)com \
--cc=jbarnes@virtuousgeek$(echo .)org \
--cc=jeremy@goop$(echo .)org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mingo@elte$(echo .)hu \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox