From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Jesse Barnes <jbarnes@virtuousgeek•org>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
"Rafael J. Wysocki" <rjw@sisk•pl>,
Shaohua Li <shaohua.li@intel•com>
Subject: linux-next: pci tree build failure
Date: Mon, 18 Jan 2010 19:40:50 +1100 [thread overview]
Message-ID: <20100118194050.7ea0c406.sfr@canb.auug.org.au> (raw)
Hi Jesse,
Today's linux-next build (ppc64 allyesconfig) failed like this:
In file included from drivers/pci/pcie/pme/pcie_pme.c:22:
include/linux/pci-acpi.h:42: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'acpi_find_root_bridge_handle'
This file was added in commit f3adb5a4f2e1dfdf9482af05481d0928a39477e8
("PCI PM: PCIe PME root port service driver") from the pci tree and seems
to depend on ACPI. Maybe its building should depend on CONFIG_ACPI?
I added the following patch for today (I presume there is a better fix):
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Mon, 18 Jan 2010 19:36:11 +1100
Subject: [PATCH] pci: PCIE_PME seems to depend on ACPI
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
drivers/pci/pcie/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
index cf3c35f..b8b494b 100644
--- a/drivers/pci/pcie/Kconfig
+++ b/drivers/pci/pcie/Kconfig
@@ -49,4 +49,4 @@ config PCIEASPM_DEBUG
config PCIE_PME
def_bool y
- depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL
+ depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL && ACPI
--
1.6.6
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
next reply other threads:[~2010-01-18 8:40 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 8:40 Stephen Rothwell [this message]
2010-01-18 21:24 ` linux-next: pci tree build failure Rafael J. Wysocki
2010-01-19 2:35 ` Jesse Barnes
2010-01-19 3:19 ` Stephen Rothwell
2010-01-20 4:39 ` Jesse Barnes
2010-01-20 5:19 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2010-01-27 6:49 Stephen Rothwell
2010-01-27 17:31 ` Jesse Barnes
2010-01-28 6:14 ` Stephen Rothwell
2010-01-04 22:55 Stephen Rothwell
2010-01-04 23:10 ` Matthew Wilcox
2010-01-04 23:48 ` Jesse Barnes
2010-01-05 3:41 ` Stephen Rothwell
2009-10-07 1:38 Stephen Rothwell
2009-10-07 1:45 ` Tejun Heo
2009-10-07 15:39 ` Jesse Barnes
2009-07-15 1:45 Stephen Rothwell
2009-07-15 16:09 ` Jesse Barnes
2009-07-15 23:46 ` Stephen Rothwell
2009-06-30 2:07 Stephen Rothwell
2009-06-30 2:13 ` Jesse Barnes
2009-06-30 2:24 ` Matthew Wilcox
2009-06-30 20:31 ` Jesse Barnes
2009-03-23 1:49 Stephen Rothwell
2009-03-25 1:21 ` Stephen Rothwell
2009-03-25 1:38 ` Jesse Barnes
2009-03-25 3:41 ` Stephen Rothwell
2009-03-25 4:30 ` Matthew Wilcox
2009-03-25 15:55 ` Jesse Barnes
2009-03-26 3:05 ` Stephen Rothwell
2009-03-26 3:37 ` Jesse Barnes
2009-03-26 4:54 ` Stephen Rothwell
2008-10-22 2:39 Stephen Rothwell
2008-10-22 3:47 ` Jesse Barnes
2008-10-16 3:41 Stephen Rothwell
2008-10-16 3:44 ` Benjamin Herrenschmidt
2008-10-16 4:23 ` Jesse Barnes
2008-10-16 4:28 ` Benjamin Herrenschmidt
2008-10-18 22:41 ` Jesse Barnes
2008-10-19 4:15 ` Stephen Rothwell
2008-10-19 4:30 ` Jesse Barnes
[not found] <20080717130924.edd5a501.sfr@canb.auug.org.au>
2008-07-17 22:57 ` Rafael J. Wysocki
2008-07-18 6:09 ` Stephen Rothwell
2008-07-18 7:53 ` Ingo Molnar
2008-07-08 1:40 Stephen Rothwell
2008-07-08 14:54 ` Rafael J. Wysocki
[not found] <20080630142314.34654d3c.sfr@canb.auug.org.au>
2008-06-30 14:11 ` Alan Stern
2008-07-02 2:11 ` Jesse Barnes
2008-06-30 5:11 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100118194050.7ea0c406.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=jbarnes@virtuousgeek$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rjw@sisk$(echo .)pl \
--cc=shaohua.li@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox