* linux-next: net-current tree build failure
@ 2008-07-21 0:58 Stephen Rothwell
2008-07-21 1:05 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2008-07-21 0:58 UTC (permalink / raw)
To: David Miller; +Cc: linux-next
[-- Attachment #1: Type: text/plain, Size: 2077 bytes --]
Hi Dave,
Today's linux-next build (powerpc ppc64_defconfig) failed like this:
net/built-in.o: In function `.dev_queue_xmit':
(.text+0x125a4): undefined reference to `.qdisc_calculate_pkt_len'
net/built-in.o: In function `.__qdisc_destroy':
sch_generic.c:(.text+0x28710): undefined reference to `.qdisc_put_stab'
This config has CONFIG_NET_SCHED not set.
I applied the patch below, but it is probably not the correct solution.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
>From 4534fc79b6efe71fbd478271238ce3122e07e010 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Mon, 21 Jul 2008 10:51:13 +1000
Subject: [PATCH] net: fix schedule breakage
The powerpc ppc64_defconfig build failed like this:
net/built-in.o: In function `.dev_queue_xmit':
(.text+0x125a4): undefined reference to `.qdisc_calculate_pkt_len'
net/built-in.o: In function `.__qdisc_destroy':
sch_generic.c:(.text+0x28710): undefined reference to `.qdisc_put_stab'
These changes make the kernel build.
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
net/sched/Makefile | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/sched/Makefile b/net/sched/Makefile
index 1d2b0f7..1b133d2 100644
--- a/net/sched/Makefile
+++ b/net/sched/Makefile
@@ -4,7 +4,8 @@
obj-y := sch_generic.o
-obj-$(CONFIG_NET_SCHED) += sch_api.o sch_blackhole.o
+obj-y += sch_api.o
+obj-$(CONFIG_NET_SCHED) += sch_blackhole.o
obj-$(CONFIG_NET_CLS) += cls_api.o
obj-$(CONFIG_NET_CLS_ACT) += act_api.o
obj-$(CONFIG_NET_ACT_POLICE) += act_police.o
@@ -14,7 +15,7 @@ obj-$(CONFIG_NET_ACT_IPT) += act_ipt.o
obj-$(CONFIG_NET_ACT_NAT) += act_nat.o
obj-$(CONFIG_NET_ACT_PEDIT) += act_pedit.o
obj-$(CONFIG_NET_ACT_SIMP) += act_simple.o
-obj-$(CONFIG_NET_SCH_FIFO) += sch_fifo.o
+obj-y += sch_fifo.o
obj-$(CONFIG_NET_SCH_CBQ) += sch_cbq.o
obj-$(CONFIG_NET_SCH_HTB) += sch_htb.o
obj-$(CONFIG_NET_SCH_HFSC) += sch_hfsc.o
--
1.5.6.2
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: linux-next: net-current tree build failure
2008-07-21 0:58 linux-next: net-current tree build failure Stephen Rothwell
@ 2008-07-21 1:05 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-07-21 1:05 UTC (permalink / raw)
To: sfr; +Cc: linux-next
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Mon, 21 Jul 2008 10:58:52 +1000
> Hi Dave,
>
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
>
> net/built-in.o: In function `.dev_queue_xmit':
> (.text+0x125a4): undefined reference to `.qdisc_calculate_pkt_len'
> net/built-in.o: In function `.__qdisc_destroy':
> sch_generic.c:(.text+0x28710): undefined reference to `.qdisc_put_stab'
>
> This config has CONFIG_NET_SCHED not set.
>
> I applied the patch below, but it is probably not the correct solution.
No, it isn't. We should just comment out the stab code
when NET_SCHED is not set.
Thanks for catching this.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-21 1:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-21 0:58 linux-next: net-current tree build failure Stephen Rothwell
2008-07-21 1:05 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox