* Re: Fix icom serial compile. [not found] ` <20080721230742.4649b94a@lxorguk.ukuu.org.uk> @ 2008-07-22 1:25 ` Stephen Rothwell 2008-07-22 2:05 ` Alan Cox 0 siblings, 1 reply; 4+ messages in thread From: Stephen Rothwell @ 2008-07-22 1:25 UTC (permalink / raw) To: Alan Cox; +Cc: Dave Jones, Linux Kernel, Linus, linux-next [-- Attachment #1: Type: text/plain, Size: 726 bytes --] Hi Alan, On Mon, 21 Jul 2008 23:07:42 +0100 Alan Cox <alan@lxorguk•ukuu.org.uk> wrote: > > On Mon, 21 Jul 2008 18:13:55 -0400 > Dave Jones <davej@redhat•com> wrote: > > > drivers/serial/icom.c: In function 'recv_interrupt': > > drivers/serial/icom.c:733: error: 'struct uart_info' has no member named 'tty' > > > > Signed-off-by: Dave Jones <davej@redhat•com> > > NAK. Already in the ttydev tree but not yet gone to Linus I have just sent a similar patch. I have to ask why you sent only some of these patches since they were known to break some builds and you had the fix patches already ... -- Cheers, Stephen Rothwell sfr@canb•auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Fix icom serial compile. 2008-07-22 1:25 ` Fix icom serial compile Stephen Rothwell @ 2008-07-22 2:05 ` Alan Cox 2008-07-22 2:41 ` Dave Jones 0 siblings, 1 reply; 4+ messages in thread From: Alan Cox @ 2008-07-22 2:05 UTC (permalink / raw) To: Stephen Rothwell; +Cc: Dave Jones, Linux Kernel, Linus, linux-next > > NAK. Already in the ttydev tree but not yet gone to Linus > > I have just sent a similar patch. I have to ask why you sent only some > of these patches since they were known to break some builds and you had > the fix patches already ... I sent the first batch only because some later stuff didnt apply and I happen to believe in testing patches before sending them (something I note certain other people clearly do after shitting the lot at Linus) I spent the past two days travelling, and all the net time I could get trying to get the patches merged and tested. Everyone and their grandmother keep patching the tty code again and again. I just had another go before bed - its now six pulls in a row someone has broken the patches. Quite frankly if you want to moan about the fact I've been working till 4am trying to sort this mess out you can go see figure 1. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Fix icom serial compile. 2008-07-22 2:05 ` Alan Cox @ 2008-07-22 2:41 ` Dave Jones 2008-07-22 10:46 ` Alan Cox 0 siblings, 1 reply; 4+ messages in thread From: Dave Jones @ 2008-07-22 2:41 UTC (permalink / raw) To: Alan Cox; +Cc: Stephen Rothwell, Linux Kernel, Linus, linux-next On Tue, Jul 22, 2008 at 03:05:19AM +0100, Alan Cox wrote: > > > NAK. Already in the ttydev tree but not yet gone to Linus > > > > I have just sent a similar patch. I have to ask why you sent only some > > of these patches since they were known to break some builds and you had > > the fix patches already ... > > I sent the first batch only because some later stuff didnt apply and I > happen to believe in testing patches before sending them (something I > note certain other people clearly do after shitting the lot at Linus) So what stopped you from just sending the two diffs already posted here twice today ? They're not dependant upon anything else, and the files in questions haven't changed in months. Leaving the tree broken, and NACKing attempts to fix it don't seem to be particularly productive for anyone. > I spent the past two days travelling, and all the net time I could get > trying to get the patches merged and tested. Everyone and their > grandmother keep patching the tty code again and again. I just had > another go before bed - its now six pulls in a row someone has broken the > patches. > > Quite frankly if you want to moan about the fact I've been working till > 4am trying to sort this mess out you can go see figure 1. Please, less drama, more fixing. Dave -- http://www.codemonkey.org.uk ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Fix icom serial compile. 2008-07-22 2:41 ` Dave Jones @ 2008-07-22 10:46 ` Alan Cox 0 siblings, 0 replies; 4+ messages in thread From: Alan Cox @ 2008-07-22 10:46 UTC (permalink / raw) To: Dave Jones; +Cc: Stephen Rothwell, Linux Kernel, Linus, linux-next > Leaving the tree broken, and NACKing attempts to fix it don't seem to be > particularly productive for anyone. I NAKKed the fix because it would have broken the merge *AGAIN* which would have messed up the merging for everything else all for the matter of what four hours ? > Please, less drama, more fixing. Go see figure 1 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-07-22 11:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20080721211659.GA29106@redhat.com>
[not found] ` <20080721221355.GD3472@redhat.com>
[not found] ` <20080721230742.4649b94a@lxorguk.ukuu.org.uk>
2008-07-22 1:25 ` Fix icom serial compile Stephen Rothwell
2008-07-22 2:05 ` Alan Cox
2008-07-22 2:41 ` Dave Jones
2008-07-22 10:46 ` Alan Cox
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox