public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail•com>
Cc: linux-next@vger•kernel.org
Subject: linux-next: ide tree build failure
Date: Thu, 24 Jul 2008 13:17:06 +1000	[thread overview]
Message-ID: <20080724131706.7ecabe1d.sfr@canb.auug.org.au> (raw)

Hi Bart,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

drivers/ide/ppc/pmac.c: In function 'set_timings_mdma':
drivers/ide/ppc/pmac.c:689: error: expected ']' before ')' token

Caused by commit 010fac593cedbdea4841ffcf49d2ea10e8651c6f "ide: make
drive->id an union".

I applied the following patch.
-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/

>From 5123642db8897eb15653453f0f76d33d2a5be19e Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Thu, 24 Jul 2008 13:15:15 +1000
Subject: [PATCH] ide: fix typo in drivers/ide/ppc/pmac.c

drivers/ide/ppc/pmac.c: In function 'set_timings_mdma':
drivers/ide/ppc/pmac.c:689: error: expected ']' before ')' token

Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
 drivers/ide/ppc/pmac.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/ide/ppc/pmac.c b/drivers/ide/ppc/pmac.c
index 0f636a5..9d8b317 100644
--- a/drivers/ide/ppc/pmac.c
+++ b/drivers/ide/ppc/pmac.c
@@ -686,7 +686,7 @@ set_timings_mdma(ide_drive_t *drive, int intf_type, u32 *timings, u32 *timings2,
 	}
 
 	/* Check if drive provides explicit DMA cycle time */
-	if ((id[ATA_ID_FIELD_VALID] & 2) && id[ATA_ID_EIDE_DMA_TIME)
+	if ((id[ATA_ID_FIELD_VALID] & 2) && id[ATA_ID_EIDE_DMA_TIME])
 		cycleTime = max_t(int, id[ATA_ID_EIDE_DMA_TIME], cycleTime);
 
 	/* OHare limits according to some old Apple sources */	
-- 
1.5.6.3

             reply	other threads:[~2008-07-24  3:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-24  3:17 Stephen Rothwell [this message]
2008-07-24 18:41 ` linux-next: ide tree build failure Bartlomiej Zolnierkiewicz
  -- strict thread matches above, loose matches on Subject: below --
2009-06-15  1:34 Stephen Rothwell
2009-06-15  5:35 ` Borislav Petkov
2009-06-15 16:14   ` Bartlomiej Zolnierkiewicz
2009-02-06  3:35 Stephen Rothwell
2009-01-22  1:57 Stephen Rothwell
2009-01-22 13:22 ` Bartlomiej Zolnierkiewicz
2009-01-22 22:14   ` Stephen Rothwell
2008-12-08  2:16 Stephen Rothwell
2008-12-08 17:10 ` Bartlomiej Zolnierkiewicz
2008-12-08 17:49   ` Borislav Petkov
2008-12-09  0:12   ` Stephen Rothwell
2008-08-26  4:06 Stephen Rothwell
2008-08-26 20:04 ` Bartlomiej Zolnierkiewicz
2008-08-12  1:18 Stephen Rothwell
2008-08-12  7:36 ` Borislav Petkov
2008-08-12  9:15   ` Bartlomiej Zolnierkiewicz
2008-06-30  5:28 Stephen Rothwell
2008-06-30 18:38 ` Bartlomiej Zolnierkiewicz
2008-07-01  0:28   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080724131706.7ecabe1d.sfr@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=bzolnier@gmail$(echo .)com \
    --cc=linux-next@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox