From: Borislav Petkov <petkovbb@googlemail•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail•com>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: linux-next: ide tree build failure
Date: Mon, 15 Jun 2009 07:35:14 +0200 [thread overview]
Message-ID: <20090615053514.GA13226@liondog.tnic> (raw)
In-Reply-To: <20090615113430.21122e44.sfr@canb.auug.org.au>
Hi,
On Mon, Jun 15, 2009 at 11:34:30AM +1000, Stephen Rothwell wrote:
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> drivers/ide/ide-tape.c: In function 'idetape_chrdev_open':
> drivers/ide/ide-tape.c:1515: error: implicit declaration of function 'idetape_read_position'
>
> Caused by commit 55ce3a129ea2e8faba4a11bb5dbc305590d1c20c ("ide-tape: fix
> READ POSITION cmd handling") interacting with the later merge
> 8dcce4081305d3d1629190edd112e6473c315cbc ("Merge branch
> 'bp-remove-pc-buf' into for-next").
>
> I have used the ide tree from next-20090612 for today.
Ah, the function got renamed in 55ce3a129ea2e8faba4a11bb5dbc305590d1c20c. Here's
a fix:
---
From: Borislav Petkov <petkovbb@gmail•com>
Date: Mon, 15 Jun 2009 07:32:04 +0200
Subject: [PATCH] ide-tape: fix build issue
This fixes
drivers/ide/ide-tape.c: In function `idetape_chrdev_open':
drivers/ide/ide-tape.c:1515: error: implicit declaration of function `idetape_read_position'
make[1]: *** [drivers/ide/ide-tape.o] Error 1
Signed-off-by: Borislav Petkov <petkovbb@gmail•com>
---
drivers/ide/ide-tape.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index bb71e1e..3a3f10f 100644
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -1512,7 +1512,7 @@ static int idetape_chrdev_open(struct inode *inode, struct file *filp)
goto out_put_tape;
}
- idetape_read_position(drive);
+ ide_tape_read_position(drive);
if (!test_bit(ilog2(IDE_AFLAG_ADDRESS_VALID), &drive->atapi_flags))
(void)idetape_rewind_tape(drive);
--
1.6.3.1
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2009-06-15 5:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 1:34 linux-next: ide tree build failure Stephen Rothwell
2009-06-15 5:35 ` Borislav Petkov [this message]
2009-06-15 16:14 ` Bartlomiej Zolnierkiewicz
-- strict thread matches above, loose matches on Subject: below --
2009-02-06 3:35 Stephen Rothwell
2009-01-22 1:57 Stephen Rothwell
2009-01-22 13:22 ` Bartlomiej Zolnierkiewicz
2009-01-22 22:14 ` Stephen Rothwell
2008-12-08 2:16 Stephen Rothwell
2008-12-08 17:10 ` Bartlomiej Zolnierkiewicz
2008-12-08 17:49 ` Borislav Petkov
2008-12-09 0:12 ` Stephen Rothwell
2008-08-26 4:06 Stephen Rothwell
2008-08-26 20:04 ` Bartlomiej Zolnierkiewicz
2008-08-12 1:18 Stephen Rothwell
2008-08-12 7:36 ` Borislav Petkov
2008-08-12 9:15 ` Bartlomiej Zolnierkiewicz
2008-07-24 3:17 Stephen Rothwell
2008-07-24 18:41 ` Bartlomiej Zolnierkiewicz
2008-06-30 5:28 Stephen Rothwell
2008-06-30 18:38 ` Bartlomiej Zolnierkiewicz
2008-07-01 0:28 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090615053514.GA13226@liondog.tnic \
--to=petkovbb@googlemail$(echo .)com \
--cc=bzolnier@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox