From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Harvey Harrison <harvey.harrison@gmail•com>
Cc: Dominik Brodowski <linux@brodo•de>,
linux-next <linux-next@vger•kernel.org>
Subject: Re: [PATCH-next] pcmcia: fix sparse integer as NULL pointer warning
Date: Thu, 24 Jul 2008 14:36:34 +1000 [thread overview]
Message-ID: <20080724143634.74fe3b8d.sfr@canb.auug.org.au> (raw)
In-Reply-To: <1216863248.30386.61.camel@brick>
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
On Wed, 23 Jul 2008 18:34:08 -0700 Harvey Harrison <harvey.harrison@gmail•com> wrote:
>
> +++ b/drivers/pcmcia/rsrc_nonstatic.c
> @@ -275,7 +275,7 @@ static int readable(struct pcmcia_socket *s, struct resource *res,
> destroy_cis_cache(s);
> }
> s->cis_mem.res = NULL;
> - if ((ret != 0) || (count == 0))
> + if ((ret != 0) || (count == NULL))
I was wondering if it should be
(*count == 0)
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-07-24 4:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 1:34 [PATCH-next] pcmcia: fix sparse integer as NULL pointer warning Harvey Harrison
2008-07-24 4:36 ` Stephen Rothwell [this message]
2008-07-24 5:00 ` Harvey Harrison
2008-07-28 14:53 ` Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080724143634.74fe3b8d.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=harvey.harrison@gmail$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux@brodo$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox