public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Dominik Brodowski <linux@dominikbrodowski•net>
To: Harvey Harrison <harvey.harrison@gmail•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
	linux-next <linux-next@vger•kernel.org>
Subject: Re: [PATCH-next] pcmcia: fix sparse integer as NULL pointer warning
Date: Mon, 28 Jul 2008 16:53:35 +0200	[thread overview]
Message-ID: <20080728145335.GA30258@comet.dominikbrodowski.net> (raw)
In-Reply-To: <1216875606.30386.74.camel@brick>

On Wed, Jul 23, 2008 at 10:00:05PM -0700, Harvey Harrison wrote:
> On Thu, 2008-07-24 at 14:36 +1000, Stephen Rothwell wrote:
> > On Wed, 23 Jul 2008 18:34:08 -0700 Harvey Harrison <harvey.harrison@gmail•com> wrote:
> > >
> > > +++ b/drivers/pcmcia/rsrc_nonstatic.c
> > > @@ -275,7 +275,7 @@ static int readable(struct pcmcia_socket *s, struct resource *res,
> > >  		destroy_cis_cache(s);
> > >  	}
> > >  	s->cis_mem.res = NULL;
> > > -	if ((ret != 0) || (count == 0))
> > > +	if ((ret != 0) || (count == NULL))
> > 
> > I was wondering if it should be
> > 			   (*count == 0)
> > 
> 
> Actually, it looks that way as in this case count can never be none.
> 
> readable() is only called in one place where it is passed the addresses
> of two local variables.  Looking at pccard_validate_cis(), the number
> of valid tuples found is returned through the info pointer, or zero
> if invalid cis is found.
> 
> So I'd say *count == 0 is probably right.
> 
> Dominik?

Yes, *count == 0 is what we'd need to check here.

Thanks!

	Dominik

From: Dominik Brodowski <linux@dominikbrodowski•net>
Date: Mon, 28 Jul 2008 16:37:10 +0200
Subject: [PATCH 1/1] pcmcia: rsrc_nonstatic: check value, not pointer

Bug found by Harvey Harrison and Stephen Rothwell.

Signed-off-by: Dominik Brodowski <linux@dominikbrodowski•net>
---
 drivers/pcmcia/rsrc_nonstatic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/pcmcia/rsrc_nonstatic.c b/drivers/pcmcia/rsrc_nonstatic.c
index d0c1d63..203e579 100644
--- a/drivers/pcmcia/rsrc_nonstatic.c
+++ b/drivers/pcmcia/rsrc_nonstatic.c
@@ -275,7 +275,7 @@ static int readable(struct pcmcia_socket *s, struct resource *res,
 		destroy_cis_cache(s);
 	}
 	s->cis_mem.res = NULL;
-	if ((ret != 0) || (count == 0))
+	if ((ret != 0) || (*count == 0))
 		return 0;
 	return 1;
 }
-- 
1.5.4.3

      reply	other threads:[~2008-07-28 14:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-24  1:34 [PATCH-next] pcmcia: fix sparse integer as NULL pointer warning Harvey Harrison
2008-07-24  4:36 ` Stephen Rothwell
2008-07-24  5:00   ` Harvey Harrison
2008-07-28 14:53     ` Dominik Brodowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080728145335.GA30258@comet.dominikbrodowski.net \
    --to=linux@dominikbrodowski$(echo .)net \
    --cc=harvey.harrison@gmail$(echo .)com \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox