public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb•auug.org.au>
To: David Miller <davem@davemloft•net>
Cc: linux-next@vger•kernel.org,
	Andrew Morton <akpm@linux-foundation•org>,
	Steven Whitehouse <swhiteho@redhat•com>
Subject: Re: linux-next: sparc tree build failure
Date: Mon, 4 Aug 2008 15:35:40 +1000	[thread overview]
Message-ID: <20080804153540.238a079c.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20080803.212620.17129972.davem@davemloft.net>

[-- Attachment #1: Type: text/plain, Size: 3542 bytes --]

Hi Dave,

On Sun, 03 Aug 2008 21:26:20 -0700 (PDT) David Miller <davem@davemloft•net> wrote:
>
> From: Stephen Rothwell <sfr@canb•auug.org.au>
> Date: Fri, 25 Jul 2008 17:05:27 +1000
> 
> > Hi Dave,
> > 
> > Today's linux-next build (sparc defconfig) failed like this:
> > 
> >   Building modules, stage 2.
> > .tmp_kallsyms2.o(.rodata+0x0): In function `kallsyms_addresses':
> > : relocation truncated to fit: R_SPARC_32 _text
> 
> FWIW, Sam had narrowed it down to:
> 
> commit fd593d12770d4a0d1ff095d44b96436c18479ee8
> Author: Eric W. Biederman <ebiederm@xmission•com>
> Date:   Thu Dec 7 02:14:04 2006 +0100
> 
>     [PATCH] relocatable kernel: Kallsyms generate relocatable symbols
>     
>     Print the addresses of non-absolute symbols relative to _text
>     so that ld will generate relocations.  Allowing a relocatable
>     kernel to relocate them.  We can't actually use the symbol names
>     because kallsyms includes static symbols that are not exported
>     from their object files.
>     
>     Add the _text symbol definitions to the architectures which don't
>     define it otherwise linker will fail.
>     
>     Signed-off-by: Eric W. Biederman <ebiederm@xmission•com>
>     Signed-off-by: Vivek Goyal <vgoyal@in•ibm.com>
>     Signed-off-by: Andi Kleen <ak@suse•de>
> 
> and
> 
> commit 2c22d8baa98a92022acb85b0b7c6f4a60df55f47
> Author: Vivek Goyal <vgoyal@in•ibm.com>
> Date:   Thu Dec 7 02:14:10 2006 +0100
> 
>     [PATCH] relocatable kernel: Fix kallsyms on avr32 after relocatable kernel changes
>     
>     o On some platforms like avr32, section init comes before .text and
>       not necessarily a symbol's relative position w.r.t _text is positive.
>       In such cases assembler detects the overflow and emits warning. This
>       patch fixes it.
>     
>     Signed-off-by: Vivek Goyal <vgoyal@in•ibm.com>
>     Signed-off-by: Andi Kleen <ak@suse•de>
>     Cc: Andi Kleen <ak@suse•de>
>     Cc: Haavard Skinnemoen <hskinnemoen@atmel•com>
>     Signed-off-by: Andrew Morton <akpm@osdl•org>
> 
> but I personally still can't reproduce this.  I even had the gcc-3.4.5
> that's installed on my box, using defconfig just like you, and I can't
> trigger this problem.

Weird because I tracked it down to the following:

I finally bisected it down to this commit:

commit f9247273cb69ba101877e946d2d83044409cc8c5
Author: Steven Whitehouse <swhiteho@redhat•com>
Date:   Thu Jul 24 17:22:13 2008 +0100

    UFS: add const to parser token table


(I sent you an email about this on July 31.)
If I revert this and the followup commit:

commit fb2e405fc1fc8b20d9c78eaa1c7fd5a297efde43
Author: Adrian Bunk <bunk@kernel•org>
Date:   Fri Jul 25 02:55:49 2008 +0300

    fix fs/nfs/nfsroot.c compilation

the build succeeds.  Though I must admit Sam's culprits look more likely.

Also weird because I first saw this on July 25 (commit
f9247273cb69ba101877e946d2d83044409cc8c5 first appeared in linux-next
(via Linus' tree) on that day).  It could be some interaction between the
two sets of patches.

Weirder yet, my build system (kisskb) never got this failure even though
it uses the same toolchain that I used.

I just tried again and reverting the two patches I mentioned above does
make the failure go away.

Steve Whitehouse and Andrew asked Linus to revert those two patches but
nothing has happened yet.

-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2008-08-04  5:35 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-25  7:05 linux-next: sparc tree build failure Stephen Rothwell
2008-07-25  7:09 ` Stephen Rothwell
2008-07-26  9:25 ` David Miller
2008-08-04  4:26 ` David Miller
2008-08-04  5:35   ` Stephen Rothwell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-11-26  9:16 Stephen Rothwell
2009-11-26 23:28 ` David Miller
2009-11-27  9:00   ` Thomas Gleixner
2009-11-06  7:02 Stephen Rothwell
2009-11-06  8:19 ` David Miller
2009-11-06  8:26   ` David Miller
2009-11-06  8:27     ` David Miller
2009-11-07  2:35     ` Stephen Rothwell
2009-11-05  7:50 Stephen Rothwell
2009-11-05  7:53 ` David Miller
2009-11-05  8:00   ` David Miller
2009-11-05 14:44     ` Kristoffer Glembo
2009-11-13 10:34     ` Kristoffer Glembo
2009-11-13 14:57       ` David Miller
2009-10-05  7:43 Stephen Rothwell
2009-10-05  7:45 ` David Miller
2009-04-09  5:17 Stephen Rothwell
2009-04-09  5:27 ` Ingo Molnar
2009-04-09  5:28   ` David Miller
2009-04-09  5:36     ` Ingo Molnar
2009-04-09  5:40       ` David Miller
2009-04-09  5:53         ` Ingo Molnar
2009-04-09  5:59           ` David Miller
2009-04-09  5:28 ` David Miller
2009-04-14  3:45 ` Stephen Rothwell
2008-12-04  8:54 Stephen Rothwell
2008-12-04 11:47 ` Sam Ravnborg
2008-12-02  6:24 Stephen Rothwell
2008-12-02 11:22 ` Rusty Russell
2008-12-04  0:04   ` David Miller
2008-11-30 23:46 Stephen Rothwell
2008-12-01  5:41 ` Sam Ravnborg
2008-12-01  7:23   ` David Miller
2008-07-28  6:38 Stephen Rothwell
2008-07-28  8:21 ` Sam Ravnborg
2008-07-28  9:31   ` Adrian Bunk
2008-07-28 15:12     ` Stephen Rothwell
2008-07-28 10:12   ` Stephen Rothwell
2008-07-28 11:16     ` Sam Ravnborg
2008-07-22  7:41 Stephen Rothwell
2008-07-22 22:47 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080804153540.238a079c.sfr@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=akpm@linux-foundation$(echo .)org \
    --cc=davem@davemloft$(echo .)net \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=swhiteho@redhat$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox