From: David Miller <davem@davemloft•net>
To: sfr@canb•auug.org.au
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
kristoffer@gaisler•com
Subject: Re: linux-next: sparc tree build failure
Date: Fri, 06 Nov 2009 00:27:31 -0800 (PST) [thread overview]
Message-ID: <20091106.002731.247254978.davem@davemloft.net> (raw)
In-Reply-To: <20091106.002651.21006753.davem@davemloft.net>
From: David Miller <davem@davemloft•net>
Date: Fri, 06 Nov 2009 00:26:51 -0800 (PST)
> apbuart: Fix build and missing driver unregister.
>
> linux/of_platform.h needs to be included
>
> OF driver needs to be unregistered
>
> Signed-off-by: David S. Miller <davem@davemloft•net>
Sorry left out the patch :-)
Here it is:
diff --git a/drivers/serial/apbuart.c b/drivers/serial/apbuart.c
index 5f9dec3..a1e9503 100644
--- a/drivers/serial/apbuart.c
+++ b/drivers/serial/apbuart.c
@@ -25,6 +25,7 @@
#include <linux/device.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include <linux/io.h>
#include <linux/serial_core.h>
@@ -676,8 +677,7 @@ static int __init grlib_apbuart_init(void)
return ret;
}
- ret = of_register_driver(&grlib_apbuart_of_driver, &of_platform_bus_type);
-
+ ret = of_register_platform_driver(&grlib_apbuart_of_driver);
if (ret) {
printk(KERN_ERR
"%s: of_register_platform_driver failed (%i)\n",
@@ -698,7 +698,7 @@ static void __exit grlib_apbuart_exit(void)
&grlib_apbuart_ports[i]);
uart_unregister_driver(&grlib_apbuart_driver);
-
+ of_unregister_platform_driver(&grlib_apbuart_of_driver);
}
module_init(grlib_apbuart_init);
--
1.6.5.2
next prev parent reply other threads:[~2009-11-06 8:27 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 7:02 linux-next: sparc tree build failure Stephen Rothwell
2009-11-06 8:19 ` David Miller
2009-11-06 8:26 ` David Miller
2009-11-06 8:27 ` David Miller [this message]
2009-11-07 2:35 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2009-11-26 9:16 Stephen Rothwell
2009-11-26 23:28 ` David Miller
2009-11-27 9:00 ` Thomas Gleixner
2009-11-05 7:50 Stephen Rothwell
2009-11-05 7:53 ` David Miller
2009-11-05 8:00 ` David Miller
2009-11-05 14:44 ` Kristoffer Glembo
2009-11-13 10:34 ` Kristoffer Glembo
2009-11-13 14:57 ` David Miller
2009-10-05 7:43 Stephen Rothwell
2009-10-05 7:45 ` David Miller
2009-04-09 5:17 Stephen Rothwell
2009-04-09 5:27 ` Ingo Molnar
2009-04-09 5:28 ` David Miller
2009-04-09 5:36 ` Ingo Molnar
2009-04-09 5:40 ` David Miller
2009-04-09 5:53 ` Ingo Molnar
2009-04-09 5:59 ` David Miller
2009-04-09 5:28 ` David Miller
2009-04-14 3:45 ` Stephen Rothwell
2008-12-04 8:54 Stephen Rothwell
2008-12-04 11:47 ` Sam Ravnborg
2008-12-02 6:24 Stephen Rothwell
2008-12-02 11:22 ` Rusty Russell
2008-12-04 0:04 ` David Miller
2008-11-30 23:46 Stephen Rothwell
2008-12-01 5:41 ` Sam Ravnborg
2008-12-01 7:23 ` David Miller
2008-07-28 6:38 Stephen Rothwell
2008-07-28 8:21 ` Sam Ravnborg
2008-07-28 9:31 ` Adrian Bunk
2008-07-28 15:12 ` Stephen Rothwell
2008-07-28 10:12 ` Stephen Rothwell
2008-07-28 11:16 ` Sam Ravnborg
2008-07-25 7:05 Stephen Rothwell
2008-07-25 7:09 ` Stephen Rothwell
2008-07-26 9:25 ` David Miller
2008-08-04 4:26 ` David Miller
2008-08-04 5:35 ` Stephen Rothwell
2008-07-22 7:41 Stephen Rothwell
2008-07-22 22:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091106.002731.247254978.davem@davemloft.net \
--to=davem@davemloft$(echo .)net \
--cc=kristoffer@gaisler$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox