From: Randy Dunlap <randy.dunlap@oracle•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
akpm <akpm@linux-foundation•org>,
ak@linux•intel.com
Subject: [PATCH -next] Panasonic ACPI depends on INPUT
Date: Wed, 6 Aug 2008 17:29:38 -0700 [thread overview]
Message-ID: <20080806172938.74b8033b.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20080806182828.6bfe0a16.sfr@canb.auug.org.au>
From: Randy Dunlap <randy.dunlap@oracle•com>
Panasonic ACPI driver needs to depend on INPUT.
Otherwise it has build errors when CONFIG_INPUT=n:
drivers/built-in.o: In function `acpi_pcc_hotkey_remove':
pcc_acpi.c:(.text+0x25ded): undefined reference to `input_unregister_device'
pcc_acpi.c:(.text+0x25e03): undefined reference to `input_free_device'
drivers/built-in.o: In function `acpi_pcc_hotkey_notify':
pcc_acpi.c:(.text+0x260d5): undefined reference to `input_event'
pcc_acpi.c:(.text+0x260e2): undefined reference to `input_event'
drivers/built-in.o: In function `acpi_pcc_hotkey_add':
pcc_acpi.c:(.text+0x26267): undefined reference to `input_allocate_device'
pcc_acpi.c:(.text+0x26348): undefined reference to `input_register_device'
pcc_acpi.c:(.text+0x26405): undefined reference to `input_unregister_device'
pcc_acpi.c:(.text+0x26423): undefined reference to `input_free_device'
make[1]: *** [.tmp_vmlinux1] Error 1
Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
---
drivers/acpi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20080806.orig/drivers/acpi/Kconfig
+++ linux-next-20080806/drivers/acpi/Kconfig
@@ -259,7 +259,7 @@ config ACPI_ASUS
config ACPI_PANASONIC
tristate "Panasonic Laptop Extras"
- depends on X86
+ depends on X86 && INPUT
select BACKLIGHT_CLASS_DEVICE
---help---
This driver adds support for access to certain system settings
next prev parent reply other threads:[~2008-08-07 0:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 8:28 linux-next: Tree for August 6 Stephen Rothwell
2008-08-07 0:21 ` linux-next: Tree for August 6 (8390 et al) Randy Dunlap
2008-08-07 7:20 ` Geert Uytterhoeven
2008-08-07 9:29 ` Alan Cox
2008-08-11 9:11 ` [PATCH] net, wd.c: fix undefined reference to `NS8390p_init' Ingo Molnar
2008-08-11 9:47 ` Jeff Garzik
2008-08-11 11:11 ` Ingo Molnar
2008-08-11 20:51 ` David Miller
2008-08-07 0:29 ` Randy Dunlap [this message]
2008-08-11 11:25 ` [PATCH -next] Panasonic ACPI depends on INPUT Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080806172938.74b8033b.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle$(echo .)com \
--cc=ak@linux$(echo .)intel.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox