From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Linus Torvalds <torvalds@linux-foundation•org>
Cc: linux-next@vger•kernel.org, David Fries <david@fries•net>,
David Howells <dhowells@redhat•com>,
James Morris <jmorris@namei•org>,
LKML <linux-kernel@vger•kernel.org>
Subject: linux-next: origin tree build failure
Date: Mon, 18 Aug 2008 10:01:51 +1000 [thread overview]
Message-ID: <20080818100151.c2e9e508.sfr@canb.auug.org.au> (raw)
Hi Linus,
As expected (reported by David Fries), today's linux-next build (powerpc
ppc64_defconfig) failed like this:
In file included from include/linux/tracehook.h:52,
from arch/powerpc/kernel/signal.c:13:
include/linux/security.h: In function 'security_ptrace_traceme':
include/linux/security.h:1760: error: 'parent' undeclared (first use in this function)
Caused by commit 5cd9c58fbe9ec92b45b27e131719af4f2bd9eb40 ("security: Fix
setting of PF_SUPERPRIV by __capable()"). The version of this commit
that has been in the linux-next tree from Aug 8 to Aug 15 is correct, so
I have no idea what happened.
More care needed ...
I applied the following patch from David Fries.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
Date: Sat, 16 Aug 2008 20:17:11 -0500
From: David Fries <david@fries•net>
To: David Howells <dhowells@redhat•com>
Cc: sfr@canb•auug.org.au, jmorris@namei•org, linux-kernel@vger•kernel.org,
linux-security-module@vger•kernel.org
Subject: Fix setting of PF_SUPERPRIV by __capable()
The first two submissions this patch had parent for the argument, the third
one has child then parent and fails to compile with SECURITY disabled.
Please apply the following patch.
> +static inline int security_ptrace_traceme(struct task_struct *child)
> {
> - return cap_ptrace(parent, child, mode);
> + return cap_ptrace_traceme(parent);
> }
security_ptrace_traceme error: 'parent' undeclared
s/child/parent/
Signed-off-by: David Fries <david@fries•net>
diff --git a/include/linux/security.h b/include/linux/security.h
index 2ee5ecf..80c4d00 100644
--- a/include/linux/security.h
+++ b/include/linux/security.h
@@ -1755,7 +1755,7 @@ static inline int security_ptrace_may_access(struct task_struct *child,
return cap_ptrace_may_access(child, mode);
}
-static inline int security_ptrace_traceme(struct task_struct *child)
+static inline int security_ptrace_traceme(struct task_struct *parent)
{
return cap_ptrace_traceme(parent);
}
next reply other threads:[~2008-08-18 0:01 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 0:01 Stephen Rothwell [this message]
2008-08-18 12:55 ` linux-next: origin tree build failure David Howells
2008-08-18 14:03 ` James Morris
-- strict thread matches above, loose matches on Subject: below --
2010-01-12 1:14 Stephen Rothwell
2010-01-12 1:26 ` Linus Torvalds
2010-01-12 2:32 ` Stephen Rothwell
2010-01-12 2:39 ` Stephen Rothwell
2010-01-13 0:14 ` Phillip Lougher
2010-01-13 2:55 ` Stephen Rothwell
2010-01-11 23:58 Stephen Rothwell
2010-01-12 0:29 ` Joakim Tjernlund
2010-01-12 12:38 ` Joakim Tjernlund
2009-12-24 0:54 Stephen Rothwell
2009-12-15 5:41 Stephen Rothwell
2009-12-15 8:07 ` Ingo Molnar
2009-12-15 13:01 ` Peter Ujfalusi
2009-12-15 14:53 ` Mark Brown
2009-12-15 17:27 ` Tony Lindgren
2009-12-15 22:45 ` Stephen Rothwell
2009-12-15 23:02 ` Linus Torvalds
2009-12-15 23:37 ` Stephen Rothwell
2009-12-16 9:30 ` Samuel Ortiz
2009-12-09 23:57 Stephen Rothwell
2009-11-30 23:10 Stephen Rothwell
2009-11-12 0:23 Stephen Rothwell
2009-10-09 7:50 Stephen Rothwell
2009-07-09 0:28 Stephen Rothwell
2009-06-25 1:13 Stephen Rothwell
2009-06-25 3:24 ` Baruch Siach
2009-06-25 4:12 ` Paul Mundt
2009-06-23 6:22 Stephen Rothwell
2009-06-23 10:13 ` Mark Brown
2009-06-19 6:30 Stephen Rothwell
2009-06-12 0:46 Stephen Rothwell
2009-06-12 0:24 Stephen Rothwell
2009-06-12 0:53 ` Paul Mackerras
2009-06-12 1:00 ` Benjamin Herrenschmidt
2009-06-12 9:20 ` Ingo Molnar
2009-06-12 9:33 ` Benjamin Herrenschmidt
2009-06-12 9:43 ` Peter Zijlstra
2009-06-12 9:55 ` Ingo Molnar
2009-06-12 9:57 ` Benjamin Herrenschmidt
2009-06-12 12:53 ` Ingo Molnar
2009-06-12 13:10 ` Benjamin Herrenschmidt
2009-06-12 13:29 ` Benjamin Herrenschmidt
2009-06-12 13:49 ` Ingo Molnar
2009-06-12 14:06 ` Benjamin Herrenschmidt
2009-06-12 14:11 ` Ingo Molnar
2009-06-12 14:23 ` Benjamin Herrenschmidt
2009-06-13 5:06 ` Stephen Rothwell
2009-06-12 13:44 ` Ingo Molnar
2009-06-12 13:56 ` Benjamin Herrenschmidt
2009-06-12 14:07 ` Ingo Molnar
2009-06-12 14:19 ` Benjamin Herrenschmidt
2009-06-13 4:54 ` Stephen Rothwell
2009-04-14 7:34 Stephen Rothwell
2009-04-14 7:58 ` Jesper Nilsson
2009-04-14 4:43 Stephen Rothwell
2009-04-14 8:57 ` David Miller
2009-04-14 9:20 ` Heiko Carstens
2009-04-14 9:08 ` David Miller
2009-04-14 10:26 ` Stephen Rothwell
2009-04-08 3:28 Stephen Rothwell
2009-04-08 0:10 Stephen Rothwell
2009-03-30 0:55 Stephen Rothwell
[not found] <20090112104837.69feedec.sfr@canb.auug.org.au>
2009-01-12 0:10 ` Benjamin Herrenschmidt
2009-01-12 0:10 ` Benjamin Herrenschmidt
2009-01-12 0:10 ` Benjamin Herrenschmidt
[not found] ` <1231719015.22571.4.camel@pasglop>
2009-01-12 9:05 ` Ingo Molnar
2009-01-12 9:24 ` Stephen Rothwell
2009-01-12 9:32 ` Ingo Molnar
2009-01-13 16:31 ` Stephen Rothwell
2009-01-12 9:49 ` Michael Ellerman
2009-01-12 10:44 ` Ingo Molnar
2009-01-12 10:44 ` Ingo Molnar
2009-01-12 10:44 ` Ingo Molnar
2009-01-11 23:48 Stephen Rothwell
2009-01-11 23:48 Stephen Rothwell
2009-01-11 23:48 Stephen Rothwell
2008-12-29 0:43 Stephen Rothwell
2008-12-29 3:36 ` Roland Dreier
2008-12-29 3:44 ` Roland Dreier
2008-12-29 9:58 ` Aleksey Senin
2008-12-29 0:00 Stephen Rothwell
2008-12-28 23:51 Stephen Rothwell
2008-12-28 23:38 Stephen Rothwell
2008-12-29 0:31 ` Linus Torvalds
2008-10-16 0:35 Stephen Rothwell
2008-10-16 4:57 ` David Miller
2008-10-16 0:31 Stephen Rothwell
2008-10-16 12:58 ` Ralf Baechle
2008-10-14 22:59 Stephen Rothwell
2008-10-14 23:43 ` Linus Torvalds
2008-10-14 23:52 ` David Miller
2008-10-15 0:05 ` Mark Brown
2008-10-15 0:34 ` Linus Torvalds
2008-10-14 23:51 ` Linus Torvalds
2008-10-15 9:02 ` Alan Cox
2008-10-15 9:33 ` Ingo Molnar
2008-10-15 11:01 ` Mark Brown
2008-08-26 0:37 Stephen Rothwell
2008-07-25 0:30 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080818100151.c2e9e508.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=david@fries$(echo .)net \
--cc=dhowells@redhat$(echo .)com \
--cc=jmorris@namei$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox