linux-next: origin tree build failure

public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed

From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Linus <torvalds@linux-foundation•org>,
	Andrew Morton <akpm@linux-foundation•org>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
	Albin Tonnerre <albin.tonnerre@free-electrons•com>
Subject: linux-next: origin tree build failure
Date: Tue, 12 Jan 2010 12:14:34 +1100	[thread overview]
Message-ID: <20100112121434.49930eea.sfr@canb.auug.org.au> (raw)

Hi all,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

lib/decompress_unlzo.c:53: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'parse_header'
lib/decompress_unlzo.c:90: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'unlzo'

Caused by commit 7dd65feb6c603e13eba501c34c662259ab38e70e ("lib: add
support for LZO-compressed kernels") and commit
cacb246f8db2b9eba89d44a0f0dd4f6ed93bc113 ("Add LZO compression support
for initramfs and old-style initrd").

I can't figure out how that was supposed to build, so I added the
following patch (which is most likely not correct).

From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Tue, 12 Jan 2010 11:50:16 +1100
Subject: [PATCH] lib: fixup for unlzo build

Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
 lib/decompress_unlzo.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/lib/decompress_unlzo.c b/lib/decompress_unlzo.c
index db521f4..b4d423f 100644
--- a/lib/decompress_unlzo.c
+++ b/lib/decompress_unlzo.c
@@ -50,6 +50,10 @@ static const unsigned char lzop_magic[] = {
 #define LZO_BLOCK_SIZE        (256*1024l)
 #define HEADER_HAS_FILTER      0x00000800L
 
+#ifndef INIT
+#define INIT
+#endif
+
 STATIC inline int INIT parse_header(u8 *input, u8 *skip)
 {
 	int l;
-- 
1.6.6

I then got these:

lib/decompress_unlzo.c: In function 'unlzo':
lib/decompress_unlzo.c:106: error: 'error' undeclared (first use in this function)
lib/decompress_unlzo.c:111: error: implicit declaration of function 'error'

So I just reverted commit
cacb246f8db2b9eba89d44a0f0dd4f6ed93bc113 ("Add LZO compression support
for initramfs and old-style initrd") after removing my fix above.

-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/

next             reply	other threads:[~2010-01-12  1:14 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-12  1:14 Stephen Rothwell [this message]
2010-01-12  1:26 ` linux-next: origin tree build failure Linus Torvalds
2010-01-12  2:32   ` Stephen Rothwell
2010-01-12  2:39     ` Stephen Rothwell
2010-01-13  0:14       ` Phillip Lougher
2010-01-13  2:55         ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2010-01-11 23:58 Stephen Rothwell
2010-01-12  0:29 ` Joakim Tjernlund
2010-01-12 12:38 ` Joakim Tjernlund
2009-12-24  0:54 Stephen Rothwell
2009-12-15  5:41 Stephen Rothwell
2009-12-15  8:07 ` Ingo Molnar
2009-12-15 13:01 ` Peter Ujfalusi
2009-12-15 14:53 ` Mark Brown
2009-12-15 17:27   ` Tony Lindgren
2009-12-15 22:45     ` Stephen Rothwell
2009-12-15 23:02       ` Linus Torvalds
2009-12-15 23:37         ` Stephen Rothwell
2009-12-16  9:30       ` Samuel Ortiz
2009-12-09 23:57 Stephen Rothwell
2009-11-30 23:10 Stephen Rothwell
2009-11-12  0:23 Stephen Rothwell
2009-10-09  7:50 Stephen Rothwell
2009-07-09  0:28 Stephen Rothwell
2009-06-25  1:13 Stephen Rothwell
2009-06-25  3:24 ` Baruch Siach
2009-06-25  4:12   ` Paul Mundt
2009-06-23  6:22 Stephen Rothwell
2009-06-23 10:13 ` Mark Brown
2009-06-19  6:30 Stephen Rothwell
2009-06-12  0:46 Stephen Rothwell
2009-06-12  0:24 Stephen Rothwell
2009-06-12  0:53 ` Paul Mackerras
2009-06-12  1:00 ` Benjamin Herrenschmidt
2009-06-12  9:20   ` Ingo Molnar
2009-06-12  9:33     ` Benjamin Herrenschmidt
2009-06-12  9:43       ` Peter Zijlstra
2009-06-12  9:55         ` Ingo Molnar
2009-06-12  9:57         ` Benjamin Herrenschmidt
2009-06-12 12:53       ` Ingo Molnar
2009-06-12 13:10         ` Benjamin Herrenschmidt
2009-06-12 13:29           ` Benjamin Herrenschmidt
2009-06-12 13:49             ` Ingo Molnar
2009-06-12 14:06               ` Benjamin Herrenschmidt
2009-06-12 14:11                 ` Ingo Molnar
2009-06-12 14:23                   ` Benjamin Herrenschmidt
2009-06-13  5:06                   ` Stephen Rothwell
2009-06-12 13:44           ` Ingo Molnar
2009-06-12 13:56             ` Benjamin Herrenschmidt
2009-06-12 14:07               ` Ingo Molnar
2009-06-12 14:19                 ` Benjamin Herrenschmidt
2009-06-13  4:54             ` Stephen Rothwell
2009-04-14  7:34 Stephen Rothwell
2009-04-14  7:58 ` Jesper Nilsson
2009-04-14  4:43 Stephen Rothwell
2009-04-14  8:57 ` David Miller
2009-04-14  9:20   ` Heiko Carstens
2009-04-14  9:08 ` David Miller
2009-04-14 10:26   ` Stephen Rothwell
2009-04-08  3:28 Stephen Rothwell
2009-04-08  0:10 Stephen Rothwell
2009-03-30  0:55 Stephen Rothwell
     [not found] <20090112104837.69feedec.sfr@canb.auug.org.au>
2009-01-12  0:10 ` Benjamin Herrenschmidt
2009-01-12  0:10 ` Benjamin Herrenschmidt
2009-01-12  0:10 ` Benjamin Herrenschmidt
     [not found] ` <1231719015.22571.4.camel@pasglop>
2009-01-12  9:05   ` Ingo Molnar
2009-01-12  9:24     ` Stephen Rothwell
2009-01-12  9:32       ` Ingo Molnar
2009-01-13 16:31         ` Stephen Rothwell
2009-01-12  9:49     ` Michael Ellerman
2009-01-12 10:44       ` Ingo Molnar
2009-01-12 10:44       ` Ingo Molnar
2009-01-12 10:44       ` Ingo Molnar
2009-01-11 23:48 Stephen Rothwell
2009-01-11 23:48 Stephen Rothwell
2009-01-11 23:48 Stephen Rothwell
2008-12-29  0:43 Stephen Rothwell
2008-12-29  3:36 ` Roland Dreier
2008-12-29  3:44 ` Roland Dreier
2008-12-29  9:58   ` Aleksey Senin
2008-12-29  0:00 Stephen Rothwell
2008-12-28 23:51 Stephen Rothwell
2008-12-28 23:38 Stephen Rothwell
2008-12-29  0:31 ` Linus Torvalds
2008-10-16  0:35 Stephen Rothwell
2008-10-16  4:57 ` David Miller
2008-10-16  0:31 Stephen Rothwell
2008-10-16 12:58 ` Ralf Baechle
2008-10-14 22:59 Stephen Rothwell
2008-10-14 23:43 ` Linus Torvalds
2008-10-14 23:52   ` David Miller
2008-10-15  0:05   ` Mark Brown
2008-10-15  0:34     ` Linus Torvalds
2008-10-14 23:51 ` Linus Torvalds
2008-10-15  9:02 ` Alan Cox
2008-10-15  9:33 ` Ingo Molnar
2008-10-15 11:01   ` Mark Brown
2008-08-26  0:37 Stephen Rothwell
2008-08-18  0:01 Stephen Rothwell
2008-08-18 12:55 ` David Howells
2008-08-18 14:03   ` James Morris
2008-07-25  0:30 Stephen Rothwell

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:db521f4 dfblob:b4d423f )
 OR (
bs:"lib: fixup for unlzo build" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100112121434.49930eea.sfr@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=akpm@linux-foundation$(echo .)org \
    --cc=albin.tonnerre@free-electrons$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=torvalds@linux-foundation$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox