* linux-next: pcmcia tree build warnings
@ 2008-08-20 6:24 Stephen Rothwell
2008-08-21 21:16 ` Dominik Brodowski
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2008-08-20 6:24 UTC (permalink / raw)
To: Dominik Brodowski; +Cc: linux-next
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
Hi Dominik,
These are worth fixing:
drivers/pcmcia/ds.c: In function 'pcmcia_devmatch':
drivers/pcmcia/ds.c:962: warning: passing argument 1 of 'dev_driver_string' from incompatible pointer type
drivers/pcmcia/ds.c:962: warning: passing argument 1 of 'dev_name' from incompatible pointer type
drivers/pcmcia/ds.c:969: warning: passing argument 1 of 'dev_driver_string' from incompatible pointer type
drivers/pcmcia/ds.c:969: warning: passing argument 1 of 'dev_name' from incompatible pointer type
You are passing a "struct pcmcia_device *" instead of a "struct device *"
to ds_dev_dbg(). (commit 5e42a2fcae73c08af2ae4d64b25f807708ff6193
"pcmcia: use dev_printk in module pcmcia")
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: linux-next: pcmcia tree build warnings
2008-08-20 6:24 linux-next: pcmcia tree build warnings Stephen Rothwell
@ 2008-08-21 21:16 ` Dominik Brodowski
0 siblings, 0 replies; 2+ messages in thread
From: Dominik Brodowski @ 2008-08-21 21:16 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next
Hi Stephen,
On Wed, Aug 20, 2008 at 04:24:10PM +1000, Stephen Rothwell wrote:
> These are worth fixing:
>
> drivers/pcmcia/ds.c: In function 'pcmcia_devmatch':
> drivers/pcmcia/ds.c:962: warning: passing argument 1 of 'dev_driver_string' from incompatible pointer type
> drivers/pcmcia/ds.c:962: warning: passing argument 1 of 'dev_name' from incompatible pointer type
> drivers/pcmcia/ds.c:969: warning: passing argument 1 of 'dev_driver_string' from incompatible pointer type
> drivers/pcmcia/ds.c:969: warning: passing argument 1 of 'dev_name' from incompatible pointer type
>
> You are passing a "struct pcmcia_device *" instead of a "struct device *"
> to ds_dev_dbg(). (commit 5e42a2fcae73c08af2ae4d64b25f807708ff6193
> "pcmcia: use dev_printk in module pcmcia")
Thanks for noticing those. A patch to fix these issues will be in the next
-next :)
Best,
Dominik
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-08-21 21:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-20 6:24 linux-next: pcmcia tree build warnings Stephen Rothwell
2008-08-21 21:16 ` Dominik Brodowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox