From: Ingo Molnar <mingo@elte•hu>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Thomas Gleixner <tglx@linutronix•de>,
"H. Peter Anvin" <hpa@zytor•com>,
linux-next@vger•kernel.org, Steven Rostedt <rostedt@goodmis•org>
Subject: Re: linux-next: ftrace tree build failure
Date: Mon, 25 Aug 2008 08:11:01 +0200 [thread overview]
Message-ID: <20080825061101.GA22790@elte.hu> (raw)
In-Reply-To: <20080825060529.GA14993@elte.hu>
* Ingo Molnar <mingo@elte•hu> wrote:
> > kernel/trace/ftrace.c:416: error: incompatible type for argument 1 of '_spin_lock_irqsave'
> > kernel/trace/ftrace.c:433: error: incompatible type for argument 1 of '_spin_lock_irqsave'
> >
> > (This is after I have disabled CONFIG_FTRACE_MCOUNT_RECORD)
>
> hm, how have you disabled it? It's not an interactive option and it's
> always enabled when CONFIG_DYNAMIC_FTRACE is enabled. (that's how that
> build failure never got discovered)
ah, i see the other thread now, about binutils version dependency. I've
applied your fix as per the commit below.
Ingo
>From b2528d2a50942e9d546d3c2e29cde89336053a03 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Mon, 25 Aug 2008 13:08:44 +1000
Subject: [PATCH] ftrace: fix build failure
After disabling FTRACE_MCOUNT_RECORD via a patch, a dormant build
failure surfaced:
kernel/trace/ftrace.c: In function 'ftrace_record_ip':
kernel/trace/ftrace.c:416: error: incompatible type for argument 1 of '_spin_lock_irqsave'
kernel/trace/ftrace.c:433: error: incompatible type for argument 1 of '_spin_lock_irqsave'
Introduced by commit 6dad8e07f4c10b17b038e84d29f3ca41c2e55cd0 ("ftrace:
add necessary locking for ftrace records").
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
Signed-off-by: Ingo Molnar <mingo@elte•hu>
---
kernel/trace/ftrace.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index dcc8f6b..2bc3eb5 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -161,8 +161,8 @@ static int __unregister_ftrace_function(struct ftrace_ops *ops)
* not recorded via the compilation.
*/
static DEFINE_SPINLOCK(ftrace_hash_lock);
-#define ftrace_hash_lock(flags) spin_lock_irqsave(ftrace_hash_lock, flags)
-#define ftrace_hash_unlock(flags) spin_lock_irqsave(ftrace_hash_lock, flags)
+#define ftrace_hash_lock(flags) spin_lock_irqsave(&ftrace_hash_lock, flags)
+#define ftrace_hash_unlock(flags) spin_lock_irqsave(&ftrace_hash_lock, flags)
#else
/* This is protected via the ftrace_lock with MCOUNT_RECORD. */
#define ftrace_hash_lock(flags) do { (void)flags; } while (0)
next prev parent reply other threads:[~2008-08-25 6:11 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-25 3:08 linux-next: ftrace tree build failure Stephen Rothwell
2008-08-25 6:05 ` Ingo Molnar
2008-08-25 6:11 ` Ingo Molnar [this message]
2008-08-25 6:31 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2009-01-07 0:53 Stephen Rothwell
2009-01-07 9:55 ` Ingo Molnar
2009-01-07 21:20 ` Stephen Rothwell
2009-01-02 9:07 Stephen Rothwell
2009-01-02 9:14 ` Ingo Molnar
2009-01-02 10:22 ` Stephen Rothwell
2009-01-02 11:16 ` Ingo Molnar
2008-11-25 3:21 Stephen Rothwell
2008-11-25 3:48 ` Steven Rostedt
2008-11-25 4:13 ` Stephen Rothwell
2008-11-25 4:31 ` Steven Rostedt
2008-11-25 5:09 ` Stephen Rothwell
2008-11-25 5:44 ` Steven Rostedt
2008-11-25 6:57 ` Stephen Rothwell
2008-11-25 7:14 ` Ingo Molnar
2008-11-25 7:26 ` Stephen Rothwell
2008-11-25 5:24 ` Steven Rostedt
2008-11-25 3:07 Stephen Rothwell
2008-11-25 3:21 ` Steven Rostedt
2008-11-25 7:28 ` Ingo Molnar
2008-11-25 7:43 ` Stephen Rothwell
2008-11-25 8:04 ` Ingo Molnar
2008-11-25 14:57 ` John W. Linville
2008-11-25 18:46 ` Luis R. Rodriguez
2008-11-26 0:08 ` Stephen Rothwell
2008-11-26 0:14 ` Luis R. Rodriguez
2008-08-25 3:01 Stephen Rothwell
2008-08-25 6:09 ` Ingo Molnar
2008-08-25 16:42 ` Steven Rostedt
2008-08-25 16:46 ` Steven Rostedt
2008-08-15 2:27 Stephen Rothwell
2008-08-15 7:56 ` Ingo Molnar
2008-08-15 8:29 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080825061101.GA22790@elte.hu \
--to=mingo@elte$(echo .)hu \
--cc=hpa@zytor$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rostedt@goodmis$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox