From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Dominik Brodowski <linux@dominikbrodowski•net>
Cc: linux-next@vger•kernel.org
Subject: linux-next: pcmcia tree build failure
Date: Fri, 29 Aug 2008 16:36:58 +1000 [thread overview]
Message-ID: <20080829163658.c8ea1bba.sfr@canb.auug.org.au> (raw)
Hi Dominik,
Today's linux-next build (x86_64 allmodconfig) failed like this:
sound/pcmcia/vx/vxpocket.c: In function 'vxpocket_config':
sound/pcmcia/vx/vxpocket.c:238: error: implicit declaration of function 'handle_to_dev'
sound/pcmcia/vx/vxpocket.c:238: error: invalid lvalue in unary '&'
sound/pcmcia/pdaudiocf/pdaudiocf.c: In function 'snd_pdacf_probe':
sound/pcmcia/pdaudiocf/pdaudiocf.c:131: error: implicit declaration of function 'handle_to_dev'
sound/pcmcia/pdaudiocf/pdaudiocf.c:131: error: invalid lvalue in unary '&'
drivers/char/pcmcia/cm4040_cs.c: In function 'cm4040_config_check':
drivers/char/pcmcia/cm4040_cs.c:550: error: implicit declaration of function 'handle_to_dev'
drivers/char/pcmcia/cm4040_cs.c:550: error: invalid lvalue in unary '&'
drivers/char/pcmcia/cm4040_cs.c:550: error: invalid lvalue in unary '&'
drivers/char/pcmcia/cm4040_cs.c: In function 'reader_config':
drivers/char/pcmcia/cm4040_cs.c:572: error: invalid lvalue in unary '&'
drivers/char/pcmcia/cm4040_cs.c:572: error: invalid lvalue in unary '&'
Caused by commit 86b736d122166ec779bd86ac24e24117a675e98d ("pcmcia:
cleanup device driver header file") which removed the handle_to_dev()
macro. I applied the following patch.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Fri, 29 Aug 2008 16:34:12 +1000
Subject: [PATCH] pcmcia: restore handle_to_dev macro
It is still in widespread use.
It was removed by commit 86b736d122166ec779bd86ac24e24117a675e98d
("pcmcia: cleanup device driver header file").
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
include/pcmcia/ds.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/pcmcia/ds.h b/include/pcmcia/ds.h
index 13c01ab..374a7cc 100644
--- a/include/pcmcia/ds.h
+++ b/include/pcmcia/ds.h
@@ -137,6 +137,7 @@ struct pcmcia_device {
#define to_pcmcia_dev(n) container_of(n, struct pcmcia_device, dev)
#define to_pcmcia_drv(n) container_of(n, struct pcmcia_driver, drv)
+#define handle_to_dev(handle) (handle->dev)
/* (deprecated) error reporting by PCMCIA devices. Use dev_printk()
* or dev_dbg() directly in the driver, without referring to pcmcia_error_func()
--
1.5.6.5
next reply other threads:[~2008-08-29 6:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-29 6:36 Stephen Rothwell [this message]
2008-08-29 7:44 ` linux-next: pcmcia tree build failure Dominik Brodowski
2008-08-29 8:31 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2010-01-25 2:13 Stephen Rothwell
2010-01-25 7:38 ` Dominik Brodowski
2009-11-04 2:15 Stephen Rothwell
2009-11-04 8:07 ` Dominik Brodowski
2009-11-04 10:16 ` Stephen Rothwell
2008-08-22 4:52 Stephen Rothwell
2008-08-23 0:40 ` Dominik Brodowski
2008-08-23 4:30 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080829163658.c8ea1bba.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux@dominikbrodowski$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox