From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Alan Cox <alan@lxorguk•ukuu.org.uk>
Cc: linux-next@vger•kernel.org
Subject: linux-next: ttydev tree build failure
Date: Tue, 2 Sep 2008 17:23:22 +1000 [thread overview]
Message-ID: <20080902172322.15c465e7.sfr@canb.auug.org.au> (raw)
Hi Alan,
Today's linux-next build (x86_64 allmodconfig) failed like this:
/drivers/char/tty_ioctl.c: In function 'change_termios':
drivers/isdn/capi/capi.c:1234: error: implicit declaration of function 'n_tty_ioctl'
drivers/isdn/gigaset/ser-gigaset.c: In function 'gigaset_tty_ioctl':
drivers/isdn/gigaset/ser-gigaset.c:648: error: implicit declaration of function 'n_tty_ioctl'
Introduced by commit 686b5e4aea05a80e370dc931b7f4a8d03c80da54
("tty-move-canon-specials"). I added the following patch (which may not
be correct).
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
>From 90b2237399675ce920b1620426a6a231670574f3 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Tue, 2 Sep 2008 17:21:47 +1000
Subject: [PATCH] ttydev: fallout from tty-move-canon-specials
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
drivers/isdn/capi/capi.c | 2 +-
drivers/isdn/gigaset/ser-gigaset.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/isdn/capi/capi.c b/drivers/isdn/capi/capi.c
index 3b29c04..1b5bf87 100644
--- a/drivers/isdn/capi/capi.c
+++ b/drivers/isdn/capi/capi.c
@@ -1231,7 +1231,7 @@ static int capinc_tty_ioctl(struct tty_struct *tty, struct file * file,
int error = 0;
switch (cmd) {
default:
- error = n_tty_ioctl (tty, file, cmd, arg);
+ error = n_tty_ioctl_helper(tty, file, cmd, arg);
break;
}
return error;
diff --git a/drivers/isdn/gigaset/ser-gigaset.c b/drivers/isdn/gigaset/ser-gigaset.c
index 5e89fa1..cc4f4e4 100644
--- a/drivers/isdn/gigaset/ser-gigaset.c
+++ b/drivers/isdn/gigaset/ser-gigaset.c
@@ -645,7 +645,7 @@ gigaset_tty_ioctl(struct tty_struct *tty, struct file *file,
case TCGETS:
case TCGETA:
/* pass through to underlying serial device */
- rc = n_tty_ioctl(tty, file, cmd, arg);
+ rc = n_tty_ioctl_helper(tty, file, cmd, arg);
break;
case TCFLSH:
@@ -660,7 +660,7 @@ gigaset_tty_ioctl(struct tty_struct *tty, struct file *file,
break;
}
/* flush the serial port's buffer */
- rc = n_tty_ioctl(tty, file, cmd, arg);
+ rc = n_tty_ioctl_helper(tty, file, cmd, arg);
break;
case FIONREAD:
--
1.5.6.5
next reply other threads:[~2008-09-02 7:23 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-02 7:23 Stephen Rothwell [this message]
2008-09-02 9:22 ` linux-next: ttydev tree build failure Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2009-07-24 5:54 Stephen Rothwell
2009-07-17 3:12 Stephen Rothwell
2009-07-16 5:04 Stephen Rothwell
2009-07-14 4:10 Stephen Rothwell
2009-07-06 3:26 Stephen Rothwell
2009-04-20 3:09 Stephen Rothwell
2008-11-24 5:13 Stephen Rothwell
2008-11-24 9:59 ` Alan Cox
2008-10-23 6:29 Stephen Rothwell
2008-10-23 7:34 ` Alan Cox
2008-10-23 7:35 ` Benjamin Herrenschmidt
2008-10-24 4:58 ` Stephen Rothwell
2008-10-23 10:28 ` Hendrik Brueckner
2008-10-20 8:06 Stephen Rothwell
2008-10-20 21:48 ` Lee Howard
2008-10-21 9:33 ` Alan Cox
2008-10-15 9:39 Stephen Rothwell
2008-08-20 8:23 Stephen Rothwell
2008-08-20 8:26 ` Alan Cox
2008-08-20 9:08 ` Stephen Rothwell
2008-07-23 7:17 Stephen Rothwell
2008-07-23 12:39 ` Geert Uytterhoeven
2008-07-23 14:46 ` Alan Cox
2008-07-23 15:49 ` Geert Uytterhoeven
2008-07-23 15:47 ` Alan Cox
2008-07-23 16:39 ` Geert Uytterhoeven
2008-07-23 16:28 ` Alan Cox
2008-07-23 18:55 ` Geert Uytterhoeven
2008-07-18 21:34 Aleksey Gorelov
2008-07-18 8:59 Stephen Rothwell
2008-07-02 5:30 Stephen Rothwell
2008-07-02 18:10 ` Randy Dunlap
2008-07-02 19:54 ` Alan Cox
2008-07-02 5:19 Stephen Rothwell
2008-07-02 5:21 ` Stephen Rothwell
2008-07-02 8:09 ` Alan Cox
2008-07-02 5:08 Stephen Rothwell
2008-07-02 8:05 ` Alan Cox
2008-07-01 14:17 Stephen Rothwell
2008-07-01 14:23 ` Alan Cox
2008-07-01 14:51 ` Stephen Rothwell
2008-07-01 15:27 ` Greg KH
2008-07-01 15:36 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080902172322.15c465e7.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=alan@lxorguk$(echo .)ukuu.org.uk \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox