From: Aleksey Gorelov <dared1st@yahoo•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>,
Alan Cox <alan@lxorguk•ukuu.org.uk>
Cc: linux-next@vger•kernel.org, Greg KH <greg@kroah•com>
Subject: Re: linux-next: ttydev tree build failure
Date: Fri, 18 Jul 2008 14:34:18 -0700 (PDT) [thread overview]
Message-ID: <944003.64972.qm@web83313.mail.sp1.yahoo.com> (raw)
----- Original Message ----
> From: Stephen Rothwell <sfr@canb•auug.org.au>
> To: Alan Cox <alan@lxorguk•ukuu.org.uk>
> Cc: linux-next@vger•kernel.org; Greg KH <greg@kroah•com>; Aleksey Gorelov <dared1st@yahoo•com>
> Sent: Friday, July 18, 2008 1:59:45 AM
> Subject: linux-next: ttydev tree build failure
>
> Hi Alan,
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> drivers/usb/serial/usb_debug.c: In function 'usb_debug_open':
> drivers/usb/serial/usb_debug.c:37: warning: passing argument 1 of
> 'usb_serial_generic_open' from incompatible pointer type
> drivers/usb/serial/usb_debug.c:37: warning: passing argument 2 of
> 'usb_serial_generic_open' from incompatible pointer type
> drivers/usb/serial/usb_debug.c:37: error: too few arguments to function
> 'usb_serial_generic_open'
> drivers/usb/serial/usb_debug.c: At top level:
> drivers/usb/serial/usb_debug.c:47: warning: initialization from incompatible
> pointer type
>
> usb_debug_open was added in commit
> 1d051a41474c386498bc37e3ae89f7937222cfe7 ("USB: debug port converter does
> not accept more than 8 byte packets") from the usb tree.
>
> I applied the patch below and will do so until it can be resolved.
>
> --
> Cheers,
> Stephen Rothwell sfr@canb•auug.org.au
>
> From 36676f026d56652cf4d42c13651373dc6a232141 Mon Sep 17 00:00:00 2001
> From: Stephen Rothwell
> Date: Fri, 18 Jul 2008 18:54:09 +1000
> Subject: [PATCH] usb: tty API change fallout
>
> Signed-off-by: Stephen Rothwell
> ---
> drivers/usb/serial/usb_debug.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/serial/usb_debug.c b/drivers/usb/serial/usb_debug.c
> index 9ca4d4d..06a272b 100644
> --- a/drivers/usb/serial/usb_debug.c
> +++ b/drivers/usb/serial/usb_debug.c
> @@ -31,10 +31,10 @@ static struct usb_driver debug_driver = {
> .no_dynamic_id = 1,
> };
>
> -int usb_debug_open(struct usb_serial_port *port, struct file *filp)
> +int usb_debug_open(struct tty_struct *tty, struct usb_serial_port *port, struct
> file *filp)
> {
> port->bulk_out_size = USB_DEBUG_MAX_PACKET_SIZE;
> - return usb_serial_generic_open(port, filp);
> + return usb_serial_generic_open(tty, port, filp);
> }
>
> static struct usb_serial_driver debug_device = {
> --
> 1.5.6.2
original patch was against 2.6.26 git which still has
int usb_serial_generic_open (struct usb_serial_port *port, struct file *filp)
Aleks.
next reply other threads:[~2008-07-18 21:41 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 21:34 Aleksey Gorelov [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-07-24 5:54 linux-next: ttydev tree build failure Stephen Rothwell
2009-07-17 3:12 Stephen Rothwell
2009-07-16 5:04 Stephen Rothwell
2009-07-14 4:10 Stephen Rothwell
2009-07-06 3:26 Stephen Rothwell
2009-04-20 3:09 Stephen Rothwell
2008-11-24 5:13 Stephen Rothwell
2008-11-24 9:59 ` Alan Cox
2008-10-23 6:29 Stephen Rothwell
2008-10-23 7:34 ` Alan Cox
2008-10-23 7:35 ` Benjamin Herrenschmidt
2008-10-24 4:58 ` Stephen Rothwell
2008-10-23 10:28 ` Hendrik Brueckner
2008-10-20 8:06 Stephen Rothwell
2008-10-20 21:48 ` Lee Howard
2008-10-21 9:33 ` Alan Cox
2008-10-15 9:39 Stephen Rothwell
2008-09-02 7:23 Stephen Rothwell
2008-09-02 9:22 ` Alan Cox
2008-08-20 8:23 Stephen Rothwell
2008-08-20 8:26 ` Alan Cox
2008-08-20 9:08 ` Stephen Rothwell
2008-07-23 7:17 Stephen Rothwell
2008-07-23 12:39 ` Geert Uytterhoeven
2008-07-23 14:46 ` Alan Cox
2008-07-23 15:49 ` Geert Uytterhoeven
2008-07-23 15:47 ` Alan Cox
2008-07-23 16:39 ` Geert Uytterhoeven
2008-07-23 16:28 ` Alan Cox
2008-07-23 18:55 ` Geert Uytterhoeven
2008-07-18 8:59 Stephen Rothwell
2008-07-02 5:30 Stephen Rothwell
2008-07-02 18:10 ` Randy Dunlap
2008-07-02 19:54 ` Alan Cox
2008-07-02 5:19 Stephen Rothwell
2008-07-02 5:21 ` Stephen Rothwell
2008-07-02 8:09 ` Alan Cox
2008-07-02 5:08 Stephen Rothwell
2008-07-02 8:05 ` Alan Cox
2008-07-01 14:17 Stephen Rothwell
2008-07-01 14:23 ` Alan Cox
2008-07-01 14:51 ` Stephen Rothwell
2008-07-01 15:27 ` Greg KH
2008-07-01 15:36 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=944003.64972.qm@web83313.mail.sp1.yahoo.com \
--to=dared1st@yahoo$(echo .)com \
--cc=alan@lxorguk$(echo .)ukuu.org.uk \
--cc=greg@kroah$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox