From: Randy Dunlap <randy.dunlap@oracle•com>
To: Nicolas Pitre <nico@cam•org>
Cc: Dmitry Torokhov <dtor@insightbb•com>,
lkml <linux-kernel@vger•kernel.org>, akpm <akpm@osdl•org>,
linux-next@vger•kernel.org
Subject: Re: [PATCH] ucb1400_ts depends SND_AC97_BUS
Date: Thu, 4 Sep 2008 21:44:44 -0700 [thread overview]
Message-ID: <20080904214444.0dccf859.randy.dunlap@oracle.com> (raw)
In-Reply-To: <alpine.LFD.1.10.0809050028590.23787@xanadu.home>
On Fri, 05 Sep 2008 00:37:17 -0400 (EDT) Nicolas Pitre wrote:
> On Thu, 4 Sep 2008, Randy Dunlap wrote:
>
> > On Sun, 10 Dec 2006 22:55:25 -0500 (EST) Nicolas Pitre wrote:
> >
> > > On Sat, 9 Dec 2006, Randy Dunlap wrote:
> > >
> > > > On Sat, 09 Dec 2006 22:17:55 -0500 (EST) Nicolas Pitre wrote:
> > > >
> > > > > Please consider what SND_CONFIG_AC97_BUS corresponds to. It is
> > > > > sound/pci/ac97/ac97_bus.c and if you look into this file you'll see that
> > > > > it is perfectly buildable even if sound is entirely configured out, just
> > > > > like some lib code would be.
> > > >
> > > > OK. Should it (CONFIG_SND_AC97_BUS -> sound/pci/ac97/ac97_bus.c)
> > > > be buildable when sound is disabled?
> > >
> > > Yes.
> > >
> > > > If so, where should it be moved to (since afaik, make won't even
> > > > descend into sound/ if SOUND=n; I don't see that changing
> > > > any time soon).
> > >
> > > What about this patch?
> >
> > Can we get this patch or some patch into the input tree for linux-next?
>
> This patch is commit e1036502e5263851259d147771226161e5ccc85a and
> appeared in mainline almost 2 years ago.
Ack. Sorry about that. Wrong ucb thread.
ucb1400_core still has build errors in linux-next
since it uses ac97_bus_type even when CONFIG_SOUND=n.
---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/
next prev parent reply other threads:[~2008-09-05 4:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061209003635.e778ff76.randy.dunlap@oracle.com>
[not found] ` <200612092150.02940.dtor@insightbb.com>
[not found] ` <20061209185737.1768315d.randy.dunlap@oracle.com>
[not found] ` <200612092205.19358.dtor@insightbb.com>
[not found] ` <Pine.LNX.4.64.0612092212410.2630@xanadu.home>
[not found] ` <20061209210945.5abe2d89.randy.dunlap@oracle.com>
[not found] ` <Pine.LNX.4.64.0612102244140.2630@xanadu.home>
2008-09-05 2:57 ` [PATCH] ucb1400_ts depends SND_AC97_BUS Randy Dunlap
2008-09-05 4:37 ` Nicolas Pitre
2008-09-05 4:44 ` Randy Dunlap [this message]
2008-09-05 5:09 ` Nicolas Pitre
2008-09-05 6:46 ` Takashi Iwai
2008-09-05 14:52 ` Nicolas Pitre
2008-09-05 16:26 ` Takashi Iwai
2008-09-05 16:32 ` Nicolas Pitre
2008-09-05 17:17 ` Takashi Iwai
2008-09-05 18:33 ` Dmitry Torokhov
2008-09-06 9:54 ` Takashi Iwai
2008-09-05 21:09 ` Randy Dunlap
2008-09-06 9:53 ` Takashi Iwai
2008-09-05 5:27 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080904214444.0dccf859.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle$(echo .)com \
--cc=akpm@osdl$(echo .)org \
--cc=dtor@insightbb$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=nico@cam$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox