public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed

From: Takashi Iwai <tiwai@suse•de>
To: Nicolas Pitre <nico@cam•org>
Cc: Randy Dunlap <randy.dunlap@oracle•com>,
	Dmitry Torokhov <dtor@insightbb•com>,
	lkml <linux-kernel@vger•kernel.org>, akpm <akpm@osdl•org>,
	linux-next@vger•kernel.org
Subject: Re: [PATCH] ucb1400_ts depends SND_AC97_BUS
Date: Fri, 05 Sep 2008 19:17:50 +0200	[thread overview]
Message-ID: <s5hprniv7ep.wl%tiwai@suse.de> (raw)
In-Reply-To: <alpine.LFD.1.10.0809051231120.23787@xanadu.home>

At Fri, 05 Sep 2008 12:32:32 -0400 (EDT),
Nicolas Pitre wrote:
> 
> On Fri, 5 Sep 2008, Takashi Iwai wrote:
> 
> > At Fri, 05 Sep 2008 10:52:25 -0400 (EDT),
> > Nicolas Pitre wrote:
> > > 
> > > On Fri, 5 Sep 2008, Takashi Iwai wrote:
> > > 
> > > > > This was fixed 2 years ago.  Who broke it this time?
> > > > 
> > > > Oh, it must be me.
> > > 
> > > I think both your patch and the one I previously posted are needed.
> > 
> > Could you repost?  I can't find it easily now.

Thanks.  For linux-next, yes, it's needed.  But it's not for 2.6.27.

Meanwhile, my fix should be included in 2.6.27 since it's a
regression.

Randy, could you check whether these two patches fix your problem?
I'll put my patch to my tree for the next pull request after your
confirmation.

Can Nicolas's patch be to input tree, or any other taker?


thanks,

Takashi

> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
> index 6e1e8c6..22cf319 100644
> --- a/drivers/input/touchscreen/Kconfig
> +++ b/drivers/input/touchscreen/Kconfig
> @@ -219,7 +219,6 @@ config TOUCHSCREEN_ATMEL_TSADCC
>  
>  config TOUCHSCREEN_UCB1400
>  	tristate "Philips UCB1400 touchscreen"
> -	select AC97_BUS
>  	depends on UCB1400_CORE
>  	help
>  	  This enables support for the Philips UCB1400 touchscreen interface.
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 5dba165..70355d3 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -52,6 +52,7 @@ config HTC_PASIC3
>  
>  config UCB1400_CORE
>  	tristate "Philips UCB1400 Core driver"
> +	select AC97_BUS
>  	help
>  	  This enables support for the Philips UCB1400 core functions.
>  	  The UCB1400 is an AC97 audio codec.
> 
> 
> Nicolas
> 

next prev parent reply	other threads:[~2008-09-05 17:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20061209003635.e778ff76.randy.dunlap@oracle.com>
     [not found] ` <200612092150.02940.dtor@insightbb.com>
     [not found]   ` <20061209185737.1768315d.randy.dunlap@oracle.com>
     [not found]     ` <200612092205.19358.dtor@insightbb.com>
     [not found]       ` <Pine.LNX.4.64.0612092212410.2630@xanadu.home>
     [not found]         ` <20061209210945.5abe2d89.randy.dunlap@oracle.com>
     [not found]           ` <Pine.LNX.4.64.0612102244140.2630@xanadu.home>
2008-09-05  2:57             ` [PATCH] ucb1400_ts depends SND_AC97_BUS Randy Dunlap
2008-09-05  4:37               ` Nicolas Pitre
2008-09-05  4:44                 ` Randy Dunlap
2008-09-05  5:09                   ` Nicolas Pitre
2008-09-05  6:46                     ` Takashi Iwai
2008-09-05 14:52                       ` Nicolas Pitre
2008-09-05 16:26                         ` Takashi Iwai
2008-09-05 16:32                           ` Nicolas Pitre
2008-09-05 17:17                             ` Takashi Iwai [this message]
2008-09-05 18:33                               ` Dmitry Torokhov
2008-09-06  9:54                                 ` Takashi Iwai
2008-09-05 21:09                               ` Randy Dunlap
2008-09-06  9:53                                 ` Takashi Iwai
2008-09-05  5:27                   ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hprniv7ep.wl%tiwai@suse.de \
    --to=tiwai@suse$(echo .)de \
    --cc=akpm@osdl$(echo .)org \
    --cc=dtor@insightbb$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=nico@cam$(echo .)org \
    --cc=randy.dunlap@oracle$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox