From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Al Viro <viro@ZenIV•linux.org.uk>
Cc: linux-next@vger•kernel.org, David Chinner <david@fromorbit•com>,
Christoph Hellwig <hch@infradead•org>,
Lachlan McIlroy <lachlan@sgi•com>
Subject: linux-next: vfs tree build failure
Date: Mon, 20 Oct 2008 17:18:30 +1100 [thread overview]
Message-ID: <20081020171830.9ece287f.sfr@canb.auug.org.au> (raw)
Hi Al,
Today's linux-next build (powerpc ppc64_defconfig) failed like this:
fs/xfs/linux-2.6/xfs_export.c: In function 'xfs_fs_get_parent':
fs/xfs/linux-2.6/xfs_export.c:201: error: incompatible type for argument 1 of 'd_obtain_alias'
Due to commit 8ee6b8fff20962d17a008e230006e48c7f79ade4 ("[PATCH] switch
all filesystems over to d_obtain_alias") from the vfs tree interacting
with commit 7836dda725873a5ce05d216295a452f16ccaab72 ("[XFS] Combine the
XFS and Linux inodes") from the xfs tree.
I must admit I am wondering why I am only seeing this error at this late
stage (the xfs commit is dated October 17) ...
I fixed it up by applying the following patch (which may be incorrect).
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Mon, 20 Oct 2008 17:16:00 +1100
Subject: [PATCH] vfs/xfs: fallout from i_vnode change
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
fs/xfs/linux-2.6/xfs_export.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/xfs/linux-2.6/xfs_export.c b/fs/xfs/linux-2.6/xfs_export.c
index 263027f..dd71e86 100644
--- a/fs/xfs/linux-2.6/xfs_export.c
+++ b/fs/xfs/linux-2.6/xfs_export.c
@@ -198,7 +198,7 @@ xfs_fs_get_parent(
if (unlikely(error))
return ERR_PTR(-error);
- return d_obtain_alias(cip->i_vnode);
+ return d_obtain_alias(&cip->i_vnode);
}
const struct export_operations xfs_export_operations = {
--
1.5.6.5
next reply other threads:[~2008-10-20 6:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 6:18 Stephen Rothwell [this message]
2008-10-20 7:13 ` linux-next: vfs tree build failure Dave Chinner
2008-10-20 7:40 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2010-01-28 1:00 Stephen Rothwell
2010-01-28 1:54 ` Al Viro
2010-01-27 0:37 Stephen Rothwell
2009-05-07 3:53 Stephen Rothwell
2009-05-07 4:04 ` Al Viro
2009-04-02 2:12 Stephen Rothwell
2009-04-03 4:43 ` Stephen Rothwell
2009-04-02 1:52 Stephen Rothwell
2009-04-03 4:44 ` Stephen Rothwell
2008-10-15 6:49 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081020171830.9ece287f.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=david@fromorbit$(echo .)com \
--cc=hch@infradead$(echo .)org \
--cc=lachlan@sgi$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=viro@ZenIV$(echo .)linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox