public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Al Viro <viro@ZenIV•linux.org.uk>
Cc: linux-next@vger•kernel.org, Trond Myklebust <Trond.Myklebust@netapp•com>
Subject: linux-next: vfs tree build failure
Date: Thu, 2 Apr 2009 12:52:06 +1100	[thread overview]
Message-ID: <20090402125206.69a0cba0.sfr@canb.auug.org.au> (raw)

Hi Al,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

fs/namei.c: In function 'vfs_remote_path_lookup':
fs/namei.c:1192: error: implicit declaration of function 'put_fs_struct'

Caused by commit 498052bba55ecaff58db6a1436b0e25bfd75a7ff ("New
locking/refcounting for fs_struct") (from the vfs tree) interacting with
commit afc83ab4217a4b31cabdadd174bc3ea10b9fcb9d ("VFS: Add a VFS helper
function vfs_remote_path_lookup()") (from the nfs tree).

I applied the patch below as a merge fixup.  Please check it.
-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Thu, 2 Apr 2009 12:48:24 +1100
Subject: [PATCH] vfs: merge fix for put_fs_struct/free_fs_struct change

Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
 fs/namei.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/namei.c b/fs/namei.c
index f9656be..09680d8 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -1153,7 +1153,7 @@ int vfs_remote_path_lookup(struct dentry *dentry,
 
 	new_mnt_ns = create_private_mnt_ns(mnt, new_fs);
 	if (new_mnt_ns == NULL)
-		goto out_put_fs_struct;
+		goto out_free_fs_struct;
 
 	/* Create a private copy of current->nsproxy */
 	new_nsproxy = unshare_current_nsproxy();
@@ -1188,8 +1188,8 @@ int vfs_remote_path_lookup(struct dentry *dentry,
 out_put_mnt_ns:
 	put_mnt_ns(new_mnt_ns);
 
-out_put_fs_struct:
-	put_fs_struct(new_fs);
+out_free_fs_struct:
+	free_fs_struct(new_fs);
 out_err:
 	return error;
 }
-- 
1.6.2.1

             reply	other threads:[~2009-04-02  1:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-02  1:52 Stephen Rothwell [this message]
2009-04-03  4:44 ` linux-next: vfs tree build failure Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2010-01-28  1:00 Stephen Rothwell
2010-01-28  1:54 ` Al Viro
2010-01-27  0:37 Stephen Rothwell
2009-05-07  3:53 Stephen Rothwell
2009-05-07  4:04 ` Al Viro
2009-04-02  2:12 Stephen Rothwell
2009-04-03  4:43 ` Stephen Rothwell
2008-10-20  6:18 Stephen Rothwell
2008-10-20  7:13 ` Dave Chinner
2008-10-20  7:40   ` Christoph Hellwig
2008-10-15  6:49 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090402125206.69a0cba0.sfr@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=Trond.Myklebust@netapp$(echo .)com \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=viro@ZenIV$(echo .)linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox