From: Heiko Carstens <heiko.carstens@de•ibm.com>
To: Arjan van de Ven <arjan@linux•intel.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek•org>, linux-next@vger•kernel.org
Subject: pci_ioremap_bar() breaks s390 build
Date: Mon, 20 Oct 2008 19:45:43 +0200 [thread overview]
Message-ID: <20081020174543.GA6964@osiris.boeblingen.de.ibm.com> (raw)
Hi Arjan,
your patch "PCI: introduce an pci_ioremap(pdev, barnr) function" breaks s390:
CC fs/compat_ioctl.o
In file included from fs/compat_ioctl.c:52:
include/linux/pci.h: In function 'pci_ioremap_bar':
include/linux/pci.h:1136: error: implicit declaration of function 'ioremap_nocache'
include/linux/pci.h:1137: warning: return makes pointer from integer without a cast
make[1]: *** [fs/compat_ioctl.o] Error 1
make: *** [fs] Error 2
please fix :)
maybe something like this:
---
include/linux/pci.h | 2 ++
1 file changed, 2 insertions(+)
Index: linux-next/include/linux/pci.h
===================================================================
--- linux-next.orig/include/linux/pci.h
+++ linux-next/include/linux/pci.h
@@ -1124,6 +1124,7 @@ static inline void pci_mmcfg_early_init(
static inline void pci_mmcfg_late_init(void) { }
#endif
+#ifdef CONFIG_HAS_IOMEM
static inline void * pci_ioremap_bar(struct pci_dev *pdev, int bar)
{
/*
@@ -1136,6 +1137,7 @@ static inline void * pci_ioremap_bar(str
return ioremap_nocache(pci_resource_start(pdev, bar),
pci_resource_len(pdev, bar));
}
+#endif
#endif /* __KERNEL__ */
#endif /* LINUX_PCI_H */
next reply other threads:[~2008-10-20 17:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 17:45 Heiko Carstens [this message]
2008-10-20 17:47 ` pci_ioremap_bar() breaks s390 build Arjan van de Ven
2008-10-20 18:12 ` Jesse Barnes
2008-10-20 18:12 ` Heiko Carstens
2008-10-20 18:14 ` Jesse Barnes
2008-10-20 18:22 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081020174543.GA6964@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de$(echo .)ibm.com \
--cc=arjan@linux$(echo .)intel.com \
--cc=jbarnes@virtuousgeek$(echo .)org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox