From: Heiko Carstens <heiko.carstens@de•ibm.com>
To: Jesse Barnes <jbarnes@virtuousgeek•org>
Cc: Arjan van de Ven <arjan@linux•intel.com>, linux-next@vger•kernel.org
Subject: Re: pci_ioremap_bar() breaks s390 build
Date: Mon, 20 Oct 2008 20:22:50 +0200 [thread overview]
Message-ID: <20081020182250.GB15328@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <200810201114.55518.jbarnes@virtuousgeek.org>
On Mon, Oct 20, 2008 at 11:14:55AM -0700, Jesse Barnes wrote:
> On Monday, October 20, 2008 11:12 am Heiko Carstens wrote:
> > On Mon, Oct 20, 2008 at 10:47:41AM -0700, Arjan van de Ven wrote:
> > > Heiko Carstens wrote:
> > >> Hi Arjan,
> > >>
> > >> your patch "PCI: introduce an pci_ioremap(pdev, barnr) function" breaks
> > >> s390:
> > >>
> > >> CC fs/compat_ioctl.o
> > >> In file included from fs/compat_ioctl.c:52:
> > >> include/linux/pci.h: In function 'pci_ioremap_bar':
> > >> include/linux/pci.h:1136: error: implicit declaration of function
> > >> 'ioremap_nocache' include/linux/pci.h:1137: warning: return makes
> > >> pointer from integer without a cast make[1]: *** [fs/compat_ioctl.o]
> > >> Error 1
> > >> make: *** [fs] Error 2
> > >
> > > hmm does s390 have ioremap ?
> > > since that'd be the most useful solution, to add an ioremap_nocache().
> >
> > s390 doesn't have ioremap.
> >
> > > if it doesn't have ioremap.. wtf is it doing using pci.h then ??
> >
> > Several common code parts pull pci.h, not s390.
> > fs/compat_ioctl.c is one, drivers/scsi/scsi_lib.c is another one.
>
> Hm, well it would probably be best to fix those (maybe add some #ifdef
> CONFIG_PCI to them or somesuch), but that could get ugly. I'll go ahead and
> apply your initial patch.
Thanks! Patch was Signed-off-by: Heiko Carstens <heiko.carstens@de•ibm.com>
in case you need that.
prev parent reply other threads:[~2008-10-20 18:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 17:45 pci_ioremap_bar() breaks s390 build Heiko Carstens
2008-10-20 17:47 ` Arjan van de Ven
2008-10-20 18:12 ` Jesse Barnes
2008-10-20 18:12 ` Heiko Carstens
2008-10-20 18:14 ` Jesse Barnes
2008-10-20 18:22 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081020182250.GB15328@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de$(echo .)ibm.com \
--cc=arjan@linux$(echo .)intel.com \
--cc=jbarnes@virtuousgeek$(echo .)org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox