From: Randy Dunlap <rdunlap@xenotime•net>
To: Andrew Morton <akpm@linux-foundation•org>
Cc: linux-next@vger•kernel.org, viro@zeniv•linux.org.uk
Subject: Re: [PTCH -next] i2o: fix kernel-doc warnings
Date: Mon, 27 Oct 2008 13:58:19 -0700 [thread overview]
Message-ID: <20081027135819.84619bc7.rdunlap@xenotime.net> (raw)
In-Reply-To: <20081027131401.f2f9e535.akpm@linux-foundation.org>
On Mon, 27 Oct 2008 13:14:01 -0700
Andrew Morton <akpm@linux-foundation•org> wrote:
> On Wed, 22 Oct 2008 16:38:38 -0700
> Randy Dunlap <rdunlap@xenotime•net> wrote:
>
> > From: Randy Dunlap <randy.dunlap@oracle•com>
> >
> > Fixup i2o kernel-doc warnings:
> >
> > Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:579): No description found for parameter 'bdev'
> > Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:579): No description found for parameter 'mode'
> > Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:608): No description found for parameter 'disk'
> > Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:608): No description found for parameter 'mode'
> > Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:657): No description found for parameter 'bdev'
> > Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:657): No description found for parameter 'mode'
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
> > cc: Al Viro <viro@zeniv•linux.org.uk>
> > ---
> > drivers/message/i2o/i2o_block.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > --- linux-next-20081022.orig/drivers/message/i2o/i2o_block.c
> > +++ linux-next-20081022/drivers/message/i2o/i2o_block.c
> > @@ -567,8 +567,8 @@ static void i2o_block_biosparam(unsigned
> >
> > /**
> > * i2o_block_open - Open the block device
> > - * @inode: inode for block device being opened
> > - * @file: file to open
> > + * @bdev: block device being opened
> > + * @mode: file open mode
> > *
> > * Power up the device, mount and lock the media. This function is called,
> > * if the block device is opened for access.
> > @@ -596,8 +596,8 @@ static int i2o_block_open(struct block_d
> >
> > /**
> > * i2o_block_release - Release the I2O block device
> > - * @inode: inode for block device being released
> > - * @file: file to close
> > + * @disk: gendisk device being released
> > + * @mode: file open mode
> > *
> > * Unlock and unmount the media, and power down the device. Gets called if
> > * the block device is closed.
> > @@ -643,8 +643,8 @@ static int i2o_block_getgeo(struct block
> >
> > /**
> > * i2o_block_ioctl - Issue device specific ioctl calls.
> > - * @inode: inode for block device ioctl
> > - * @file: file for ioctl
> > + * @bdev: block device being opened
> > + * @mode: file open mode
> > * @cmd: ioctl command
> > * @arg: arg
>
> From my reading this is needed in current mainline?
True. Al's -next patch (git tree) was merged into mainline.
--
~Randy
prev parent reply other threads:[~2008-10-27 20:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 23:38 [PTCH -next] i2o: fix kernel-doc warnings Randy Dunlap
2008-10-27 20:14 ` Andrew Morton
2008-10-27 20:58 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081027135819.84619bc7.rdunlap@xenotime.net \
--to=rdunlap@xenotime$(echo .)net \
--cc=akpm@linux-foundation$(echo .)org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=viro@zeniv$(echo .)linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox