* linux-next: new warnings
@ 2008-11-06 3:25 Stephen Rothwell
2008-11-06 4:09 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2008-11-06 3:25 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-next, John W. Linville, David S. Miller
[-- Attachment #1: Type: text/plain, Size: 743 bytes --]
Hi all,
Commit 7a5158ef8da70fdedeb0530faaa8128aa645be3c ("mac80211: fix short
slot handling") added this:
/* XXX: remove all this once drivers stop trying to use it */
static inline int __deprecated __IEEE80211_CONF_SHORT_SLOT_TIME(void)
.
.
#define IEEE80211_CONF_SHORT_SLOT_TIME (__IEEE80211_CONF_SHORT_SLOT_TIME())
to include/net/mac80211.h. I was wondering if any thought was given to
getting rid of the (currently 4) in tree uses of
IEEE80211_CONF_SHORT_SLOT_TIME before doing this so that we don't have
even more new warnings from the kernel build.
The least that could be done is to clean them up now ...
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: linux-next: new warnings
2008-11-06 3:25 linux-next: new warnings Stephen Rothwell
@ 2008-11-06 4:09 ` David Miller
2008-11-06 4:30 ` Stephen Rothwell
2008-11-06 13:30 ` John W. Linville
0 siblings, 2 replies; 5+ messages in thread
From: David Miller @ 2008-11-06 4:09 UTC (permalink / raw)
To: sfr; +Cc: johannes, linux-next, linville
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Thu, 6 Nov 2008 14:25:14 +1100
> Hi all,
>
> Commit 7a5158ef8da70fdedeb0530faaa8128aa645be3c ("mac80211: fix short
> slot handling") added this:
>
> /* XXX: remove all this once drivers stop trying to use it */
> static inline int __deprecated __IEEE80211_CONF_SHORT_SLOT_TIME(void)
> .
> .
> #define IEEE80211_CONF_SHORT_SLOT_TIME (__IEEE80211_CONF_SHORT_SLOT_TIME())
>
> to include/net/mac80211.h. I was wondering if any thought was given to
> getting rid of the (currently 4) in tree uses of
> IEEE80211_CONF_SHORT_SLOT_TIME before doing this so that we don't have
> even more new warnings from the kernel build.
>
> The least that could be done is to clean them up now ...
John Linville told me that these warnings would show up because
of one of his merges and that he also has the patches pending
to get rid of them as well.
Please just ignore them for now.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: linux-next: new warnings
2008-11-06 4:09 ` David Miller
@ 2008-11-06 4:30 ` Stephen Rothwell
2008-11-06 13:30 ` John W. Linville
1 sibling, 0 replies; 5+ messages in thread
From: Stephen Rothwell @ 2008-11-06 4:30 UTC (permalink / raw)
To: David Miller; +Cc: johannes, linux-next, linville
[-- Attachment #1: Type: text/plain, Size: 451 bytes --]
Hi Dave,
On Wed, 05 Nov 2008 20:09:01 -0800 (PST) David Miller <davem@davemloft•net> wrote:
>
> John Linville told me that these warnings would show up because
> of one of his merges and that he also has the patches pending
> to get rid of them as well.
>
> Please just ignore them for now.
That's all I needed to know, thanks.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: new warnings
2008-11-06 4:09 ` David Miller
2008-11-06 4:30 ` Stephen Rothwell
@ 2008-11-06 13:30 ` John W. Linville
2008-11-06 23:38 ` Stephen Rothwell
1 sibling, 1 reply; 5+ messages in thread
From: John W. Linville @ 2008-11-06 13:30 UTC (permalink / raw)
To: David Miller; +Cc: sfr, johannes, linux-next
On Wed, Nov 05, 2008 at 08:09:01PM -0800, David Miller wrote:
> From: Stephen Rothwell <sfr@canb•auug.org.au>
> Date: Thu, 6 Nov 2008 14:25:14 +1100
>
> > Hi all,
> >
> > Commit 7a5158ef8da70fdedeb0530faaa8128aa645be3c ("mac80211: fix short
> > slot handling") added this:
> >
> > /* XXX: remove all this once drivers stop trying to use it */
> > static inline int __deprecated __IEEE80211_CONF_SHORT_SLOT_TIME(void)
> > .
> > .
> > #define IEEE80211_CONF_SHORT_SLOT_TIME (__IEEE80211_CONF_SHORT_SLOT_TIME())
> >
> > to include/net/mac80211.h. I was wondering if any thought was given to
> > getting rid of the (currently 4) in tree uses of
> > IEEE80211_CONF_SHORT_SLOT_TIME before doing this so that we don't have
> > even more new warnings from the kernel build.
> >
> > The least that could be done is to clean them up now ...
>
> John Linville told me that these warnings would show up because
> of one of his merges and that he also has the patches pending
> to get rid of them as well.
>
> Please just ignore them for now.
Yes, sorry for the delay. I've been down with pneumonia all week. :-(
John
--
John W. Linville Linux should be at the core
linville@tuxdriver•com of your literate lifestyle.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: linux-next: new warnings
2008-11-06 13:30 ` John W. Linville
@ 2008-11-06 23:38 ` Stephen Rothwell
0 siblings, 0 replies; 5+ messages in thread
From: Stephen Rothwell @ 2008-11-06 23:38 UTC (permalink / raw)
To: John W. Linville; +Cc: David Miller, johannes, linux-next
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
Hi John,
On Thu, 6 Nov 2008 08:30:02 -0500 "John W. Linville" <linville@tuxdriver•com> wrote:
>
> Yes, sorry for the delay. I've been down with pneumonia all week. :-(
That's OK, I just wanted to know that the fixes were in train.
Get better!
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-11-06 23:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-06 3:25 linux-next: new warnings Stephen Rothwell
2008-11-06 4:09 ` David Miller
2008-11-06 4:30 ` Stephen Rothwell
2008-11-06 13:30 ` John W. Linville
2008-11-06 23:38 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox