* [PATCH] use limited register constraint for setnz
@ 2008-11-25 5:42 Steven Rostedt
2008-11-25 7:22 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Steven Rostedt @ 2008-11-25 5:42 UTC (permalink / raw)
To: LKML
Cc: Ingo Molnar, Thomas Gleixner, Andrew Morton, Linus Torvalds,
Stephen Rothwell, linux-next
Impact: fix in compiling
GCC can decide to use %dil when "r" is used, which is not valid for
setnz.
This bug was brought out by Stephen Rothwell's merging of the
branch tracer into linux-next.
Signed-off-by: Steven Rostedt <srostedt@redhat•com>
diff --git a/arch/x86/boot/tty.c b/arch/x86/boot/tty.c
index 0be77b3..c2121d2 100644
--- a/arch/x86/boot/tty.c
+++ b/arch/x86/boot/tty.c
@@ -74,7 +74,7 @@ static int kbd_pending(void)
{
u8 pending;
asm volatile("int $0x16; setnz %0"
- : "=rm" (pending)
+ : "=Qm" (pending)
: "a" (0x0100));
return pending;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] use limited register constraint for setnz
2008-11-25 5:42 [PATCH] use limited register constraint for setnz Steven Rostedt
@ 2008-11-25 7:22 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-11-25 7:22 UTC (permalink / raw)
To: Steven Rostedt
Cc: LKML, Thomas Gleixner, Andrew Morton, Linus Torvalds,
Stephen Rothwell, linux-next
* Steven Rostedt <rostedt@goodmis•org> wrote:
> Impact: fix in compiling
>
> GCC can decide to use %dil when "r" is used, which is not valid for
> setnz.
>
> This bug was brought out by Stephen Rothwell's merging of the
> branch tracer into linux-next.
>
> Signed-off-by: Steven Rostedt <srostedt@redhat•com>
>
> diff --git a/arch/x86/boot/tty.c b/arch/x86/boot/tty.c
> index 0be77b3..c2121d2 100644
> --- a/arch/x86/boot/tty.c
> +++ b/arch/x86/boot/tty.c
> @@ -74,7 +74,7 @@ static int kbd_pending(void)
> {
> u8 pending;
> asm volatile("int $0x16; setnz %0"
> - : "=rm" (pending)
> + : "=Qm" (pending)
> : "a" (0x0100));
> return pending;
> }
applied to tip/x86/urgent, thanks Steve!
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-25 7:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-25 5:42 [PATCH] use limited register constraint for setnz Steven Rostedt
2008-11-25 7:22 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox