* [PATCH] powerpc: Fix cpufreq drivers after cpufreq core changes
[not found] ` <1231719015.22571.4.camel@pasglop>
@ 2009-01-12 0:22 ` Benjamin Herrenschmidt
2009-01-12 0:22 ` Benjamin Herrenschmidt
` (3 subsequent siblings)
4 siblings, 0 replies; 20+ messages in thread
From: Benjamin Herrenschmidt @ 2009-01-12 0:22 UTC (permalink / raw)
To: Linus Torvalds
Cc: Stephen Rothwell, David S. Miller, arndb, Rusty Russell, LKML,
Mike Travis, linuxppc-dev, linux-next, Paul Mackerras,
Olof Johansson, Ingo Molnar, Andrew Morton
This updates the cpufreq drivers in arch/powerpc so they build again
after the core cpufreq changes that broke them in commit
in835481d9bcd65720b473db6b38746a74a3964218.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
---
Tested on a G5. Olof, Arnd, any chance you can test the cell and pasemi
drivers still work ?
Linus, you can probably merge this now to fix the build problems.
diff --git a/arch/powerpc/platforms/cell/cbe_cpufreq.c b/arch/powerpc/platforms/cell/cbe_cpufreq.c
index ec7c8f4..e6506cd 100644
--- a/arch/powerpc/platforms/cell/cbe_cpufreq.c
+++ b/arch/powerpc/platforms/cell/cbe_cpufreq.c
@@ -118,7 +118,7 @@ static int cbe_cpufreq_cpu_init(struct cpufreq_policy *policy)
policy->cur = cbe_freqs[cur_pmode].frequency;
#ifdef CONFIG_SMP
- policy->cpus = per_cpu(cpu_sibling_map, policy->cpu);
+ cpumask_copy(policy->cpus, &per_cpu(cpu_sibling_map, policy->cpu));
#endif
cpufreq_frequency_table_get_attr(cbe_freqs, policy->cpu);
diff --git a/arch/powerpc/platforms/cell/cpufreq_spudemand.c b/arch/powerpc/platforms/cell/cpufreq_spudemand.c
index a3c6c01..968c1c0 100644
--- a/arch/powerpc/platforms/cell/cpufreq_spudemand.c
+++ b/arch/powerpc/platforms/cell/cpufreq_spudemand.c
@@ -110,7 +110,7 @@ static int spu_gov_govern(struct cpufreq_policy *policy, unsigned int event)
}
/* initialize spu_gov_info for all affected cpus */
- for_each_cpu_mask(i, policy->cpus) {
+ for_each_cpu(i, policy->cpus) {
affected_info = &per_cpu(spu_gov_info, i);
affected_info->policy = policy;
}
@@ -127,7 +127,7 @@ static int spu_gov_govern(struct cpufreq_policy *policy, unsigned int event)
spu_gov_cancel_work(info);
/* clean spu_gov_info for all affected cpus */
- for_each_cpu_mask (i, policy->cpus) {
+ for_each_cpu (i, policy->cpus) {
info = &per_cpu(spu_gov_info, i);
info->policy = NULL;
}
diff --git a/arch/powerpc/platforms/pasemi/cpufreq.c b/arch/powerpc/platforms/pasemi/cpufreq.c
index 86db47c..be2527a 100644
--- a/arch/powerpc/platforms/pasemi/cpufreq.c
+++ b/arch/powerpc/platforms/pasemi/cpufreq.c
@@ -213,7 +213,7 @@ static int pas_cpufreq_cpu_init(struct cpufreq_policy *policy)
pr_debug("current astate is at %d\n",cur_astate);
policy->cur = pas_freqs[cur_astate].frequency;
- policy->cpus = cpu_online_map;
+ cpumask_copy(policy->cpus, &cpu_online_map);
ppc_proc_freq = policy->cur * 1000ul;
diff --git a/arch/powerpc/platforms/powermac/cpufreq_64.c b/arch/powerpc/platforms/powermac/cpufreq_64.c
index 4dfb4bc..beb3833 100644
--- a/arch/powerpc/platforms/powermac/cpufreq_64.c
+++ b/arch/powerpc/platforms/powermac/cpufreq_64.c
@@ -362,7 +362,7 @@ static int g5_cpufreq_cpu_init(struct cpufreq_policy *policy)
/* secondary CPUs are tied to the primary one by the
* cpufreq core if in the secondary policy we tell it that
* it actually must be one policy together with all others. */
- policy->cpus = cpu_online_map;
+ cpumask_copy(policy->cpus, &cpu_online_map);
cpufreq_frequency_table_get_attr(g5_cpu_freqs, policy->cpu);
return cpufreq_frequency_table_cpuinfo(policy,
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH] powerpc: Fix cpufreq drivers after cpufreq core changes
[not found] ` <1231719015.22571.4.camel@pasglop>
2009-01-12 0:22 ` [PATCH] powerpc: Fix cpufreq drivers after cpufreq core changes Benjamin Herrenschmidt
@ 2009-01-12 0:22 ` Benjamin Herrenschmidt
2009-01-12 0:22 ` Benjamin Herrenschmidt
` (2 subsequent siblings)
4 siblings, 0 replies; 20+ messages in thread
From: Benjamin Herrenschmidt @ 2009-01-12 0:22 UTC (permalink / raw)
To: Linus Torvalds
Cc: Stephen Rothwell, linux-next, Rusty Russell, Mike Travis,
Ingo Molnar, Andrew Morton, David S. Miller, LKML, Paul Mackerras,
linuxppc-dev, Olof Johansson, arndb
This updates the cpufreq drivers in arch/powerpc so they build again
after the core cpufreq changes that broke them in commit
in835481d9bcd65720b473db6b38746a74a3964218.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
---
Tested on a G5. Olof, Arnd, any chance you can test the cell and pasemi
drivers still work ?
Linus, you can probably merge this now to fix the build problems.
diff --git a/arch/powerpc/platforms/cell/cbe_cpufreq.c b/arch/powerpc/platforms/cell/cbe_cpufreq.c
index ec7c8f4..e6506cd 100644
--- a/arch/powerpc/platforms/cell/cbe_cpufreq.c
+++ b/arch/powerpc/platforms/cell/cbe_cpufreq.c
@@ -118,7 +118,7 @@ static int cbe_cpufreq_cpu_init(struct cpufreq_policy *policy)
policy->cur = cbe_freqs[cur_pmode].frequency;
#ifdef CONFIG_SMP
- policy->cpus = per_cpu(cpu_sibling_map, policy->cpu);
+ cpumask_copy(policy->cpus, &per_cpu(cpu_sibling_map, policy->cpu));
#endif
cpufreq_frequency_table_get_attr(cbe_freqs, policy->cpu);
diff --git a/arch/powerpc/platforms/cell/cpufreq_spudemand.c b/arch/powerpc/platforms/cell/cpufreq_spudemand.c
index a3c6c01..968c1c0 100644
--- a/arch/powerpc/platforms/cell/cpufreq_spudemand.c
+++ b/arch/powerpc/platforms/cell/cpufreq_spudemand.c
@@ -110,7 +110,7 @@ static int spu_gov_govern(struct cpufreq_policy *policy, unsigned int event)
}
/* initialize spu_gov_info for all affected cpus */
- for_each_cpu_mask(i, policy->cpus) {
+ for_each_cpu(i, policy->cpus) {
affected_info = &per_cpu(spu_gov_info, i);
affected_info->policy = policy;
}
@@ -127,7 +127,7 @@ static int spu_gov_govern(struct cpufreq_policy *policy, unsigned int event)
spu_gov_cancel_work(info);
/* clean spu_gov_info for all affected cpus */
- for_each_cpu_mask (i, policy->cpus) {
+ for_each_cpu (i, policy->cpus) {
info = &per_cpu(spu_gov_info, i);
info->policy = NULL;
}
diff --git a/arch/powerpc/platforms/pasemi/cpufreq.c b/arch/powerpc/platforms/pasemi/cpufreq.c
index 86db47c..be2527a 100644
--- a/arch/powerpc/platforms/pasemi/cpufreq.c
+++ b/arch/powerpc/platforms/pasemi/cpufreq.c
@@ -213,7 +213,7 @@ static int pas_cpufreq_cpu_init(struct cpufreq_policy *policy)
pr_debug("current astate is at %d\n",cur_astate);
policy->cur = pas_freqs[cur_astate].frequency;
- policy->cpus = cpu_online_map;
+ cpumask_copy(policy->cpus, &cpu_online_map);
ppc_proc_freq = policy->cur * 1000ul;
diff --git a/arch/powerpc/platforms/powermac/cpufreq_64.c b/arch/powerpc/platforms/powermac/cpufreq_64.c
index 4dfb4bc..beb3833 100644
--- a/arch/powerpc/platforms/powermac/cpufreq_64.c
+++ b/arch/powerpc/platforms/powermac/cpufreq_64.c
@@ -362,7 +362,7 @@ static int g5_cpufreq_cpu_init(struct cpufreq_policy *policy)
/* secondary CPUs are tied to the primary one by the
* cpufreq core if in the secondary policy we tell it that
* it actually must be one policy together with all others. */
- policy->cpus = cpu_online_map;
+ cpumask_copy(policy->cpus, &cpu_online_map);
cpufreq_frequency_table_get_attr(g5_cpu_freqs, policy->cpu);
return cpufreq_frequency_table_cpuinfo(policy,
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH] powerpc: Fix cpufreq drivers after cpufreq core changes
[not found] ` <1231719015.22571.4.camel@pasglop>
2009-01-12 0:22 ` [PATCH] powerpc: Fix cpufreq drivers after cpufreq core changes Benjamin Herrenschmidt
2009-01-12 0:22 ` Benjamin Herrenschmidt
@ 2009-01-12 0:22 ` Benjamin Herrenschmidt
[not found] ` <1231719721.22571.9.camel@pasglop>
2009-01-12 9:05 ` linux-next: origin tree build failure Ingo Molnar
4 siblings, 0 replies; 20+ messages in thread
From: Benjamin Herrenschmidt @ 2009-01-12 0:22 UTC (permalink / raw)
To: Linus Torvalds
Cc: Stephen Rothwell, linux-next, Rusty Russell, Mike Travis,
Ingo Molnar, Andrew Morton, David S. Miller, LKML, Paul Mackerras,
linuxppc-dev, Olof Johansson, arndb
This updates the cpufreq drivers in arch/powerpc so they build again
after the core cpufreq changes that broke them in commit
in835481d9bcd65720b473db6b38746a74a3964218.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
---
Tested on a G5. Olof, Arnd, any chance you can test the cell and pasemi
drivers still work ?
Linus, you can probably merge this now to fix the build problems.
diff --git a/arch/powerpc/platforms/cell/cbe_cpufreq.c b/arch/powerpc/platforms/cell/cbe_cpufreq.c
index ec7c8f4..e6506cd 100644
--- a/arch/powerpc/platforms/cell/cbe_cpufreq.c
+++ b/arch/powerpc/platforms/cell/cbe_cpufreq.c
@@ -118,7 +118,7 @@ static int cbe_cpufreq_cpu_init(struct cpufreq_policy *policy)
policy->cur = cbe_freqs[cur_pmode].frequency;
#ifdef CONFIG_SMP
- policy->cpus = per_cpu(cpu_sibling_map, policy->cpu);
+ cpumask_copy(policy->cpus, &per_cpu(cpu_sibling_map, policy->cpu));
#endif
cpufreq_frequency_table_get_attr(cbe_freqs, policy->cpu);
diff --git a/arch/powerpc/platforms/cell/cpufreq_spudemand.c b/arch/powerpc/platforms/cell/cpufreq_spudemand.c
index a3c6c01..968c1c0 100644
--- a/arch/powerpc/platforms/cell/cpufreq_spudemand.c
+++ b/arch/powerpc/platforms/cell/cpufreq_spudemand.c
@@ -110,7 +110,7 @@ static int spu_gov_govern(struct cpufreq_policy *policy, unsigned int event)
}
/* initialize spu_gov_info for all affected cpus */
- for_each_cpu_mask(i, policy->cpus) {
+ for_each_cpu(i, policy->cpus) {
affected_info = &per_cpu(spu_gov_info, i);
affected_info->policy = policy;
}
@@ -127,7 +127,7 @@ static int spu_gov_govern(struct cpufreq_policy *policy, unsigned int event)
spu_gov_cancel_work(info);
/* clean spu_gov_info for all affected cpus */
- for_each_cpu_mask (i, policy->cpus) {
+ for_each_cpu (i, policy->cpus) {
info = &per_cpu(spu_gov_info, i);
info->policy = NULL;
}
diff --git a/arch/powerpc/platforms/pasemi/cpufreq.c b/arch/powerpc/platforms/pasemi/cpufreq.c
index 86db47c..be2527a 100644
--- a/arch/powerpc/platforms/pasemi/cpufreq.c
+++ b/arch/powerpc/platforms/pasemi/cpufreq.c
@@ -213,7 +213,7 @@ static int pas_cpufreq_cpu_init(struct cpufreq_policy *policy)
pr_debug("current astate is at %d\n",cur_astate);
policy->cur = pas_freqs[cur_astate].frequency;
- policy->cpus = cpu_online_map;
+ cpumask_copy(policy->cpus, &cpu_online_map);
ppc_proc_freq = policy->cur * 1000ul;
diff --git a/arch/powerpc/platforms/powermac/cpufreq_64.c b/arch/powerpc/platforms/powermac/cpufreq_64.c
index 4dfb4bc..beb3833 100644
--- a/arch/powerpc/platforms/powermac/cpufreq_64.c
+++ b/arch/powerpc/platforms/powermac/cpufreq_64.c
@@ -362,7 +362,7 @@ static int g5_cpufreq_cpu_init(struct cpufreq_policy *policy)
/* secondary CPUs are tied to the primary one by the
* cpufreq core if in the secondary policy we tell it that
* it actually must be one policy together with all others. */
- policy->cpus = cpu_online_map;
+ cpumask_copy(policy->cpus, &cpu_online_map);
cpufreq_frequency_table_get_attr(g5_cpu_freqs, policy->cpu);
return cpufreq_frequency_table_cpuinfo(policy,
^ permalink raw reply related [flat|nested] 20+ messages in thread[parent not found: <1231719721.22571.9.camel@pasglop>]
* Re: [PATCH] powerpc: Fix cpufreq drivers after cpufreq core changes
[not found] ` <1231719721.22571.9.camel@pasglop>
@ 2009-01-12 8:34 ` Ingo Molnar
2009-01-12 21:45 ` Benjamin Herrenschmidt
` (2 more replies)
2009-01-12 17:44 ` Olof Johansson
2009-01-12 17:44 ` Olof Johansson
2 siblings, 3 replies; 20+ messages in thread
From: Ingo Molnar @ 2009-01-12 8:34 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Linus Torvalds, Stephen Rothwell, linux-next, Rusty Russell,
Mike Travis, Andrew Morton, David S. Miller, LKML, Paul Mackerras,
linuxppc-dev, Olof Johansson, arndb
* Benjamin Herrenschmidt <benh@kernel•crashing.org> wrote:
> This updates the cpufreq drivers in arch/powerpc so they build again
> after the core cpufreq changes that broke them in commit
> in835481d9bcd65720b473db6b38746a74a3964218.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> ---
>
> Tested on a G5. Olof, Arnd, any chance you can test the cell and pasemi
> drivers still work ?
>
> Linus, you can probably merge this now to fix the build problems.
Thanks Ben!
The powerpc defconfig built fine - you might wan to turn on cpufreq in the
powerpc defconfig so that cross-build tests can catch problems like this.
Ingo
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] powerpc: Fix cpufreq drivers after cpufreq core changes
2009-01-12 8:34 ` Ingo Molnar
@ 2009-01-12 21:45 ` Benjamin Herrenschmidt
2009-01-12 21:45 ` Benjamin Herrenschmidt
2009-01-12 21:45 ` Benjamin Herrenschmidt
2 siblings, 0 replies; 20+ messages in thread
From: Benjamin Herrenschmidt @ 2009-01-12 21:45 UTC (permalink / raw)
To: Ingo Molnar
Cc: Stephen Rothwell, arndb, Rusty Russell, LKML, Mike Travis,
linuxppc-dev, linux-next, Paul Mackerras, Olof Johansson,
Andrew Morton, Linus Torvalds, David S. Miller
On Mon, 2009-01-12 at 09:34 +0100, Ingo Molnar wrote:
> * Benjamin Herrenschmidt <benh@kernel•crashing.org> wrote:
>
> > This updates the cpufreq drivers in arch/powerpc so they build again
> > after the core cpufreq changes that broke them in commit
> > in835481d9bcd65720b473db6b38746a74a3964218.
> >
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> > ---
> >
> > Tested on a G5. Olof, Arnd, any chance you can test the cell and pasemi
> > drivers still work ?
> >
> > Linus, you can probably merge this now to fix the build problems.
>
> Thanks Ben!
>
> The powerpc defconfig built fine - you might wan to turn on cpufreq in the
> powerpc defconfig so that cross-build tests can catch problems like this.
Hrm... which config are you using ? ppc64_defconfig has them all on.
Cheers,
Ben.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] powerpc: Fix cpufreq drivers after cpufreq core changes
2009-01-12 8:34 ` Ingo Molnar
2009-01-12 21:45 ` Benjamin Herrenschmidt
@ 2009-01-12 21:45 ` Benjamin Herrenschmidt
2009-01-12 21:45 ` Benjamin Herrenschmidt
2 siblings, 0 replies; 20+ messages in thread
From: Benjamin Herrenschmidt @ 2009-01-12 21:45 UTC (permalink / raw)
To: Ingo Molnar
Cc: Linus Torvalds, Stephen Rothwell, linux-next, Rusty Russell,
Mike Travis, Andrew Morton, David S. Miller, LKML, Paul Mackerras,
linuxppc-dev, Olof Johansson, arndb
On Mon, 2009-01-12 at 09:34 +0100, Ingo Molnar wrote:
> * Benjamin Herrenschmidt <benh@kernel•crashing.org> wrote:
>
> > This updates the cpufreq drivers in arch/powerpc so they build again
> > after the core cpufreq changes that broke them in commit
> > in835481d9bcd65720b473db6b38746a74a3964218.
> >
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> > ---
> >
> > Tested on a G5. Olof, Arnd, any chance you can test the cell and pasemi
> > drivers still work ?
> >
> > Linus, you can probably merge this now to fix the build problems.
>
> Thanks Ben!
>
> The powerpc defconfig built fine - you might wan to turn on cpufreq in the
> powerpc defconfig so that cross-build tests can catch problems like this.
Hrm... which config are you using ? ppc64_defconfig has them all on.
Cheers,
Ben.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] powerpc: Fix cpufreq drivers after cpufreq core changes
2009-01-12 8:34 ` Ingo Molnar
2009-01-12 21:45 ` Benjamin Herrenschmidt
2009-01-12 21:45 ` Benjamin Herrenschmidt
@ 2009-01-12 21:45 ` Benjamin Herrenschmidt
2 siblings, 0 replies; 20+ messages in thread
From: Benjamin Herrenschmidt @ 2009-01-12 21:45 UTC (permalink / raw)
To: Ingo Molnar
Cc: Linus Torvalds, Stephen Rothwell, linux-next, Rusty Russell,
Mike Travis, Andrew Morton, David S. Miller, LKML, Paul Mackerras,
linuxppc-dev, Olof Johansson, arndb
On Mon, 2009-01-12 at 09:34 +0100, Ingo Molnar wrote:
> * Benjamin Herrenschmidt <benh@kernel•crashing.org> wrote:
>
> > This updates the cpufreq drivers in arch/powerpc so they build again
> > after the core cpufreq changes that broke them in commit
> > in835481d9bcd65720b473db6b38746a74a3964218.
> >
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> > ---
> >
> > Tested on a G5. Olof, Arnd, any chance you can test the cell and pasemi
> > drivers still work ?
> >
> > Linus, you can probably merge this now to fix the build problems.
>
> Thanks Ben!
>
> The powerpc defconfig built fine - you might wan to turn on cpufreq in the
> powerpc defconfig so that cross-build tests can catch problems like this.
Hrm... which config are you using ? ppc64_defconfig has them all on.
Cheers,
Ben.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] powerpc: Fix cpufreq drivers after cpufreq core changes
[not found] ` <1231719721.22571.9.camel@pasglop>
2009-01-12 8:34 ` Ingo Molnar
@ 2009-01-12 17:44 ` Olof Johansson
2009-01-12 17:44 ` Olof Johansson
2 siblings, 0 replies; 20+ messages in thread
From: Olof Johansson @ 2009-01-12 17:44 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Linus Torvalds, Stephen Rothwell, linux-next, Rusty Russell,
Mike Travis, Ingo Molnar, Andrew Morton, David S. Miller, LKML,
Paul Mackerras, linuxppc-dev, arndb
On Mon, Jan 12, 2009 at 11:22:01AM +1100, Benjamin Herrenschmidt wrote:
> This updates the cpufreq drivers in arch/powerpc so they build again
> after the core cpufreq changes that broke them in commit
> in835481d9bcd65720b473db6b38746a74a3964218.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> ---
>
> Tested on a G5. Olof, Arnd, any chance you can test the cell and pasemi
> drivers still work ?
Tested fine on pasemi.
-Olof
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] powerpc: Fix cpufreq drivers after cpufreq core changes
[not found] ` <1231719721.22571.9.camel@pasglop>
2009-01-12 8:34 ` Ingo Molnar
2009-01-12 17:44 ` Olof Johansson
@ 2009-01-12 17:44 ` Olof Johansson
2 siblings, 0 replies; 20+ messages in thread
From: Olof Johansson @ 2009-01-12 17:44 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Linus Torvalds, Stephen Rothwell, linux-next, Rusty Russell,
Mike Travis, Ingo Molnar, Andrew Morton, David S. Miller, LKML,
Paul Mackerras, linuxppc-dev, arndb
On Mon, Jan 12, 2009 at 11:22:01AM +1100, Benjamin Herrenschmidt wrote:
> This updates the cpufreq drivers in arch/powerpc so they build again
> after the core cpufreq changes that broke them in commit
> in835481d9bcd65720b473db6b38746a74a3964218.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> ---
>
> Tested on a G5. Olof, Arnd, any chance you can test the cell and pasemi
> drivers still work ?
Tested fine on pasemi.
-Olof
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: linux-next: origin tree build failure
[not found] ` <1231719015.22571.4.camel@pasglop>
` (3 preceding siblings ...)
[not found] ` <1231719721.22571.9.camel@pasglop>
@ 2009-01-12 9:05 ` Ingo Molnar
2009-01-12 9:24 ` Stephen Rothwell
2009-01-12 9:49 ` Michael Ellerman
4 siblings, 2 replies; 20+ messages in thread
From: Ingo Molnar @ 2009-01-12 9:05 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Stephen Rothwell, Linus Torvalds, linux-next, Rusty Russell,
Mike Travis, Andrew Morton, David S. Miller, LKML, Paul Mackerras,
linuxppc-dev
* Benjamin Herrenschmidt <benh@kernel•crashing.org> wrote:
> On Mon, 2009-01-12 at 10:48 +1100, Stephen Rothwell wrote:
> > Hi Linus,
> >
> > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> >
> > arch/powerpc/platforms/pasemi/cpufreq.c: In function 'pas_cpufreq_cpu_init':
> > arch/powerpc/platforms/pasemi/cpufreq.c:216: error: incompatible types in assignment
> > arch/powerpc/platforms/powermac/cpufreq_64.c: In function 'g5_cpufreq_cpu_init':
> > arch/powerpc/platforms/powermac/cpufreq_64.c:365: error: incompatible types in assignment
> > arch/powerpc/platforms/cell/cbe_cpufreq.c: In function 'cbe_cpufreq_cpu_init':
> > arch/powerpc/platforms/cell/cbe_cpufreq.c:121: error: incompatible types in assignment
> >
> > Caused by commit 835481d9bcd65720b473db6b38746a74a3964218 ("cpumask:
> > convert struct cpufreq_policy to cpumask_var_t") which missed updating
> > all the powerpc (at least) cpufreq drivers.
>
> Yeah, it only updates x86 it seems ...
Yeah - and that build bug was stupid too - when touching a generic file
that is called include/linux/cpufreq.h and changing a key data field one
should at minimum get the idea that it's generic for a reason and should
start grepping the tree ...
It slipped through because it didnt get caught in build tests because
cpufreq isnt enabled in the powerpc defconfig.
Ingo
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: linux-next: origin tree build failure
2009-01-12 9:05 ` linux-next: origin tree build failure Ingo Molnar
@ 2009-01-12 9:24 ` Stephen Rothwell
2009-01-12 9:32 ` Ingo Molnar
2009-01-12 9:49 ` Michael Ellerman
1 sibling, 1 reply; 20+ messages in thread
From: Stephen Rothwell @ 2009-01-12 9:24 UTC (permalink / raw)
To: Ingo Molnar
Cc: Benjamin Herrenschmidt, Linus Torvalds, linux-next, Rusty Russell,
Mike Travis, Andrew Morton, David S. Miller, LKML, Paul Mackerras,
linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 811 bytes --]
Hi Ingo,
On Mon, 12 Jan 2009 10:05:52 +0100 Ingo Molnar <mingo@elte•hu> wrote:
>
> Yeah - and that build bug was stupid too - when touching a generic file
> that is called include/linux/cpufreq.h and changing a key data field one
> should at minimum get the idea that it's generic for a reason and should
> start grepping the tree ...
>
> It slipped through because it didnt get caught in build tests because
> cpufreq isnt enabled in the powerpc defconfig.
Which is one of the reasons we have linux-next: "integration testing".
This way not every developer/maintainer has to have/use cross compilers
for every (or even many) non-native (from their point of view)
architectures.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: linux-next: origin tree build failure
2009-01-12 9:24 ` Stephen Rothwell
@ 2009-01-12 9:32 ` Ingo Molnar
2009-01-13 16:31 ` Stephen Rothwell
0 siblings, 1 reply; 20+ messages in thread
From: Ingo Molnar @ 2009-01-12 9:32 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Benjamin Herrenschmidt, Linus Torvalds, linux-next, Rusty Russell,
Mike Travis, Andrew Morton, David S. Miller, LKML, Paul Mackerras,
linuxppc-dev
* Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> > It slipped through because it didnt get caught in build tests because
> > cpufreq isnt enabled in the powerpc defconfig.
>
> Which is one of the reasons we have linux-next: "integration testing".
Build bugs slipped through that net too in the past.
And we dont really want developers and maintainers to rely on an external
middle man facility to be able to submit patches. So the best method is to
make the defconfigs good enough to catch everyday build bugs. Random
testing and linux-next can then catch the weird special cases as well.
Ingo
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: linux-next: origin tree build failure
2009-01-12 9:32 ` Ingo Molnar
@ 2009-01-13 16:31 ` Stephen Rothwell
0 siblings, 0 replies; 20+ messages in thread
From: Stephen Rothwell @ 2009-01-13 16:31 UTC (permalink / raw)
To: Ingo Molnar
Cc: Benjamin Herrenschmidt, Linus Torvalds, linux-next, Rusty Russell,
Mike Travis, Andrew Morton, David S. Miller, LKML, Paul Mackerras,
linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 933 bytes --]
Hi Ingo,
On Mon, 12 Jan 2009 10:32:14 +0100 Ingo Molnar <mingo@elte•hu> wrote:
>
> * Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> > > It slipped through because it didnt get caught in build tests because
> > > cpufreq isnt enabled in the powerpc defconfig.
> >
> > Which is one of the reasons we have linux-next: "integration testing".
>
> Build bugs slipped through that net too in the past.
Of course they have.
> And we dont really want developers and maintainers to rely on an external
> middle man facility to be able to submit patches. So the best method is to
> make the defconfigs good enough to catch everyday build bugs. Random
> testing and linux-next can then catch the weird special cases as well.
linux-next is merely a tool - it can't catch anything if you don't use it.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: linux-next: origin tree build failure
2009-01-12 9:05 ` linux-next: origin tree build failure Ingo Molnar
2009-01-12 9:24 ` Stephen Rothwell
@ 2009-01-12 9:49 ` Michael Ellerman
2009-01-12 10:44 ` Ingo Molnar
` (2 more replies)
1 sibling, 3 replies; 20+ messages in thread
From: Michael Ellerman @ 2009-01-12 9:49 UTC (permalink / raw)
To: Ingo Molnar
Cc: Benjamin Herrenschmidt, Stephen Rothwell, Rusty Russell, LKML,
Mike Travis, linuxppc-dev, linux-next, Paul Mackerras,
Andrew Morton, Linus Torvalds, David S. Miller
[-- Attachment #1: Type: text/plain, Size: 1907 bytes --]
On Mon, 2009-01-12 at 10:05 +0100, Ingo Molnar wrote:
> * Benjamin Herrenschmidt <benh@kernel•crashing.org> wrote:
>
> > On Mon, 2009-01-12 at 10:48 +1100, Stephen Rothwell wrote:
> > > Hi Linus,
> > >
> > > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> > >
> > > arch/powerpc/platforms/pasemi/cpufreq.c: In function 'pas_cpufreq_cpu_init':
> > > arch/powerpc/platforms/pasemi/cpufreq.c:216: error: incompatible types in assignment
> > > arch/powerpc/platforms/powermac/cpufreq_64.c: In function 'g5_cpufreq_cpu_init':
> > > arch/powerpc/platforms/powermac/cpufreq_64.c:365: error: incompatible types in assignment
> > > arch/powerpc/platforms/cell/cbe_cpufreq.c: In function 'cbe_cpufreq_cpu_init':
> > > arch/powerpc/platforms/cell/cbe_cpufreq.c:121: error: incompatible types in assignment
> > >
> > > Caused by commit 835481d9bcd65720b473db6b38746a74a3964218 ("cpumask:
> > > convert struct cpufreq_policy to cpumask_var_t") which missed updating
> > > all the powerpc (at least) cpufreq drivers.
> >
> > Yeah, it only updates x86 it seems ...
>
> Yeah - and that build bug was stupid too - when touching a generic file
> that is called include/linux/cpufreq.h and changing a key data field one
> should at minimum get the idea that it's generic for a reason and should
> start grepping the tree ...
>
> It slipped through because it didnt get caught in build tests because
> cpufreq isnt enabled in the powerpc defconfig.
Which defconfig?
powerpc(master) $ git grep CPU_FREQ=y arch/powerpc/configs/ppc64_defconfig
arch/powerpc/configs/ppc64_defconfig:CONFIG_CPU_FREQ=y
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: linux-next: origin tree build failure
2009-01-12 9:49 ` Michael Ellerman
@ 2009-01-12 10:44 ` Ingo Molnar
2009-01-12 10:44 ` Ingo Molnar
2009-01-12 10:44 ` Ingo Molnar
2 siblings, 0 replies; 20+ messages in thread
From: Ingo Molnar @ 2009-01-12 10:44 UTC (permalink / raw)
To: Michael Ellerman
Cc: Benjamin Herrenschmidt, Stephen Rothwell, Rusty Russell, LKML,
Mike Travis, linuxppc-dev, linux-next, Paul Mackerras,
Andrew Morton, Linus Torvalds, David S. Miller
* Michael Ellerman <michael@ellerman•id.au> wrote:
> On Mon, 2009-01-12 at 10:05 +0100, Ingo Molnar wrote:
> > * Benjamin Herrenschmidt <benh@kernel•crashing.org> wrote:
> >
> > > On Mon, 2009-01-12 at 10:48 +1100, Stephen Rothwell wrote:
> > > > Hi Linus,
> > > >
> > > > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> > > >
> > > > arch/powerpc/platforms/pasemi/cpufreq.c: In function 'pas_cpufreq_cpu_init':
> > > > arch/powerpc/platforms/pasemi/cpufreq.c:216: error: incompatible types in assignment
> > > > arch/powerpc/platforms/powermac/cpufreq_64.c: In function 'g5_cpufreq_cpu_init':
> > > > arch/powerpc/platforms/powermac/cpufreq_64.c:365: error: incompatible types in assignment
> > > > arch/powerpc/platforms/cell/cbe_cpufreq.c: In function 'cbe_cpufreq_cpu_init':
> > > > arch/powerpc/platforms/cell/cbe_cpufreq.c:121: error: incompatible types in assignment
> > > >
> > > > Caused by commit 835481d9bcd65720b473db6b38746a74a3964218 ("cpumask:
> > > > convert struct cpufreq_policy to cpumask_var_t") which missed updating
> > > > all the powerpc (at least) cpufreq drivers.
> > >
> > > Yeah, it only updates x86 it seems ...
> >
> > Yeah - and that build bug was stupid too - when touching a generic file
> > that is called include/linux/cpufreq.h and changing a key data field one
> > should at minimum get the idea that it's generic for a reason and should
> > start grepping the tree ...
> >
> > It slipped through because it didnt get caught in build tests because
> > cpufreq isnt enabled in the powerpc defconfig.
>
> Which defconfig?
>
> powerpc(master) $ git grep CPU_FREQ=y arch/powerpc/configs/ppc64_defconfig
> arch/powerpc/configs/ppc64_defconfig:CONFIG_CPU_FREQ=y
ah, indeed - you are right.
Ingo
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: linux-next: origin tree build failure
2009-01-12 9:49 ` Michael Ellerman
2009-01-12 10:44 ` Ingo Molnar
@ 2009-01-12 10:44 ` Ingo Molnar
2009-01-12 10:44 ` Ingo Molnar
2 siblings, 0 replies; 20+ messages in thread
From: Ingo Molnar @ 2009-01-12 10:44 UTC (permalink / raw)
To: Michael Ellerman
Cc: Stephen Rothwell, Rusty Russell, LKML, Mike Travis, linuxppc-dev,
linux-next, Paul Mackerras, Andrew Morton, Linus Torvalds,
David S. Miller
* Michael Ellerman <michael@ellerman•id.au> wrote:
> On Mon, 2009-01-12 at 10:05 +0100, Ingo Molnar wrote:
> > * Benjamin Herrenschmidt <benh@kernel•crashing.org> wrote:
> >
> > > On Mon, 2009-01-12 at 10:48 +1100, Stephen Rothwell wrote:
> > > > Hi Linus,
> > > >
> > > > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> > > >
> > > > arch/powerpc/platforms/pasemi/cpufreq.c: In function 'pas_cpufreq_cpu_init':
> > > > arch/powerpc/platforms/pasemi/cpufreq.c:216: error: incompatible types in assignment
> > > > arch/powerpc/platforms/powermac/cpufreq_64.c: In function 'g5_cpufreq_cpu_init':
> > > > arch/powerpc/platforms/powermac/cpufreq_64.c:365: error: incompatible types in assignment
> > > > arch/powerpc/platforms/cell/cbe_cpufreq.c: In function 'cbe_cpufreq_cpu_init':
> > > > arch/powerpc/platforms/cell/cbe_cpufreq.c:121: error: incompatible types in assignment
> > > >
> > > > Caused by commit 835481d9bcd65720b473db6b38746a74a3964218 ("cpumask:
> > > > convert struct cpufreq_policy to cpumask_var_t") which missed updating
> > > > all the powerpc (at least) cpufreq drivers.
> > >
> > > Yeah, it only updates x86 it seems ...
> >
> > Yeah - and that build bug was stupid too - when touching a generic file
> > that is called include/linux/cpufreq.h and changing a key data field one
> > should at minimum get the idea that it's generic for a reason and should
> > start grepping the tree ...
> >
> > It slipped through because it didnt get caught in build tests because
> > cpufreq isnt enabled in the powerpc defconfig.
>
> Which defconfig?
>
> powerpc(master) $ git grep CPU_FREQ=y arch/powerpc/configs/ppc64_defconfig
> arch/powerpc/configs/ppc64_defconfig:CONFIG_CPU_FREQ=y
ah, indeed - you are right.
Ingo
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: linux-next: origin tree build failure
2009-01-12 9:49 ` Michael Ellerman
2009-01-12 10:44 ` Ingo Molnar
2009-01-12 10:44 ` Ingo Molnar
@ 2009-01-12 10:44 ` Ingo Molnar
2 siblings, 0 replies; 20+ messages in thread
From: Ingo Molnar @ 2009-01-12 10:44 UTC (permalink / raw)
To: Michael Ellerman
Cc: Benjamin Herrenschmidt, Stephen Rothwell, Rusty Russell, LKML,
Mike Travis, linuxppc-dev, linux-next, Paul Mackerras,
Andrew Morton, Linus Torvalds, David S. Miller
* Michael Ellerman <michael@ellerman•id.au> wrote:
> On Mon, 2009-01-12 at 10:05 +0100, Ingo Molnar wrote:
> > * Benjamin Herrenschmidt <benh@kernel•crashing.org> wrote:
> >
> > > On Mon, 2009-01-12 at 10:48 +1100, Stephen Rothwell wrote:
> > > > Hi Linus,
> > > >
> > > > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> > > >
> > > > arch/powerpc/platforms/pasemi/cpufreq.c: In function 'pas_cpufreq_cpu_init':
> > > > arch/powerpc/platforms/pasemi/cpufreq.c:216: error: incompatible types in assignment
> > > > arch/powerpc/platforms/powermac/cpufreq_64.c: In function 'g5_cpufreq_cpu_init':
> > > > arch/powerpc/platforms/powermac/cpufreq_64.c:365: error: incompatible types in assignment
> > > > arch/powerpc/platforms/cell/cbe_cpufreq.c: In function 'cbe_cpufreq_cpu_init':
> > > > arch/powerpc/platforms/cell/cbe_cpufreq.c:121: error: incompatible types in assignment
> > > >
> > > > Caused by commit 835481d9bcd65720b473db6b38746a74a3964218 ("cpumask:
> > > > convert struct cpufreq_policy to cpumask_var_t") which missed updating
> > > > all the powerpc (at least) cpufreq drivers.
> > >
> > > Yeah, it only updates x86 it seems ...
> >
> > Yeah - and that build bug was stupid too - when touching a generic file
> > that is called include/linux/cpufreq.h and changing a key data field one
> > should at minimum get the idea that it's generic for a reason and should
> > start grepping the tree ...
> >
> > It slipped through because it didnt get caught in build tests because
> > cpufreq isnt enabled in the powerpc defconfig.
>
> Which defconfig?
>
> powerpc(master) $ git grep CPU_FREQ=y arch/powerpc/configs/ppc64_defconfig
> arch/powerpc/configs/ppc64_defconfig:CONFIG_CPU_FREQ=y
ah, indeed - you are right.
Ingo
^ permalink raw reply [flat|nested] 20+ messages in thread