From: Heiko Carstens <heiko.carstens@de•ibm.com>
To: Catalin Marinas <catalin.marinas@arm•com>
Cc: Kamalesh Babulal <kamalesh@linux•vnet.ibm.com>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
linux-s390@vger•kernel.org, schwidefsky@de•ibm.com,
penberg@cs•helsinki.fi
Subject: Re: [BUILD_FAILURE] next-20090115 - s390x - mm/kmemleak.c
Date: Thu, 15 Jan 2009 13:05:26 +0100 [thread overview]
Message-ID: <20090115120526.GD5093@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <1232020540.32016.19.camel@pc1117.cambridge.arm.com>
On Thu, Jan 15, 2009 at 11:55:40AM +0000, Catalin Marinas wrote:
> On Thu, 2009-01-15 at 12:20 +0100, Heiko Carstens wrote:
> > On Thu, Jan 15, 2009 at 04:05:04PM +0530, Kamalesh Babulal wrote:
> > > Hi Stephen,
> > >
> > > next-20090115 allyesconfig build fails on s390x
> > >
> > > mm/built-in.o: In function `kmemleak_scan':
> > > mm/kmemleak.c:977: undefined reference to `_sdata'
> > > make: *** [.tmp_vmlinux1] Error 1
> >
> > A lot of architectures don't have _sdata definined in their linker scripts.
> > On s390 _sdata would be the same as _etext. But that is not necessarily true
> > for all architectures.
>
> Kmemleak has only been tested on ARM and x86. I can add patches for the
> other architectures so that the compilation is fine but can't really run
> such kernels.
That would be nice. Fixing it so that it actually works (_if_ it does not)
can still be done later.
Btw. you have
/*
* Stop the automatic memory scanning thread. This function must be called
* with the kmemleak_mutex held.
*/
void stop_scan_thread(void)
{
...
but call the function unlocked from kmemleak_write. Looks like a bug ;)
next prev parent reply other threads:[~2009-01-15 12:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-15 6:04 linux-next: Tree for January 15 Stephen Rothwell
2009-01-15 10:35 ` [BUILD_FAILURE] next-20090115 - s390x - mm/kmemleak.c Kamalesh Babulal
2009-01-15 11:20 ` Heiko Carstens
2009-01-15 11:55 ` Catalin Marinas
2009-01-15 12:05 ` Heiko Carstens [this message]
2009-01-15 17:00 ` Catalin Marinas
2009-01-15 12:08 ` Pekka Enberg
2009-01-15 12:13 ` Heiko Carstens
2009-01-15 12:16 ` Catalin Marinas
2009-01-15 12:13 ` Catalin Marinas
2009-01-15 18:18 ` linux-next: Tree for January 15 (afs/fscache) Randy Dunlap
2009-01-16 1:52 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090115120526.GD5093@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de$(echo .)ibm.com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=kamalesh@linux$(echo .)vnet.ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=penberg@cs$(echo .)helsinki.fi \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox