* linux-next: quota tree build failure
@ 2009-01-14 1:15 Stephen Rothwell
2009-01-14 14:18 ` Jan Kara
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2009-01-14 1:15 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-next
[-- Attachment #1: Type: text/plain, Size: 651 bytes --]
Hi Jan,
Today's linux-next build (x86_64 allmodconfig) failed like this:
fs/ocfs2/quota_global.c: In function 'ocfs2_dquot_initialize':
fs/ocfs2/quota_global.c:858: error: implicit declaration of function 'dquot_is_cached'
fs/ocfs2/quota_global.c: In function 'ocfs2_dquot_drop':
fs/ocfs2/quota_global.c:962: error: implicit declaration of function 'dquot_drop_locked'
Caused by commit 39a225f20e9b881f1c9431d073a62fbf38219614 ("quota:
Improve locking") which removes these functions.
I have dropped the quota tree for today.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: quota tree build failure
2009-01-14 1:15 Stephen Rothwell
@ 2009-01-14 14:18 ` Jan Kara
2009-01-14 22:23 ` Stephen Rothwell
0 siblings, 1 reply; 7+ messages in thread
From: Jan Kara @ 2009-01-14 14:18 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next
On Wed 14-01-09 12:15:51, Stephen Rothwell wrote:
> Hi Jan,
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> fs/ocfs2/quota_global.c: In function 'ocfs2_dquot_initialize':
> fs/ocfs2/quota_global.c:858: error: implicit declaration of function 'dquot_is_cached'
> fs/ocfs2/quota_global.c: In function 'ocfs2_dquot_drop':
> fs/ocfs2/quota_global.c:962: error: implicit declaration of function 'dquot_drop_locked'
>
> Caused by commit 39a225f20e9b881f1c9431d073a62fbf38219614 ("quota:
> Improve locking") which removes these functions.
OK, thanks for letting me know. OCFS2 hasn't yet merged the corresponding patch. I've
removed the patch from my for_next branch for now.
Honza
--
Jan Kara <jack@suse•cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: quota tree build failure
2009-01-14 14:18 ` Jan Kara
@ 2009-01-14 22:23 ` Stephen Rothwell
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Rothwell @ 2009-01-14 22:23 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-next
[-- Attachment #1: Type: text/plain, Size: 350 bytes --]
Hi Jan,
On Wed, 14 Jan 2009 15:18:51 +0100 Jan Kara <jack@suse•cz> wrote:
>
> OK, thanks for letting me know. OCFS2 hasn't yet merged the corresponding patch. I've
> removed the patch from my for_next branch for now.
OK, thanks.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* linux-next: quota tree build failure
@ 2009-01-19 2:01 Stephen Rothwell
2009-01-22 4:58 ` Stephen Rothwell
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2009-01-19 2:01 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-next
[-- Attachment #1: Type: text/plain, Size: 698 bytes --]
Hi Jan,
Today's linux-next build (x86_64 allmodconfig) failed like this:
fs/ocfs2/quota_global.c: In function 'ocfs2_dquot_initialize':
fs/ocfs2/quota_global.c:858: error: implicit declaration of function 'dquot_is_cached'
fs/ocfs2/quota_global.c: In function 'ocfs2_dquot_drop':
fs/ocfs2/quota_global.c:962: error: implicit declaration of function 'dquot_drop_locked'
Immediate cause is commit cc33412fb1f11613e20f9dfc2919a77ecd63fbc4
("quota: Improve locking"). If you are going to remove an API, you need
to fix up the callers.
I have dropped the quota tree for today.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: quota tree build failure
2009-01-19 2:01 Stephen Rothwell
@ 2009-01-22 4:58 ` Stephen Rothwell
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Rothwell @ 2009-01-22 4:58 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-next
[-- Attachment #1: Type: text/plain, Size: 842 bytes --]
Hi Jan,
On Mon, 19 Jan 2009 13:01:47 +1100 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> fs/ocfs2/quota_global.c: In function 'ocfs2_dquot_initialize':
> fs/ocfs2/quota_global.c:858: error: implicit declaration of function 'dquot_is_cached'
> fs/ocfs2/quota_global.c: In function 'ocfs2_dquot_drop':
> fs/ocfs2/quota_global.c:962: error: implicit declaration of function 'dquot_drop_locked'
>
> Immediate cause is commit cc33412fb1f11613e20f9dfc2919a77ecd63fbc4
> ("quota: Improve locking"). If you are going to remove an API, you need
> to fix up the callers.
>
> I have dropped the quota tree for today.
Still broken, still dropped.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* linux-next: quota tree build failure
@ 2009-02-06 3:18 Stephen Rothwell
2009-02-09 21:36 ` Jan Kara
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2009-02-06 3:18 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-next
[-- Attachment #1: Type: text/plain, Size: 516 bytes --]
Hi Jan,
Today's linux-next build (powerpc ppc64_defconfig) failed like this:
fs/nfsd/vfs.c: In function 'nfsd_setattr':
fs/nfsd/vfs.c:359: error: implicit declaration of function 'DQUOT_INIT'
Caused by commit 74d9386bc58d5f8b5bcee051e04e7123cd9cac88 ("quota: Remove
uppercase aliases for quota functions"). Seems you missed at least one
of the users.
I have dropped the quota tree for today.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: quota tree build failure
2009-02-06 3:18 linux-next: quota tree build failure Stephen Rothwell
@ 2009-02-09 21:36 ` Jan Kara
0 siblings, 0 replies; 7+ messages in thread
From: Jan Kara @ 2009-02-09 21:36 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next
Hi Stephen,
On Fri 06-02-09 14:18:06, Stephen Rothwell wrote:
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
>
> fs/nfsd/vfs.c: In function 'nfsd_setattr':
> fs/nfsd/vfs.c:359: error: implicit declaration of function 'DQUOT_INIT'
>
> Caused by commit 74d9386bc58d5f8b5bcee051e04e7123cd9cac88 ("quota: Remove
> uppercase aliases for quota functions"). Seems you missed at least one
> of the users.
Thanks for the pointer. Fixed.
Honza
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-02-09 21:36 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-06 3:18 linux-next: quota tree build failure Stephen Rothwell
2009-02-09 21:36 ` Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2009-01-19 2:01 Stephen Rothwell
2009-01-22 4:58 ` Stephen Rothwell
2009-01-14 1:15 Stephen Rothwell
2009-01-14 14:18 ` Jan Kara
2009-01-14 22:23 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox