* linux-next: genirq tree build warning
@ 2009-04-23 6:13 Stephen Rothwell
2009-04-23 6:48 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2009-04-23 6:13 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin; +Cc: linux-next, Luis Henriques
[-- Attachment #1: Type: text/plain, Size: 524 bytes --]
Hi all,
Today's linux-next build (powerpc allyesconfig gcc4.4.0) produced this
warning:
kernel/irq/manage.c: In function 'request_threaded_irq':
kernel/irq/manage.c:933: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~'
Introduced by commit ba71604fad348656071a2a76eef9a67dab85a773 ("genirq:
do not execute DEBUG_SHIRQ when irq setup failed") from the genirq tree.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: linux-next: genirq tree build warning
2009-04-23 6:13 linux-next: genirq tree build warning Stephen Rothwell
@ 2009-04-23 6:48 ` Ingo Molnar
2009-04-23 17:14 ` Luis Henriques
0 siblings, 1 reply; 3+ messages in thread
From: Ingo Molnar @ 2009-04-23 6:48 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Thomas Gleixner, H. Peter Anvin, linux-next, Luis Henriques
* Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> Hi all,
>
> Today's linux-next build (powerpc allyesconfig gcc4.4.0) produced this
> warning:
>
> kernel/irq/manage.c: In function 'request_threaded_irq':
> kernel/irq/manage.c:933: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~'
>
> Introduced by commit ba71604fad348656071a2a76eef9a67dab85a773
> ("genirq: do not execute DEBUG_SHIRQ when irq setup failed") from
> the genirq tree.
This looks like a real bug - thanks for reporting this.
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: linux-next: genirq tree build warning
2009-04-23 6:48 ` Ingo Molnar
@ 2009-04-23 17:14 ` Luis Henriques
0 siblings, 0 replies; 3+ messages in thread
From: Luis Henriques @ 2009-04-23 17:14 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Stephen Rothwell, Thomas Gleixner, H. Peter Anvin, linux-next
On Thu, Apr 23, 2009 at 08:48:09AM +0200, Ingo Molnar wrote:
>
> * Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> > Hi all,
> >
> > Today's linux-next build (powerpc allyesconfig gcc4.4.0) produced this
> > warning:
> >
> > kernel/irq/manage.c: In function 'request_threaded_irq':
> > kernel/irq/manage.c:933: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~'
> >
> > Introduced by commit ba71604fad348656071a2a76eef9a67dab85a773
> > ("genirq: do not execute DEBUG_SHIRQ when irq setup failed") from
> > the genirq tree.
>
> This looks like a real bug - thanks for reporting this.
Yep, mea culpa!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-23 17:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-23 6:13 linux-next: genirq tree build warning Stephen Rothwell
2009-04-23 6:48 ` Ingo Molnar
2009-04-23 17:14 ` Luis Henriques
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox